| Message ID | 1539669446-51996-1-git-send-email-kyeongdon.kim@lge.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2] net: fix warning in af_unix | expand |
From: Kyeongdon Kim <kyeongdon.kim@lge.com> Date: Tue, 16 Oct 2018 14:57:26 +0900 > This fixes the "'hash' may be used uninitialized in this function" > > net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized] > addr->hash = hash ^ sk->sk_type; > > Signed-off-by: Kyeongdon Kim <kyeongdon.kim@lge.com> Applied to net-next.
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index d1edfa3..98d34fb 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -225,6 +225,8 @@ static inline void unix_release_addr(struct unix_address *addr) static int unix_mkname(struct sockaddr_un *sunaddr, int len, unsigned int *hashp) { + *hashp = 0; + if (len <= sizeof(short) || len > sizeof(*sunaddr)) return -EINVAL; if (!sunaddr || sunaddr->sun_family != AF_UNIX)
This fixes the "'hash' may be used uninitialized in this function" net/unix/af_unix.c:1041:20: warning: 'hash' may be used uninitialized in this function [-Wmaybe-uninitialized] addr->hash = hash ^ sk->sk_type; Signed-off-by: Kyeongdon Kim <kyeongdon.kim@lge.com> --- net/unix/af_unix.c | 2 ++ 1 file changed, 2 insertions(+)