From patchwork Tue Oct 9 13:11:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Numan Siddique X-Patchwork-Id: 981211 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42TyLl6ZGnz9s5c for ; Wed, 10 Oct 2018 00:12:15 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3480AD3B; Tue, 9 Oct 2018 13:12:13 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7A233B1F for ; Tue, 9 Oct 2018 13:12:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 297616FB for ; Tue, 9 Oct 2018 13:12:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A39B5E1EF4 for ; Tue, 9 Oct 2018 13:12:10 +0000 (UTC) Received: from nusiddiq.redhat (ovpn-117-32.sin2.redhat.com [10.67.117.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C03E780D4; Tue, 9 Oct 2018 13:12:08 +0000 (UTC) From: nusiddiq@redhat.com To: dev@openvswitch.org Date: Tue, 9 Oct 2018 18:41:57 +0530 Message-Id: <20181009131157.26033-1-nusiddiq@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 09 Oct 2018 13:12:10 +0000 (UTC) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ovn-trace: Fix tracing when ip.dst has to go via a gateway router X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Numan Siddique ovn-trace does not trace past an l3gateway port type. This patch fixes it. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1626080 Suggested-by: Dan Williams Signed-off-by: Numan Siddique Acked-by: Mark Michelson --- ovn/utilities/ovn-trace.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 2446b3f76..40a79ceea 100644 --- a/ovn/utilities/ovn-trace.c +++ b/ovn/utilities/ovn-trace.c @@ -645,6 +645,15 @@ read_ports(void) } else if (!strcmp(sbpb->type, "l3gateway")) { /* Treat all gateways as local for our purposes. */ dp->has_local_l3gateway = true; + const char *peer_name = smap_get(&sbpb->options, "peer"); + if (peer_name) { + struct ovntrace_port *peer + = shash_find_data(&ports, peer_name); + if (peer) { + port->peer = peer; + port->peer->peer = port; + } + } } }