diff mbox series

[v1,3/4] pinctrl: geminilake: Get rid of unneeded ->probe() stub

Message ID 20181004153321.34757-3-andriy.shevchenko@linux.intel.com
State New
Headers show
Series [v1,1/4] pinctrl: geminilake: Update pin list for B0 stepping | expand

Commit Message

Andy Shevchenko Oct. 4, 2018, 3:33 p.m. UTC
The local ->probe() stub does nothing except calling
a generic Intel pin control probe function. Thus,
it's not needed and generic function may be called directly.

This patch converts the driver accordingly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-geminilake.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Mika Westerberg Oct. 8, 2018, 8:43 a.m. UTC | #1
On Thu, Oct 04, 2018 at 06:33:20PM +0300, Andy Shevchenko wrote:
> The local ->probe() stub does nothing except calling
> a generic Intel pin control probe function. Thus,
> it's not needed and generic function may be called directly.
> 
> This patch converts the driver accordingly.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
diff mbox series

Patch

diff --git a/drivers/pinctrl/intel/pinctrl-geminilake.c b/drivers/pinctrl/intel/pinctrl-geminilake.c
index 189527bee47e..84e7c00371be 100644
--- a/drivers/pinctrl/intel/pinctrl-geminilake.c
+++ b/drivers/pinctrl/intel/pinctrl-geminilake.c
@@ -493,15 +493,10 @@  static const struct acpi_device_id glk_pinctrl_acpi_match[] = {
 };
 MODULE_DEVICE_TABLE(acpi, glk_pinctrl_acpi_match);
 
-static int glk_pinctrl_probe(struct platform_device *pdev)
-{
-	return intel_pinctrl_probe_by_uid(pdev);
-}
-
 static INTEL_PINCTRL_PM_OPS(glk_pinctrl_pm_ops);
 
 static struct platform_driver glk_pinctrl_driver = {
-	.probe = glk_pinctrl_probe,
+	.probe = intel_pinctrl_probe_by_uid,
 	.driver = {
 		.name = "geminilake-pinctrl",
 		.acpi_match_table = glk_pinctrl_acpi_match,