| Message ID | 20181001225827.21946-1-leoyang.li@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL] fixes for soc/fsl drivers for v4.19 take 2 | expand |
Hi Leo, On 02.10.2018 01:58, Li Yang wrote: > Hi arm-soc maintainers, > > Please merge the updated fix for the following issue. > > Regards, > Leo > > The following changes since commit 96fc74333f84cfdf8d434c6c07254e215e2aad00: > > soc: fsl: qe: Fix copy/paste bug in ucc_get_tdm_sync_shift() (2018-09-25 13:57:26 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git soc-fsl-fix-v4.19-2 > > for you to fetch changes up to 5a1eb8b9542884592a018829bb1ff20c9695d925: > > soc: fsl: qman_portals: defer probe after qman's probe (2018-10-01 17:47:43 -0500) > > ---------------------------------------------------------------- > NXP/FSL SoC driver fixes for v4.19 round 2 > > - Fix crash of qman_portal by deferring its probe if qman is not probed > > ---------------------------------------------------------------- > Laurentiu Tudor (2): > soc: fsl: qbman: add APIs to retrieve the probing status > soc: fsl: qman_portals: defer probe after qman's probe There's a similar fix for bman portals [1]. I was under the impression that you plan to pick that up too. [1] "soc/fsl/bman_portals: defer probe after bman's probe", found here: https://lore.kernel.org/patchwork/patch/992009/ --- Thanks & Best Regards, Laurentiu
On Thu, Oct 4, 2018 at 11:39 AM Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote: > > > ---------------------------------------------------------------- > > NXP/FSL SoC driver fixes for v4.19 round 2 > > > > - Fix crash of qman_portal by deferring its probe if qman is not probed > > > > ---------------------------------------------------------------- > > Laurentiu Tudor (2): > > soc: fsl: qbman: add APIs to retrieve the probing status > > soc: fsl: qman_portals: defer probe after qman's probe > > There's a similar fix for bman portals [1]. I was under the impression > that you plan to pick that up too. > > [1] "soc/fsl/bman_portals: defer probe after bman's probe", found here: > https://lore.kernel.org/patchwork/patch/992009/ I've pulled the first two into the fixes branch for now, but it does sound like we need the third patch as well. The new interface seems a bit odd, since it does not pass an instance pointer at all, but instead relies on the idea that there is only one qman/bman instance in the system. While this may be true in all cases, generally our driver interfaces should be based around device objects instead of making assumptions like this. I assume that is part of what led to the bug in the first place. Of course that is nothing that can be changed easily, and the bug needs to be fixed, so I have pulled the fixes for 4.19, but it would be good to see if the interfaces could be restructured to behave more like other subsystems in the future. Arnd
On Thu, Oct 4, 2018 at 4:40 AM Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote: > > Hi Leo, > > On 02.10.2018 01:58, Li Yang wrote: > > Hi arm-soc maintainers, > > > > Please merge the updated fix for the following issue. > > > > Regards, > > Leo > > > > The following changes since commit 96fc74333f84cfdf8d434c6c07254e215e2aad00: > > > > soc: fsl: qe: Fix copy/paste bug in ucc_get_tdm_sync_shift() (2018-09-25 13:57:26 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git soc-fsl-fix-v4.19-2 > > > > for you to fetch changes up to 5a1eb8b9542884592a018829bb1ff20c9695d925: > > > > soc: fsl: qman_portals: defer probe after qman's probe (2018-10-01 17:47:43 -0500) > > > > ---------------------------------------------------------------- > > NXP/FSL SoC driver fixes for v4.19 round 2 > > > > - Fix crash of qman_portal by deferring its probe if qman is not probed > > > > ---------------------------------------------------------------- > > Laurentiu Tudor (2): > > soc: fsl: qbman: add APIs to retrieve the probing status > > soc: fsl: qman_portals: defer probe after qman's probe > > There's a similar fix for bman portals [1]. I was under the impression > that you plan to pick that up too. > > [1] "soc/fsl/bman_portals: defer probe after bman's probe", found here: > https://lore.kernel.org/patchwork/patch/992009/ As mentioned in the patch description, it doesn't trigger a crash right now. It might not be qualified as a fix, so on a second thought, I move it to the for-next pull request. Regards, Leo
Hi arm-soc maintainers, Please merge the updated fix for the following issue. Regards, Leo The following changes since commit 96fc74333f84cfdf8d434c6c07254e215e2aad00: soc: fsl: qe: Fix copy/paste bug in ucc_get_tdm_sync_shift() (2018-09-25 13:57:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git soc-fsl-fix-v4.19-2 for you to fetch changes up to 5a1eb8b9542884592a018829bb1ff20c9695d925: soc: fsl: qman_portals: defer probe after qman's probe (2018-10-01 17:47:43 -0500) ---------------------------------------------------------------- NXP/FSL SoC driver fixes for v4.19 round 2 - Fix crash of qman_portal by deferring its probe if qman is not probed ---------------------------------------------------------------- Laurentiu Tudor (2): soc: fsl: qbman: add APIs to retrieve the probing status soc: fsl: qman_portals: defer probe after qman's probe drivers/soc/fsl/qbman/bman_ccsr.c | 11 +++++++++++ drivers/soc/fsl/qbman/qman_ccsr.c | 11 +++++++++++ drivers/soc/fsl/qbman/qman_portal.c | 8 ++++++++ include/soc/fsl/bman.h | 8 ++++++++ include/soc/fsl/qman.h | 8 ++++++++ 5 files changed, 46 insertions(+)