[ovs-dev,v2,1/2] dpif-netdev-unixctl: Change 'masked' to 'megaflow'.

Message ID 20180928112413.10792-2-i.maximets@samsung.com
State Accepted
Delegated to: Ian Stokes
Headers show
Series
  • dpif-netdev: Docs and stats fixes.
Related show

Commit Message

Ilya Maximets Sept. 28, 2018, 11:24 a.m.
In the review process of the original patch 'masked hits' stat
was renamed to 'megaflow hits', but the man page wasn't updated.

Fixes: 6553d06bd179 ("dpif-netdev: Add dpif-netdev/pmd-stats-*
                      appctl commands.")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
 lib/dpif-netdev-unixctl.man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stokes, Ian Oct. 10, 2018, 6:17 p.m. | #1
> In the review process of the original patch 'masked hits' stat was renamed
> to 'megaflow hits', but the man page wasn't updated.
> 
> Fixes: 6553d06bd179 ("dpif-netdev: Add dpif-netdev/pmd-stats-*
>                       appctl commands.")
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>  lib/dpif-netdev-unixctl.man | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man
> index ab8619e41..c46f6b19c 100644
> --- a/lib/dpif-netdev-unixctl.man
> +++ b/lib/dpif-netdev-unixctl.man
> @@ -11,7 +11,7 @@ Shows performance statistics for one or all pmd threads
> of the datapath  \fIdp\fR. The special thread "main" sums up the
> statistics of every non pmd  thread.
> 
> -The sum of "emc hits", "masked hits" and "miss" is the number of
> +The sum of "emc hits", "megaflow hits" and "miss" is the number of
>  packet lookups performed by the datapath. Beware that a recirculated
> packet  experiences one additional lookup per recirculation, so there may
> be  more lookups than forwarded packets in the datapath.

Thanks Ilya, seems pretty straight forward. Will add this to this weeks pull request.

Ian

Patch

diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man
index ab8619e41..c46f6b19c 100644
--- a/lib/dpif-netdev-unixctl.man
+++ b/lib/dpif-netdev-unixctl.man
@@ -11,7 +11,7 @@  Shows performance statistics for one or all pmd threads of the datapath
 \fIdp\fR. The special thread "main" sums up the statistics of every non pmd
 thread.
 
-The sum of "emc hits", "masked hits" and "miss" is the number of
+The sum of "emc hits", "megaflow hits" and "miss" is the number of
 packet lookups performed by the datapath. Beware that a recirculated packet
 experiences one additional lookup per recirculation, so there may be
 more lookups than forwarded packets in the datapath.