Message ID | 1536269914-6739-1-git-send-email-gvrose8192@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] erspan: set erspan_ver to 1 by default when adding an erspan dev | expand |
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Xin Long <lucien.xin@gmail.com> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Greg Rose <gvrose8192@gmail.com> Lines checked: 71, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@bytheb.org Thanks, 0-day Robot
On 9/6/2018 2:57 PM, 0-day Robot wrote: > Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Author Xin Long <lucien.xin@gmail.com> needs to sign off. > WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Greg Rose <gvrose8192@gmail.com> > Lines checked: 71, Warnings: 1, Errors: 1 > > > Please check this out. If you feel there has been an error, please email aconole@bytheb.org > > Thanks, > 0-day Robot This seems like a false positive to me. Thanks, - Greg
On Thu, Sep 06, 2018 at 03:11:37PM -0700, Gregory Rose wrote: > On 9/6/2018 2:57 PM, 0-day Robot wrote: > >Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. > >Thanks for your contribution. > > > >I encountered some error that I wasn't expecting. See the details below. > > > > > >checkpatch: > >ERROR: Author Xin Long <lucien.xin@gmail.com> needs to sign off. > >WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Greg Rose <gvrose8192@gmail.com> > >Lines checked: 71, Warnings: 1, Errors: 1 > > > > > >Please check this out. If you feel there has been an error, please email aconole@bytheb.org > > > >Thanks, > >0-day Robot > > This seems like a false positive to me. Agreed. Backports are kind of weird commits. I applied this to master and branch-2.10.
On 9/6/2018 4:01 PM, Ben Pfaff wrote: > On Thu, Sep 06, 2018 at 03:11:37PM -0700, Gregory Rose wrote: >> On 9/6/2018 2:57 PM, 0-day Robot wrote: >>> Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. >>> Thanks for your contribution. >>> >>> I encountered some error that I wasn't expecting. See the details below. >>> >>> >>> checkpatch: >>> ERROR: Author Xin Long <lucien.xin@gmail.com> needs to sign off. >>> WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Greg Rose <gvrose8192@gmail.com> >>> Lines checked: 71, Warnings: 1, Errors: 1 >>> >>> >>> Please check this out. If you feel there has been an error, please email aconole@bytheb.org >>> >>> Thanks, >>> 0-day Robot >> This seems like a false positive to me. > Agreed. Backports are kind of weird commits. > > I applied this to master and branch-2.10. Thanks Ben!
diff --git a/datapath/linux/compat/ip6_gre.c b/datapath/linux/compat/ip6_gre.c index 3904455..00dbefc 100644 --- a/datapath/linux/compat/ip6_gre.c +++ b/datapath/linux/compat/ip6_gre.c @@ -1979,6 +1979,7 @@ static void ip6gre_netlink_parms(struct nlattr *data[], if (data[IFLA_GRE_COLLECT_METADATA]) parms->collect_md = true; + parms->erspan_ver = 1; if (data[IFLA_GRE_ERSPAN_VER]) parms->erspan_ver = nla_get_u8(data[IFLA_GRE_ERSPAN_VER]); diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c index 47ed5e0..05132ba 100644 --- a/datapath/linux/compat/ip_gre.c +++ b/datapath/linux/compat/ip_gre.c @@ -1222,12 +1222,15 @@ static void ipgre_tap_setup(struct net_device *dev) static void erspan_setup(struct net_device *dev) { + struct ip_tunnel *t = netdev_priv(dev); + eth_hw_addr_random(dev); ether_setup(dev); dev->netdev_ops = &erspan_netdev_ops; dev->priv_flags &= ~IFF_TX_SKB_SHARING; dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; ip_tunnel_setup(dev, erspan_net_id); + t->erspan_ver = 1; } #ifdef HAVE_EXT_ACK_IN_RTNL_LINKOPS