Message ID | 1536029091-4426-10-git-send-email-climbbb.kim@gmail.com |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=198.137.202.133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ABKcFTJM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QhfZggvx"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 424B6N4YMYz9s4s for <incoming@patchwork.ozlabs.org>; Tue, 4 Sep 2018 12:46:04 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RX4oBINa6YofGmmtoPx57URVdVot7gF5yUY+5/vPK2c=; b=ABKcFTJMQV5L8IrPIwzAImlssZ QTsAK8LPxgI/l3Jiko22S9tnUCg4DP2BlfdQlWshprtB/WUP+g54S1npKE9+VEcJpgiAnqZsu4E7t YU+jIGQrViKes8MF41Kq85aQXwXcagWkQO0qYsI7v3WHoWvx9nRT4VEhCzpt3oU59oCZuH6tVbQa5 dzLcL9yspH4SIkLNfJB6ri0ujiKO93b+M4OBr+iL/bdGCH5FzDacV/ooIC1FIlIStngycvME/eHz9 ZFWtmhxolxrl+aM8xudUu2fWHCqYYSDGvJGyKYAG5lR0Kwc8nhW94oUAO37h5MxX7I+eMSaUU0lAf sluyt50A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Ln-0005Rz-EY; Tue, 04 Sep 2018 02:45:55 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fx1Lj-0005N3-NT for linux-um@lists.infradead.org; Tue, 04 Sep 2018 02:45:53 +0000 Received: by mail-pg1-x542.google.com with SMTP id i190-v6so889210pgc.6 for <linux-um@lists.infradead.org>; Mon, 03 Sep 2018 19:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dyMlBOGeR+D0F4OT1Om3Yr3zP9Ae/55Ycb8svx7U5Mg=; b=QhfZggvx83W0O89c3yAbEiVMTTX22/0zyGMRqaMmINsTlxO+cP0mDSJvTqhJWWs8Uc PgNeg0xfs8gRwIOvLy7yuiFv93VFaQhjvfqZjWv1dwM1zErUvPvlFN3Bbs1g2hjjXJAQ rDynjHDzeg32MCnqCx+yXuGdPnu5bQSQ+RfVAGyS+1q8KhF+gHg6lEQcJfUgW07HMeNI jReihwOr5iC432Htt06o1rVB4BgD6Kj0BPRlbZig+YBxuAjnWo3gwcF8J/J7nkNkamr+ yPAia5tAa2lSHd6yLaYHwOYf9Lmr537UREYwR+wVU5WdfFdrEnN9Jpi7hJOAWOdlwJFQ XKQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dyMlBOGeR+D0F4OT1Om3Yr3zP9Ae/55Ycb8svx7U5Mg=; b=Z3YxBEBNEN/NJvc0CSBZFBYWzktxMYau1O3VVDg1YcnBQ8FhKRpJCpmd6waymYOZ53 QUG3zEN7Qcvd6orQO62pkopFADFA+76g429Y0XabapQN5kOPBo+vjvzGuFOmv4bjfk08 s7tltdX98ewhXk3RDFU4MkdD5C/SFrwBIw0PP8no1xE1eJH6614Lt26sA5exKw9sFAK3 uo6BJuStSewb4CCHs/LiWW2DkUqriUPX3wFx2nAk/NTeKEpzCWJ6koJhY59skPGnzzUj Lc68825cbC2OvQmI4pt1rrYVc/1KeOQURZf89FD1tS3ztWFbQ3U5bxoyuR5wIdZgDNOi caVA== X-Gm-Message-State: APzg51CYy81IZPKd01u6PFgJ5jV/SlACx8xaRQmW9WTtmGFrnUQ5N8ka Yyf2v+PGRhLJvvtfQEMjR5dHehj9 X-Google-Smtp-Source: ANB0VdbBB27REFELXmkSR3Ls51IBSoxSFVaXs34gzAubu6s7F3RUZ7R/r+859kfbcPLm7bwqyj9HKw== X-Received: by 2002:a62:3545:: with SMTP id c66-v6mr32459487pfa.63.1536029141033; Mon, 03 Sep 2018 19:45:41 -0700 (PDT) Received: from climb.lge.net ([27.122.242.77]) by smtp.gmail.com with ESMTPSA id w16-v6sm33663284pfi.101.2018.09.03.19.45.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Sep 2018 19:45:40 -0700 (PDT) From: Jaejoong Kim <climbbb.kim@gmail.com> To: linux-um@lists.infradead.org, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/25] tty: serial: kgdb_nmi: Change return type to void Date: Tue, 4 Sep 2018 11:44:35 +0900 Message-Id: <1536029091-4426-10-git-send-email-climbbb.kim@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> References: <1536029091-4426-1-git-send-email-climbbb.kim@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_194551_762059_73BA17D8 X-CRM114-Status: GOOD ( 13.54 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:542 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (climbbb.kim[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-um.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-um/> List-Post: <mailto:linux-um@lists.infradead.org> List-Help: <mailto:linux-um-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-um>, <mailto:linux-um-request@lists.infradead.org?subject=subscribe> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" <linux-um-bounces@lists.infradead.org> Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Change tty_port(standard)_install's return type
|
expand
|
diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c index 4029272..ed8f806 100644 --- a/drivers/tty/serial/kgdb_nmi.c +++ b/drivers/tty/serial/kgdb_nmi.c @@ -234,7 +234,6 @@ static const struct tty_port_operations kgdb_nmi_tty_port_ops = { static int kgdb_nmi_tty_install(struct tty_driver *drv, struct tty_struct *tty) { struct kgdb_nmi_tty_priv *priv; - int ret; priv = kzalloc(sizeof(*priv), GFP_KERNEL); if (!priv) @@ -245,17 +244,9 @@ static int kgdb_nmi_tty_install(struct tty_driver *drv, struct tty_struct *tty) tty_port_init(&priv->port); priv->port.ops = &kgdb_nmi_tty_port_ops; tty->driver_data = priv; + tty_port_install(&priv->port, drv, tty); - ret = tty_port_install(&priv->port, drv, tty); - if (ret) { - pr_err("%s: can't install tty port: %d\n", __func__, ret); - goto err; - } return 0; -err: - tty_port_destroy(&priv->port); - kfree(priv); - return ret; } static void kgdb_nmi_tty_cleanup(struct tty_struct *tty)
Since tty_port_install() always returns 0, the return type has changed to void. Now apply this and remove the obsolete error check. Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com> --- drivers/tty/serial/kgdb_nmi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)