| Message ID | 20180831185243.115867-1-martinxu9.ovs@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v1,1/5] rhel: openvswitch-kmod-fedora.spec.in file bug fix | expand |
On Fri, Aug 31, 2018 at 11:52:39AM -0700, Martin Xu wrote: > Patch 22c33c303932 used /usr/src/linux/<kernel version> as path of the > linux headers, which does not work for SLES. Use /lib/modules/<kernel > version>/build instead. > > Fixes 22c33c303932 (rhel: support kmod build against mulitple kernel versions, > fedora) > > Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com> > CC: Greg Rose <gvrose8192@gmail.com> > CC: Markos Chandras <mchandras@suse.de> > --- > rhel/openvswitch-kmod-fedora.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rhel/openvswitch-kmod-fedora.spec.in b/rhel/openvswitch-kmod-fedora.spec.in > index dc5ea7a1b..28827e245 100644 > --- a/rhel/openvswitch-kmod-fedora.spec.in > +++ b/rhel/openvswitch-kmod-fedora.spec.in > @@ -47,7 +47,7 @@ traffic. This package contains the kernel modules. > for kv in %{kversion}; do > mkdir -p _$kv > (cd _$kv && /bin/cp -f ../configure . && %configure --srcdir=.. \ > - --with-linux=/usr/src/kernels/${kv}/ --enable-ssl) > + --with-linux=/lib/modules/${kv}/build --enable-ssl) > make %{_smp_mflags} -C _$kv/datapath/linux > done The /lib/modules/${kv}/build is a symlink to /usr/src/kernels/${kv}/ on Fedora, so the patch looks good. Acked-by: Flavio Leitner <fbl@sysclose.org> fbl
On 03/09/18 18:58, Flavio Leitner wrote: > > The /lib/modules/${kv}/build is a symlink to /usr/src/kernels/${kv}/ > on Fedora, so the patch looks good. > > Acked-by: Flavio Leitner <fbl@sysclose.org> > > fbl > This works on SUSE as well Reviewed-by: Markos Chandras <mchandras@suse.de>
Martin, I see that all of the patches in this series have been acked by appropriate people, except for patch 3. Should I apply the acked patches from the series? Thanks, Ben.
Hi Ben, Yes, please. We'll brainstorm on what to do for the purpose of patch 3 separately. Thanks! Martin On Wed, Sep 5, 2018 at 2:04 PM Ben Pfaff <blp@ovn.org> wrote: > Martin, I see that all of the patches in this series have been acked by > appropriate people, except for patch 3. Should I apply the acked > patches from the series? > > Thanks, > > Ben. >
Great. I applied patches 1, 2, and 4. I skipped patch 3. I did not apply patch 5 because I got a patch reject, presumably because I skipped patch 3. If you want to repost just patch 5, rebased (please add the acks and reviews too), I'll apply it too. Thanks, Ben. On Wed, Sep 05, 2018 at 02:06:25PM -0700, Martin Xu wrote: > Hi Ben, > > Yes, please. We'll brainstorm on what to do for the purpose of patch 3 > separately. Thanks! > > Martin > > On Wed, Sep 5, 2018 at 2:04 PM Ben Pfaff <blp@ovn.org> wrote: > > > Martin, I see that all of the patches in this series have been acked by > > appropriate people, except for patch 3. Should I apply the acked > > patches from the series? > > > > Thanks, > > > > Ben. > >
diff --git a/rhel/openvswitch-kmod-fedora.spec.in b/rhel/openvswitch-kmod-fedora.spec.in index dc5ea7a1b..28827e245 100644 --- a/rhel/openvswitch-kmod-fedora.spec.in +++ b/rhel/openvswitch-kmod-fedora.spec.in @@ -47,7 +47,7 @@ traffic. This package contains the kernel modules. for kv in %{kversion}; do mkdir -p _$kv (cd _$kv && /bin/cp -f ../configure . && %configure --srcdir=.. \ - --with-linux=/usr/src/kernels/${kv}/ --enable-ssl) + --with-linux=/lib/modules/${kv}/build --enable-ssl) make %{_smp_mflags} -C _$kv/datapath/linux done
Patch 22c33c303932 used /usr/src/linux/<kernel version> as path of the linux headers, which does not work for SLES. Use /lib/modules/<kernel version>/build instead. Fixes 22c33c303932 (rhel: support kmod build against mulitple kernel versions, fedora) Signed-off-by: Martin Xu <martinxu9.ovs@gmail.com> CC: Greg Rose <gvrose8192@gmail.com> CC: Markos Chandras <mchandras@suse.de> --- rhel/openvswitch-kmod-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)