[v8,15/16] mesh: don't allow pri/sec channel switch
diff mbox series

Message ID b7e081b0af591fdc065c34aafe90fea91f735b7f.1535403927.git.peter.oh@bowerswilkins.com
State Changes Requested
Headers show
Series
  • mesh: enable DFS channels in mesh mode
Related show

Commit Message

Peter Oh Aug. 27, 2018, 9:28 p.m. UTC
From: Peter Oh <peter.oh@bowerswilkins.com>

This limitation isn't backed by standard, but it is known that
mesh doesn't have capability to handle 20/40 coex change in
current implementation and it will not able to establish
PLINK when channel switch between primary and secondary happens.

Since it's unknown when we will have the implementation of handling
20/40 coex change for mesh, it'd better to avoid them from happening
until standard based implementation is introduced.

Signed-off-by: Peter Oh <peter.oh@bowerswilkins.com>
---
 wpa_supplicant/mesh.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jouni Malinen Jan. 3, 2019, 1:42 p.m. UTC | #1
On Mon, Aug 27, 2018 at 02:28:48PM -0700, peter.oh@bowerswilkins.com wrote:
> This limitation isn't backed by standard, but it is known that
> mesh doesn't have capability to handle 20/40 coex change in
> current implementation and it will not able to establish
> PLINK when channel switch between primary and secondary happens.
> 
> Since it's unknown when we will have the implementation of handling
> 20/40 coex change for mesh, it'd better to avoid them from happening
> until standard based implementation is introduced.

This does not sound acceptable approach to me.
Peter Oh May 15, 2019, 9:09 p.m. UTC | #2
On 01/03/2019 05:42 AM, Jouni Malinen wrote:
> On Mon, Aug 27, 2018 at 02:28:48PM -0700, peter.oh@bowerswilkins.com wrote:
>> This limitation isn't backed by standard, but it is known that
>> mesh doesn't have capability to handle 20/40 coex change in
>> current implementation and it will not able to establish
>> PLINK when channel switch between primary and secondary happens.
>>
>> Since it's unknown when we will have the implementation of handling
>> 20/40 coex change for mesh, it'd better to avoid them from happening
>> until standard based implementation is introduced.
> This does not sound acceptable approach to me.
>
I'll try to figure out what the right approach could be.
So this will be dropped from a new patch series until then since it's 
not really related to DFS functionality.

Thanks,
Peter

Patch
diff mbox series

diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
index a714c15..b4b3ae9 100644
--- a/wpa_supplicant/mesh.c
+++ b/wpa_supplicant/mesh.c
@@ -407,6 +407,7 @@  static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
 		conf->basic_rates[rate_len] = -1;
 	}
 
+	conf->no_pri_sec_switch = 1;
 	wpa_supplicant_conf_ap_ht(wpa_s, ssid, conf);
 
 	if (wpa_drv_init_mesh(wpa_s)) {