| Message ID | 20180821155235.89090-1-agraf@suse.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,PULL,2018.09] efi patch queue 2018-08-21 | expand |
Hi Alex, On 21 August 2018 at 09:52, Alexander Graf <agraf@suse.de> wrote: > Hi Tom, > > This is my current patch queue for efi to be applied for 2018.09. Please pull. > > Alex I still think we should be reverting the offending patch rather than patching on top of it. Are you able to apply my sandbox revert patch in this pull request? > > > The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931: > > Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400) > > are available in the git repository at: > > git://github.com/agraf/u-boot.git tags/signed-efi-2018.09 > > for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83: > > cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200) > > ---------------------------------------------------------------- > Patch queue for efi - 2018-08-21 > > A few fixes for 2018.09. Most noticable are: > > - unbreak x86 target (-fdata-section fallout) > - fix undefined behavior in a few corner cases > - make Jetson TX1 boot again > - RTS fixes > - implement reset for simple output > > ---------------------------------------------------------------- > AKASHI Takahiro (1): > efi_loader: fix a parameter check at CreateEvent() > > Alexander Graf (4): > sandbox: Move BSS after EFI sections > x86: Include bss subsections in linker script > x86: Enable -fdata-sections always > riscv: Include bss subsections in linker script > > Eugeniu Rosca (3): > efi: Fix truncation of constant value > efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes > cmd: efi: Clarify calculation precedence for '&' and '?' > > Heinrich Schuchardt (7): > efi_loader: relocate pointer to tables > efi_loader: avoid NULL dereference in efi_get_memory_map() > lib: crc32: mark function crc32() as __efi_runtime > efi_loader: update runtime services table crc32 > efi_loader: document runtime functions > efi_selftest: correct block device unit test > efi_loader: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.Reset() > > Stephen Warren (1): > Revert "efi_loader: efi_allocate_pages is too restrictive" > > arch/riscv/cpu/ax25/u-boot.lds | 2 +- > arch/sandbox/cpu/u-boot.lds | 5 +- > arch/x86/config.mk | 4 +- > arch/x86/cpu/u-boot-64.lds | 2 +- > arch/x86/cpu/u-boot.lds | 2 +- > arch/x86/lib/elf_ia32_efi.lds | 2 +- > arch/x86/lib/elf_x86_64_efi.lds | 2 +- > cmd/efi.c | 27 ++-- > include/efi.h | 28 ++--- > include/efi_loader.h | 3 + > lib/crc32.c | 26 ++-- > lib/efi_loader/efi_boottime.c | 15 +-- > lib/efi_loader/efi_console.c | 22 ++-- > lib/efi_loader/efi_memory.c | 13 +- > lib/efi_loader/efi_runtime.c | 177 ++++++++++++++++++++++++++- > lib/efi_selftest/efi_selftest_block_device.c | 2 +- > 16 files changed, 250 insertions(+), 82 deletions(-) > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Regards, Simon
On Tue, Aug 21, 2018 at 11:31:41AM -0600, Simon Glass wrote: > Hi Alex, > > On 21 August 2018 at 09:52, Alexander Graf <agraf@suse.de> wrote: > > Hi Tom, > > > > This is my current patch queue for efi to be applied for 2018.09. Please pull. > > > > Alex > > I still think we should be reverting the offending patch rather than > patching on top of it. Given that, if I'm following right, the fix for this issue is some correct-by-inspection linker script fixes, I think it's OK to make the changes now. > > Are you able to apply my sandbox revert patch in this pull request? > > > > > > > The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931: > > > > Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400) > > > > are available in the git repository at: > > > > git://github.com/agraf/u-boot.git tags/signed-efi-2018.09 > > > > for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83: > > > > cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200) > > > > ---------------------------------------------------------------- > > Patch queue for efi - 2018-08-21 > > > > A few fixes for 2018.09. Most noticable are: > > > > - unbreak x86 target (-fdata-section fallout) > > - fix undefined behavior in a few corner cases > > - make Jetson TX1 boot again > > - RTS fixes > > - implement reset for simple output > > > > ---------------------------------------------------------------- > > AKASHI Takahiro (1): > > efi_loader: fix a parameter check at CreateEvent() > > > > Alexander Graf (4): > > sandbox: Move BSS after EFI sections > > x86: Include bss subsections in linker script > > x86: Enable -fdata-sections always > > riscv: Include bss subsections in linker script > > > > Eugeniu Rosca (3): > > efi: Fix truncation of constant value > > efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes > > cmd: efi: Clarify calculation precedence for '&' and '?' > > > > Heinrich Schuchardt (7): > > efi_loader: relocate pointer to tables > > efi_loader: avoid NULL dereference in efi_get_memory_map() > > lib: crc32: mark function crc32() as __efi_runtime > > efi_loader: update runtime services table crc32 > > efi_loader: document runtime functions > > efi_selftest: correct block device unit test > > efi_loader: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.Reset() > > > > Stephen Warren (1): > > Revert "efi_loader: efi_allocate_pages is too restrictive" > > > > arch/riscv/cpu/ax25/u-boot.lds | 2 +- > > arch/sandbox/cpu/u-boot.lds | 5 +- > > arch/x86/config.mk | 4 +- > > arch/x86/cpu/u-boot-64.lds | 2 +- > > arch/x86/cpu/u-boot.lds | 2 +- > > arch/x86/lib/elf_ia32_efi.lds | 2 +- > > arch/x86/lib/elf_x86_64_efi.lds | 2 +- > > cmd/efi.c | 27 ++-- > > include/efi.h | 28 ++--- > > include/efi_loader.h | 3 + > > lib/crc32.c | 26 ++-- > > lib/efi_loader/efi_boottime.c | 15 +-- > > lib/efi_loader/efi_console.c | 22 ++-- > > lib/efi_loader/efi_memory.c | 13 +- > > lib/efi_loader/efi_runtime.c | 177 ++++++++++++++++++++++++++- > > lib/efi_selftest/efi_selftest_block_device.c | 2 +- > > 16 files changed, 250 insertions(+), 82 deletions(-) > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > Regards, > Simon
On 21.08.18 19:42, Tom Rini wrote: > On Tue, Aug 21, 2018 at 11:31:41AM -0600, Simon Glass wrote: >> Hi Alex, >> >> On 21 August 2018 at 09:52, Alexander Graf <agraf@suse.de> wrote: >>> Hi Tom, >>> >>> This is my current patch queue for efi to be applied for 2018.09. Please pull. >>> >>> Alex >> >> I still think we should be reverting the offending patch rather than >> patching on top of it. > > Given that, if I'm following right, the fix for this issue is some > correct-by-inspection linker script fixes, I think it's OK to make the > changes now. Yeah, I think for x86 the only good way forward is to fix the linker script issues, as the data/function section addition fixed real life bugs with implicitly generated .rodata objects. > >> >> Are you able to apply my sandbox revert patch in this pull request? I can't apply anything to this pull request anymore because it's signed. I could do a new one, but I think it's easier to apply this one as is and then apply your revert for sandbox on top. Alex
On Tue, Aug 21, 2018 at 05:52:35PM +0200, Alexander Graf wrote: > Hi Tom, > > This is my current patch queue for efi to be applied for 2018.09. Please pull. > > Alex > > > The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931: > > Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400) > > are available in the git repository at: > > git://github.com/agraf/u-boot.git tags/signed-efi-2018.09 > > for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83: > > cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200) > Applied to u-boot/master, thanks!
Hi Tom, This is my current patch queue for efi to be applied for 2018.09. Please pull. Alex The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931: Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400) are available in the git repository at: git://github.com/agraf/u-boot.git tags/signed-efi-2018.09 for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83: cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200) ---------------------------------------------------------------- Patch queue for efi - 2018-08-21 A few fixes for 2018.09. Most noticable are: - unbreak x86 target (-fdata-section fallout) - fix undefined behavior in a few corner cases - make Jetson TX1 boot again - RTS fixes - implement reset for simple output ---------------------------------------------------------------- AKASHI Takahiro (1): efi_loader: fix a parameter check at CreateEvent() Alexander Graf (4): sandbox: Move BSS after EFI sections x86: Include bss subsections in linker script x86: Enable -fdata-sections always riscv: Include bss subsections in linker script Eugeniu Rosca (3): efi: Fix truncation of constant value efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes cmd: efi: Clarify calculation precedence for '&' and '?' Heinrich Schuchardt (7): efi_loader: relocate pointer to tables efi_loader: avoid NULL dereference in efi_get_memory_map() lib: crc32: mark function crc32() as __efi_runtime efi_loader: update runtime services table crc32 efi_loader: document runtime functions efi_selftest: correct block device unit test efi_loader: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.Reset() Stephen Warren (1): Revert "efi_loader: efi_allocate_pages is too restrictive" arch/riscv/cpu/ax25/u-boot.lds | 2 +- arch/sandbox/cpu/u-boot.lds | 5 +- arch/x86/config.mk | 4 +- arch/x86/cpu/u-boot-64.lds | 2 +- arch/x86/cpu/u-boot.lds | 2 +- arch/x86/lib/elf_ia32_efi.lds | 2 +- arch/x86/lib/elf_x86_64_efi.lds | 2 +- cmd/efi.c | 27 ++-- include/efi.h | 28 ++--- include/efi_loader.h | 3 + lib/crc32.c | 26 ++-- lib/efi_loader/efi_boottime.c | 15 +-- lib/efi_loader/efi_console.c | 22 ++-- lib/efi_loader/efi_memory.c | 13 +- lib/efi_loader/efi_runtime.c | 177 ++++++++++++++++++++++++++- lib/efi_selftest/efi_selftest_block_device.c | 2 +- 16 files changed, 250 insertions(+), 82 deletions(-)