diff mbox series

powerpc/64: Remove static branch hints from memset()

Message ID 20180821010412.23806-1-anton@ozlabs.org (mailing list archive)
State Accepted
Commit be54c1216f6689a6eb504e3471d0cb41cc9d9809
Headers show
Series powerpc/64: Remove static branch hints from memset() | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success next/apply_patch Successfully applied
snowpatch_ozlabs/checkpatch success Test checkpatch on branch next
snowpatch_ozlabs/build-ppc64le success Test build-ppc64le on branch next
snowpatch_ozlabs/build-ppc64be success Test build-ppc64be on branch next
snowpatch_ozlabs/build-ppc64e success Test build-ppc64e on branch next
snowpatch_ozlabs/build-ppc32 success Test build-ppc32 on branch next

Commit Message

Anton Blanchard Aug. 21, 2018, 1:04 a.m. UTC 
From: Anton Blanchard <anton@samba.org>

Static branch hints override dynamic branch prediction on recent
POWER CPUs. We should only use them when we are overwhelmingly
sure of the direction.

Signed-off-by: Anton Blanchard <anton@samba.org>
---
 arch/powerpc/lib/mem_64.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Ellerman Sept. 20, 2018, 4:20 a.m. UTC | #1 
On Tue, 2018-08-21 at 01:04:12 UTC, Anton Blanchard wrote:
> From: Anton Blanchard <anton@samba.org>
> 
> Static branch hints override dynamic branch prediction on recent
> POWER CPUs. We should only use them when we are overwhelmingly
> sure of the direction.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/be54c1216f6689a6eb504e3471d0cb

cheers
diff mbox series

Patch

diff --git a/arch/powerpc/lib/mem_64.S b/arch/powerpc/lib/mem_64.S
index ec531de99996..3c3be02f33b7 100644
--- a/arch/powerpc/lib/mem_64.S
+++ b/arch/powerpc/lib/mem_64.S
@@ -40,7 +40,7 @@  _GLOBAL(memset)
 .Lms:	PPC_MTOCRF(1,r0)
 	mr	r6,r3
 	blt	cr1,8f
-	beq+	3f			/* if already 8-byte aligned */
+	beq	3f			/* if already 8-byte aligned */
 	subf	r5,r0,r5
 	bf	31,1f
 	stb	r4,0(r6)
@@ -85,7 +85,7 @@  _GLOBAL(memset)
 	addi	r6,r6,8
 8:	cmpwi	r5,0
 	PPC_MTOCRF(1,r5)
-	beqlr+
+	beqlr
 	bf	29,9f
 	stw	r4,0(r6)
 	addi	r6,r6,4