| Message ID | 20180818221019.4384-1-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Commit | a8cea94d5a6a63b6dd766068dd867670c1fb99f3 |
| Headers | show |
| Series | core: drop useless assignements to BISON and FLEX | expand |
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > They were added back in 5432f26f0 (Adding Central config.cache options), > supposedly to be able to cache the result of configure tests, but they > were never, ever referenced anywhere in our code... Besides, we dropped > the idea of getting a configure cache long ago now (it does not work)... > They are causing spurious error messages on some distros (e.g. Fedora) > which use GNU's which (whatever package that comes from), while it is > silent on other distros (e.g. Ubuntu) which use debianutils' which. > Drop them. > Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Committed, thanks.
diff --git a/package/Makefile.in b/package/Makefile.in index f2962767cc..91b3e8f936 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -219,8 +219,6 @@ TARGET_STRIP = /bin/true STRIPCMD = $(TARGET_STRIP) endif INSTALL := $(shell which install || type -p install) -FLEX := $(shell which flex || type -p flex) -BISON := $(shell which bison || type -p bison) UNZIP := $(shell which unzip || type -p unzip) -q APPLY_PATCHES = PATH=$(HOST_DIR)/bin:$$PATH support/scripts/apply-patches.sh $(if $(QUIET),-s)
They were added back in 5432f26f0 (Adding Central config.cache options), supposedly to be able to cache the result of configure tests, but they were never, ever referenced anywhere in our code... Besides, we dropped the idea of getting a configure cache long ago now (it does not work)... They are causing spurious error messages on some distros (e.g. Fedora) which use GNU's which (whatever package that comes from), while it is silent on other distros (e.g. Ubuntu) which use debianutils' which. Drop them. Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/Makefile.in | 2 -- 1 file changed, 2 deletions(-)