| Message ID | 20180817155415.3357915-1-yhs@fb.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf] tools/bpf: fix bpf selftest test_cgroup_storage failure | expand |
On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote: > The bpf selftest test_cgroup_storage failed in one of > our production test servers. > # sudo ./test_cgroup_storage > Failed to create map: Operation not permitted > > It turns out this is due to insufficient locked memory > with system default 16KB. > > Similar to other self tests, let us arm the process > with unlimited locked memory. With this change, > the test passed. > # sudo ./test_cgroup_storage > test_cgroup_storage:PASS > > Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test") > Cc: Roman Gushchin <guro@fb.com> > Signed-off-by: Yonghong Song <yhs@fb.com> > --- > tools/testing/selftests/bpf/test_cgroup_storage.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/test_cgroup_storage.c b/tools/testing/selftests/bpf/test_cgroup_storage.c > index dc83fb2d3f27..4e196e3bfecf 100644 > --- a/tools/testing/selftests/bpf/test_cgroup_storage.c > +++ b/tools/testing/selftests/bpf/test_cgroup_storage.c > @@ -5,6 +5,7 @@ > #include <stdio.h> > #include <stdlib.h> > > +#include "bpf_rlimit.h" > #include "cgroup_helpers.h" > > char bpf_log_buf[BPF_LOG_BUF_SIZE]; > -- > 2.17.1 > Acked-by: Roman Gushchin <guro@fb.com> Thank you, Yonghong!
On Fri, Aug 17, 2018 at 08:54:15AM -0700, Yonghong Song wrote: > The bpf selftest test_cgroup_storage failed in one of > our production test servers. > # sudo ./test_cgroup_storage > Failed to create map: Operation not permitted > > It turns out this is due to insufficient locked memory > with system default 16KB. > > Similar to other self tests, let us arm the process > with unlimited locked memory. With this change, > the test passed. > # sudo ./test_cgroup_storage > test_cgroup_storage:PASS > > Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test") > Cc: Roman Gushchin <guro@fb.com> > Signed-off-by: Yonghong Song <yhs@fb.com> Applied, Thanks
diff --git a/tools/testing/selftests/bpf/test_cgroup_storage.c b/tools/testing/selftests/bpf/test_cgroup_storage.c index dc83fb2d3f27..4e196e3bfecf 100644 --- a/tools/testing/selftests/bpf/test_cgroup_storage.c +++ b/tools/testing/selftests/bpf/test_cgroup_storage.c @@ -5,6 +5,7 @@ #include <stdio.h> #include <stdlib.h> +#include "bpf_rlimit.h" #include "cgroup_helpers.h" char bpf_log_buf[BPF_LOG_BUF_SIZE];
The bpf selftest test_cgroup_storage failed in one of our production test servers. # sudo ./test_cgroup_storage Failed to create map: Operation not permitted It turns out this is due to insufficient locked memory with system default 16KB. Similar to other self tests, let us arm the process with unlimited locked memory. With this change, the test passed. # sudo ./test_cgroup_storage test_cgroup_storage:PASS Fixes: 68cfa3ac6b8d ("selftests/bpf: add a cgroup storage test") Cc: Roman Gushchin <guro@fb.com> Signed-off-by: Yonghong Song <yhs@fb.com> --- tools/testing/selftests/bpf/test_cgroup_storage.c | 1 + 1 file changed, 1 insertion(+)