| Message ID | 20180816084521.16289-5-alexandre.belloni@bootlin.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for MSCC Ocelot i2c | expand |
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Thu, 16 Aug 2018 10:45:18 +0200, Alexandre Belloni wrote: > Document bindings for the Microsemi Ocelot integration of the Designware > I2C controller. > > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> The preferred subject prefix is "dt-bindings: <binding dir>: ...". > --- > Documentation/devicetree/bindings/i2c/i2c-designware.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >
On Thu, Aug 16, 2018 at 10:45:18AM +0200, Alexandre Belloni wrote: > Document bindings for the Microsemi Ocelot integration of the Designware > I2C controller. > > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > Documentation/devicetree/bindings/i2c/i2c-designware.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) No need to re-spin just for the subject. Reviewed-by: Rob Herring <robh@kernel.org>
On 20/08/2018 13:13:41-0500, Rob Herring wrote: > On Thu, Aug 16, 2018 at 10:45:18AM +0200, Alexandre Belloni wrote: > > Document bindings for the Microsemi Ocelot integration of the Designware > > I2C controller. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > > --- > > Documentation/devicetree/bindings/i2c/i2c-designware.txt | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > No need to re-spin just for the subject. > Great, thanks a lot! > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt index fbb0a6d8b964..3e4bcc2fb6f7 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt @@ -3,6 +3,7 @@ Required properties : - compatible : should be "snps,designware-i2c" + or "mscc,ocelot-i2c" with "snps,designware-i2c" for fallback - reg : Offset and length of the register set for the device - interrupts : <IRQ> where IRQ is the interrupt number. @@ -11,8 +12,12 @@ Recommended properties : - clock-frequency : desired I2C bus clock frequency in Hz. Optional properties : + - reg : for "mscc,ocelot-i2c", a second register set to configure the SDA hold + time, named ICPU_CFG:TWI_DELAY in the datasheet. + - i2c-sda-hold-time-ns : should contain the SDA hold time in nanoseconds. - This option is only supported in hardware blocks version 1.11a or newer. + This option is only supported in hardware blocks version 1.11a or newer and + on Microsemi SoCs ("mscc,ocelot-i2c" compatible). - i2c-scl-falling-time-ns : should contain the SCL falling time in nanoseconds. This value which is by default 300ns is used to compute the tLOW period.
Document bindings for the Microsemi Ocelot integration of the Designware I2C controller. Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> --- Documentation/devicetree/bindings/i2c/i2c-designware.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)