Message ID | alpine.DEB.2.20.1808151651550.29904@digraph.polyomino.org.uk |
---|---|
State | New |
Headers | show |
Series | Add NT_VMCOREDD, AT_MINSIGSTKSZ from Linux 4.18 to elf.h | expand |
Ping. This patch <https://sourceware.org/ml/libc-alpha/2018-08/msg00315.html> is pending review.
On 08/15/2018 06:52 PM, Joseph Myers wrote: > 2018-08-15 Joseph Myers<joseph@codesourcery.com> > > * elf/elf.c (NT_VMCOREDD): New macro. > (AT_MINSIGSTKSZ): Likewise. I verified that the constants match the kernel settings. Looks good to me. As an aside: AT_MINSIGSTKSZ should really be arch-independent because x86 needs it as well (the signal stack usage varies wildly there as well). Thanks, Florian
On 15/08/2018 13:52, Joseph Myers wrote: > This patch adds two new constants from Linux 4.18 to elf.h, > NT_VMCOREDD and AT_MINSIGSTKSZ. > > Tested for x86_64. > > 2018-08-15 Joseph Myers <joseph@codesourcery.com> > > * elf/elf.c (NT_VMCOREDD): New macro. > (AT_MINSIGSTKSZ): Likewise. LGTM thanks. > > diff --git a/elf/elf.h b/elf/elf.h > index 7e2b072..226e538 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -808,6 +808,7 @@ typedef struct > #define NT_ARM_SYSTEM_CALL 0x404 /* ARM system call number */ > #define NT_ARM_SVE 0x405 /* ARM Scalable Vector Extension > registers */ > +#define NT_VMCOREDD 0x700 /* Vmcore Device Dump Note. */ > > /* Legal values for the note segment descriptor types for object files. */ > > @@ -1214,6 +1215,9 @@ typedef struct > #define AT_L3_CACHESIZE 46 > #define AT_L3_CACHEGEOMETRY 47 > > +#define AT_MINSIGSTKSZ 51 /* Stack needed for signal delivery > + (AArch64). */ > + > /* Note section contents. Each entry in the note section begins with > a header of a fixed form. */ > >
diff --git a/elf/elf.h b/elf/elf.h index 7e2b072..226e538 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -808,6 +808,7 @@ typedef struct #define NT_ARM_SYSTEM_CALL 0x404 /* ARM system call number */ #define NT_ARM_SVE 0x405 /* ARM Scalable Vector Extension registers */ +#define NT_VMCOREDD 0x700 /* Vmcore Device Dump Note. */ /* Legal values for the note segment descriptor types for object files. */ @@ -1214,6 +1215,9 @@ typedef struct #define AT_L3_CACHESIZE 46 #define AT_L3_CACHEGEOMETRY 47 +#define AT_MINSIGSTKSZ 51 /* Stack needed for signal delivery + (AArch64). */ + /* Note section contents. Each entry in the note section begins with a header of a fixed form. */