| Message ID | 1534182499-75914-2-git-send-email-hzhou8@ebay.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ovn-controller incremental processing | expand |
On Mon, Aug 13, 2018 at 10:48:00AM -0700, Han Zhou wrote: > The comment was added when the feature was introduced but what it > described is not what is implemented, probably because of revisions > after code reviews. > > Signed-off-by: Han Zhou <hzhou8@ebay.com> Thanks, applied to master.
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 40c29cb..b0ebe8c 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -2834,9 +2834,7 @@ ovsdb_idl_row_clear_arcs(struct ovsdb_idl_row *row, bool destroy_dsts) struct ovsdb_idl_arc *arc, *next; /* Delete all forward arcs. If 'destroy_dsts', destroy any orphaned rows - * that this causes to be unreferenced, if tracking is not enabled. - * If tracking is enabled, orphaned nodes are removed from hmap but not - * freed. + * that this causes to be unreferenced. */ LIST_FOR_EACH_SAFE (arc, next, src_node, &row->src_arcs) { ovs_list_remove(&arc->dst_node);
The comment was added when the feature was introduced but what it described is not what is implemented, probably because of revisions after code reviews. Signed-off-by: Han Zhou <hzhou8@ebay.com> --- lib/ovsdb-idl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)