[ovs-dev,1/3] tests: Use the default key length when generating RSA keys

Message ID 4cac95aff9f6780434150eb9177e546b72ddb48d.1533833706.git.tredaelli@redhat.com
State Accepted
Headers show
Series
  • Use the default key length for RSA keys
Related show

Commit Message

Timothy Redaelli Aug. 9, 2018, 6:02 p.m.
This commit removes the explicit set of 1024-bit RSA keys when ovs-pki
is launched and so the default (2048-bit) is used.

Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 tests/ovs-vsctl.at  | 4 ++--
 tests/ovsdb-rbac.at | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

Patch

diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index f9e7f3bb1..6f37c0da7 100644
--- a/tests/ovs-vsctl.at
+++ b/tests/ovs-vsctl.at
@@ -1374,7 +1374,7 @@  AT_KEYWORDS([ovs-vsctl ssl])
 AT_SKIP_IF([test "$HAVE_OPENSSL" = no])
 PKIDIR=`pwd`
 OVS_PKI="sh $abs_top_srcdir/utilities/ovs-pki.in --dir=$PKIDIR/pki --log=$PKIDIR/ovs-pki.log"
-AT_CHECK([$OVS_PKI -B 1024 init && $OVS_PKI -B 1024 req+sign vsctl switch && $OVS_PKI -B 1024 req ovsdbserver && $OVS_PKI self-sign ovsdbserver], [0], [ignore], [ignore])
+AT_CHECK([$OVS_PKI init && $OVS_PKI req+sign vsctl switch && $OVS_PKI req ovsdbserver && $OVS_PKI self-sign ovsdbserver], [0], [ignore], [ignore])
 
 dnl Create database.
 OVSDB_INIT([conf.db])
@@ -1401,7 +1401,7 @@  AT_KEYWORDS([ovs-vsctl ssl])
 AT_SKIP_IF([test "$HAVE_OPENSSL" = no])
 PKIDIR=`pwd`
 OVS_PKI="sh $abs_top_srcdir/utilities/ovs-pki.in --dir=$PKIDIR/pki --log=$PKIDIR/ovs-pki.log"
-AT_CHECK([$OVS_PKI -B 1024 init && $OVS_PKI -B 1024 req+sign vsctl switch && $OVS_PKI -B 1024 req+sign ovsdbserver controller], [0], [ignore], [ignore])
+AT_CHECK([$OVS_PKI init && $OVS_PKI req+sign vsctl switch && $OVS_PKI req+sign ovsdbserver controller], [0], [ignore], [ignore])
 
 dnl Create database.
 OVSDB_INIT([conf.db])
diff --git a/tests/ovsdb-rbac.at b/tests/ovsdb-rbac.at
index adefee4df..7de3711fb 100644
--- a/tests/ovsdb-rbac.at
+++ b/tests/ovsdb-rbac.at
@@ -6,10 +6,10 @@  AT_SKIP_IF([test "$HAVE_OPENSSL" = no])
 
 RBAC_PKIDIR="$(pwd)"
 RBAC_PKI="sh $abs_top_srcdir/utilities/ovs-pki.in --dir=$RBAC_PKIDIR/pki --log=$RBAC_PKIDIR/rbac-pki.log"
-$RBAC_PKI -B 1024 init
-$RBAC_PKI -B 1024 req+sign ovsdb-server switch
-$RBAC_PKI -B 1024 -u req+sign client-1 switch
-$RBAC_PKI -B 1024 -u req+sign client-2 switch
+$RBAC_PKI init
+$RBAC_PKI req+sign ovsdb-server switch
+$RBAC_PKI -u req+sign client-1 switch
+$RBAC_PKI -u req+sign client-2 switch
 
 AT_DATA([schema],
   [[{"name": "mydb",