[ovs-dev] vswitch.xml: Update dpdk-init documentation.

Message ID 1533827638-12184-1-git-send-email-ktraynor@redhat.com
State Accepted
Delegated to: Ian Stokes
Headers show
Series
  • [ovs-dev] vswitch.xml: Update dpdk-init documentation.
Related show

Commit Message

Kevin Traynor Aug. 9, 2018, 3:13 p.m.
dpdk-init is now a string. Add description of 'true' and 'try'.

Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database")
Cc: aconole@redhat.com
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 vswitchd/vswitch.xml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Comments

Aaron Conole Aug. 9, 2018, 3:25 p.m. | #1
Kevin Traynor <ktraynor@redhat.com> writes:

> dpdk-init is now a string. Add description of 'true' and 'try'.
>
> Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database")
> Cc: aconole@redhat.com
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

D'oh!  Thanks, Kevin.
Stokes, Ian Aug. 10, 2018, 10:15 a.m. | #2
> dpdk-init is now a string. Add description of 'true' and 'try'.
> 
> Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database")
> Cc: aconole@redhat.com
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

Thanks Kevin,

Will add this to today's pull request and backport to 2.10 also.

Ian

Patch

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 6342949..0cd8520 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -219,9 +219,15 @@ 
 
       <column name="other_config" key="dpdk-init"
-              type='{"type": "boolean"}'>
+              type='{"type": "string"}'>
         <p>
-          Set this value to <code>true</code> to enable runtime support for
-          DPDK ports. The vswitch must have compile-time support for DPDK as
-          well.
+          Set this value to <code>true</code> or <code>try</code> to enable
+          runtime support for DPDK ports. The vswitch must have compile-time
+          support for DPDK as well.
+        </p>
+        <p>
+          A value of <code>true</code> will cause the ovs-vswitchd process to
+          abort if DPDK cannot be initialized. A value of <code>try</code>
+          will allow the ovs-vswitchd process to continue running even if DPDK
+          cannot be initialized.
         </p>
         <p>