[ovs-dev,3/8] system-traffic.at: Skip gre-related failed tests on kernel version from 4.4 to 4.15

Message ID 1533753171-11730-3-git-send-email-pkusunyifeng@gmail.com
State Superseded
Headers show
Series
  • [ovs-dev,1/8] ip6_gre: Fix a bug that clears address bits
Related show

Commit Message

Yifeng Sun Aug. 8, 2018, 6:32 p.m.
Skip gre, erspan and ip6erspan related tests on kernel version from
4.4.x to 4.15.x because these tests will always fail.

Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>
---
 tests/system-traffic.at | 5 +++++
 1 file changed, 5 insertions(+)

Comments

William Tu Aug. 9, 2018, 6:59 p.m. | #1
On Wed, Aug 8, 2018 at 11:32 AM, Yifeng Sun <pkusunyifeng@gmail.com> wrote:

> Skip gre, erspan and ip6erspan related tests on kernel version from
> 4.4.x to 4.15.x because these tests will always fail.
>
> Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>
> ---
>  tests/system-traffic.at | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
> index cbd9542..cf53c10 100644
> --- a/tests/system-traffic.at
> +++ b/tests/system-traffic.at
> @@ -300,6 +300,7 @@ OVS_TRAFFIC_VSWITCHD_STOP
>  AT_CLEANUP
>
>  AT_SETUP([datapath - ping over gre tunnel])
> +OVS_CHECK_KERNEL_EXCL(4, 4, 15)
>

How about RHEL7x? Which uses 3.10.xxx?

William
Yifeng Sun Aug. 9, 2018, 7:47 p.m. | #2
Good question. I tried on RHEL7x but somehow these tests failed.
For now, I have run these tests on 4.4, 4.15, 4.16 and they all passed.

On Thu, Aug 9, 2018 at 11:59 AM, William Tu <u9012063@gmail.com> wrote:

>
>
> On Wed, Aug 8, 2018 at 11:32 AM, Yifeng Sun <pkusunyifeng@gmail.com>
> wrote:
>
>> Skip gre, erspan and ip6erspan related tests on kernel version from
>> 4.4.x to 4.15.x because these tests will always fail.
>>
>> Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>
>> ---
>>  tests/system-traffic.at | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/tests/system-traffic.at b/tests/system-traffic.at
>> index cbd9542..cf53c10 100644
>> --- a/tests/system-traffic.at
>> +++ b/tests/system-traffic.at
>> @@ -300,6 +300,7 @@ OVS_TRAFFIC_VSWITCHD_STOP
>>  AT_CLEANUP
>>
>>  AT_SETUP([datapath - ping over gre tunnel])
>> +OVS_CHECK_KERNEL_EXCL(4, 4, 15)
>>
>
> How about RHEL7x? Which uses 3.10.xxx?
>
> William
>

Patch

diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index cbd9542..cf53c10 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -300,6 +300,7 @@  OVS_TRAFFIC_VSWITCHD_STOP
 AT_CLEANUP
 
 AT_SETUP([datapath - ping over gre tunnel])
+OVS_CHECK_KERNEL_EXCL(4, 4, 15)
 OVS_CHECK_GRE()
 
 OVS_TRAFFIC_VSWITCHD_START()
@@ -340,6 +341,7 @@  OVS_TRAFFIC_VSWITCHD_STOP
 AT_CLEANUP
 
 AT_SETUP([datapath - ping over erspan v1 tunnel])
+OVS_CHECK_KERNEL_EXCL(4, 4, 15)
 OVS_CHECK_GRE()
 OVS_CHECK_ERSPAN()
 
@@ -375,6 +377,7 @@  OVS_TRAFFIC_VSWITCHD_STOP
 AT_CLEANUP
 
 AT_SETUP([datapath - ping over erspan v2 tunnel])
+OVS_CHECK_KERNEL_EXCL(4, 4, 15)
 OVS_CHECK_GRE()
 OVS_CHECK_ERSPAN()
 
@@ -410,6 +413,7 @@  OVS_TRAFFIC_VSWITCHD_STOP
 AT_CLEANUP
 
 AT_SETUP([datapath - ping over ip6erspan v1 tunnel])
+OVS_CHECK_KERNEL_EXCL(4, 4, 15)
 OVS_CHECK_GRE()
 OVS_CHECK_ERSPAN()
 
@@ -448,6 +452,7 @@  OVS_TRAFFIC_VSWITCHD_STOP
 AT_CLEANUP
 
 AT_SETUP([datapath - ping over ip6erspan v2 tunnel])
+OVS_CHECK_KERNEL_EXCL(4, 4, 15)
 OVS_CHECK_GRE()
 OVS_CHECK_ERSPAN()