From patchwork Wed Aug 8 18:32:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Sun X-Patchwork-Id: 955283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KyROKtN+"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41m74x0nL1z9s3Z for ; Thu, 9 Aug 2018 09:34:08 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1795AD96; Wed, 8 Aug 2018 23:34:06 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D0A47D02 for ; Wed, 8 Aug 2018 23:34:04 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9CB607A3 for ; Wed, 8 Aug 2018 23:34:04 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id h12-v6so1816991pgs.3 for ; Wed, 08 Aug 2018 16:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=055mKkEhylexqE4xjDpC8GXux3yVIHUcpAZKW3V5Yko=; b=KyROKtN+EpjHn10hd0nmg5oR6Cpzxcx5uV4SSPsNA1U3NP34qIH8RRiHZen6efqs4L 98Qri3ccDgkvOGqL4x030sFm5IvGUItlOAzhlLuGC/GkQ6Z447NsFUN3ivGuDWrH5Pwe B4PEe7e0qA4/o1qqmv+kZrFEhxYZyGVIi5Y5+AZ3Z123doMXfaABd3Jy+lrjWrsNtVxd tdhgbnvpJ6ILWb940eYHXN95bSXk5X2zoMWKsWNJWJiXVvcfNL4QlPx+HQhzCMLeDCyt FKhX9hQZBfM0ssNuiyhGuERjw5C49mzxoVGpqmDLpxTL/w9V3y7z5sJ98VWhdMQD8lOb M9lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=055mKkEhylexqE4xjDpC8GXux3yVIHUcpAZKW3V5Yko=; b=RGIbVBX4iXbL3/mYzxNPSQjKu6vfCeePlHATPunyPr5meNniqi8GuU9coWUTlslyj4 LZtk5EeSDgkHixgnrrwRPKXIHFfaGD+F1bltBw7RqWLzq3zpnEceplWo+aL2UoWHMqS7 fXgSudcfZdGeIQedBUb2WMIY0A6EHNyiEfxB3CNeKgCvwunxcib7mOfaqtwUsCjfLRNA 2W9Vyqe7xmBNah4tJ59Ddnm6A33tWasNCeNGddXVLGuBjRKPC1KZDcAH2PTKpRTMHlp/ OmhQe30dmtO0U2X1Ck1i3s4nj55TQE+mcDqy+JmFxehRPsRpR2eDVFHpISUnKbRMttuA xtJw== X-Gm-Message-State: AOUpUlEkbRDQYYNCDPKqA1CS2OMPwYprR6Sxi04K854KiBvNaxd7rByx Il1fvY1fa9BgQMUTZqOtSCPANJtE X-Google-Smtp-Source: AA+uWPzudllmNM0QE1dpUtxWagDztRlvBSeW1mJ9ltyvxUMoVkwnSJlYH6z/1sA0Vg3liyIZwNLGUA== X-Received: by 2002:a62:8d84:: with SMTP id p4-v6mr5035873pfk.251.1533771244084; Wed, 08 Aug 2018 16:34:04 -0700 (PDT) Received: from yfsovs.eng.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id u42-v6sm7045616pgn.1.2018.08.08.16.34.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Aug 2018 16:34:03 -0700 (PDT) From: Yifeng Sun To: dev@openvswitch.org Date: Wed, 8 Aug 2018 11:32:44 -0700 Message-Id: <1533753171-11730-1-git-send-email-pkusunyifeng@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00, DATE_IN_PAST_03_06, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org In compatable gre module, skb->cb is used as ovs_gso_cb. This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. Signed-off-by: Yifeng Sun --- datapath/linux/compat/ip6_gre.c | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath/linux/compat/ip6_gre.c b/datapath/linux/compat/ip6_gre.c index 54a76ab..16c1f72 100644 --- a/datapath/linux/compat/ip6_gre.c +++ b/datapath/linux/compat/ip6_gre.c @@ -1146,7 +1146,6 @@ static netdev_tx_t ip6erspan_tunnel_xmit(struct sk_buff *skb, goto tx_err; t->parms.o_flags &= ~TUNNEL_KEY; - IPCB(skb)->flags = 0; tun_info = ovs_skb_tunnel_info(skb); if (unlikely(!tun_info ||