From patchwork Thu Jul 19 18:34:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alin-Gabriel Serdean X-Patchwork-Id: 946556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41WjNB1YJrz9s3Z for ; Fri, 20 Jul 2018 04:34:17 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3F9E81027; Thu, 19 Jul 2018 18:34:16 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C0EF6E5A for ; Thu, 19 Jul 2018 18:34:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 451A279F for ; Thu, 19 Jul 2018 18:34:13 +0000 (UTC) X-Originating-IP: 82.79.245.216 Received: from localhost.localdomain (unknown [82.79.245.216]) (Authenticated sender: aserdean@ovn.org) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3ACB320007; Thu, 19 Jul 2018 18:34:11 +0000 (UTC) From: Alin Gabriel Serdean To: dev@openvswitch.org, pkusunyifeng@gmail.com Date: Thu, 19 Jul 2018 21:34:03 +0300 Message-Id: <20180719183403.1084-1-aserdean@ovn.org> X-Mailer: git-send-email 2.16.1.windows.1 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Alin Gabriel Serdean Subject: [ovs-dev] [PATCH v2 2/2] Datapath: Remove ovs_vport_init unreachable code X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The line "ovs_stt_cleanup_module();" was unreachable. Found using static analysis tools. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Yifeng Sun Signed-off-by: Yifeng Sun --- v2: Remove unreachable code only. --- datapath/vport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath/vport.c b/datapath/vport.c index 28ddb865c..55f40255b 100644 --- a/datapath/vport.c +++ b/datapath/vport.c @@ -97,7 +97,6 @@ int ovs_vport_init(void) goto err_stt; return 0; - ovs_stt_cleanup_module(); err_stt: vxlan_cleanup_module(); err_vxlan: