[ovs-dev,v2,2/2] Datapath: Remove ovs_vport_init unreachable code

Message ID 20180719183403.1084-1-aserdean@ovn.org
State New
Headers show
Series
  • [ovs-dev,v2,1/2] Datapath: Cleanup compat ip6_tunnel.c
Related show

Commit Message

Alin Gabriel Serdean July 19, 2018, 6:34 p.m.
The line "ovs_stt_cleanup_module();" was unreachable.
Found using static analysis tools.

Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
Co-authored-by: Yifeng Sun <pkusunyifeng@gmail.com>
---
v2: Remove unreachable code only.
---
 datapath/vport.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Yifeng Sun July 19, 2018, 6:39 p.m. | #1
Thanks for the work.

Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com>

On Thu, Jul 19, 2018 at 11:34 AM, Alin Gabriel Serdean <aserdean@ovn.org>
wrote:

> The line "ovs_stt_cleanup_module();" was unreachable.
> Found using static analysis tools.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
> Co-authored-by: Yifeng Sun <pkusunyifeng@gmail.com>
> ---
> v2: Remove unreachable code only.
> ---
>  datapath/vport.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/datapath/vport.c b/datapath/vport.c
> index 28ddb865c..55f40255b 100644
> --- a/datapath/vport.c
> +++ b/datapath/vport.c
> @@ -97,7 +97,6 @@ int ovs_vport_init(void)
>                 goto err_stt;
>
>         return 0;
> -       ovs_stt_cleanup_module();
>  err_stt:
>         vxlan_cleanup_module();
>  err_vxlan:
> --
> 2.16.1.windows.1
>
>

Patch

diff --git a/datapath/vport.c b/datapath/vport.c
index 28ddb865c..55f40255b 100644
--- a/datapath/vport.c
+++ b/datapath/vport.c
@@ -97,7 +97,6 @@  int ovs_vport_init(void)
 		goto err_stt;
 
 	return 0;
-	ovs_stt_cleanup_module();
 err_stt:
 	vxlan_cleanup_module();
 err_vxlan: