| Message ID | 71195eb3-e11c-f586-d359-7026bdfd9a8a@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/hotplug: Update affinity for migrated CPUs | expand |
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc1 next-20180620]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Michael-Bringmann/powerpc-hotplug-Update-affinity-for-migrated-CPUs/20180621-085543
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
arch/powerpc/platforms/pseries/dlpar.c: In function 'dlpar_pmt':
>> arch/powerpc/platforms/pseries/dlpar.c:453:2: error: implicit declaration of function 'rebuild_sched_domains' [-Werror=implicit-function-declaration]
rebuild_sched_domains();
^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/rebuild_sched_domains +453 arch/powerpc/platforms/pseries/dlpar.c
435
436 static int dlpar_pmt(struct pseries_hp_errorlog *work)
437 {
438 struct list_head *pos, *q;
439
440 ssleep(15);
441
442 list_for_each_safe(pos, q, &dlpar_delayed_list) {
443 struct pseries_hp_errorlog *tmp;
444
445 tmp = list_entry(pos, struct pseries_hp_errorlog, list);
446 handle_dlpar_errorlog(tmp);
447
448 list_del(pos);
449 kfree(tmp);
450 }
451
452 ssleep(5);
> 453 rebuild_sched_domains();
454
455 return 0;
456 }
457
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
I posted the wrong copy of the file the first time. That is what broke here. I posted the correction almost immediately to the list. The correct one has Message ID <8c437fe5-632c-a7ed-1f11-66c4578a1d93@linux.vnet.ibm.com> Sorry for the inconvenience. Michael On 06/20/2018 09:13 PM, kbuild test robot wrote: > Hi Michael, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.18-rc1 next-20180620] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michael-Bringmann/powerpc-hotplug-Update-affinity-for-migrated-CPUs/20180621-085543 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: powerpc-defconfig (attached as .config) > compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=powerpc > > All errors (new ones prefixed by >>): > > arch/powerpc/platforms/pseries/dlpar.c: In function 'dlpar_pmt': >>> arch/powerpc/platforms/pseries/dlpar.c:453:2: error: implicit declaration of function 'rebuild_sched_domains' [-Werror=implicit-function-declaration] > rebuild_sched_domains(); > ^~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > vim +/rebuild_sched_domains +453 arch/powerpc/platforms/pseries/dlpar.c > > 435 > 436 static int dlpar_pmt(struct pseries_hp_errorlog *work) > 437 { > 438 struct list_head *pos, *q; > 439 > 440 ssleep(15); > 441 > 442 list_for_each_safe(pos, q, &dlpar_delayed_list) { > 443 struct pseries_hp_errorlog *tmp; > 444 > 445 tmp = list_entry(pos, struct pseries_hp_errorlog, list); > 446 handle_dlpar_errorlog(tmp); > 447 > 448 list_del(pos); > 449 kfree(tmp); > 450 } > 451 > 452 ssleep(5); > > 453 rebuild_sched_domains(); > 454 > 455 return 0; > 456 } > 457 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >
I posted the wrong copy of the file the first time. That is what broke here. I posted the correction almost immediately to the list. The correct one has Message ID <8c437fe5-632c-a7ed-1f11-66c4578a1d93@linux.vnet.ibm.com> Sorry for the inconvenience. Michael On 06/20/2018 09:13 PM, kbuild test robot wrote: > Hi Michael, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.18-rc1 next-20180620] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Michael-Bringmann/powerpc-hotplug-Update-affinity-for-migrated-CPUs/20180621-085543 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: powerpc-defconfig (attached as .config) > compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=powerpc > > All errors (new ones prefixed by >>): > > arch/powerpc/platforms/pseries/dlpar.c: In function 'dlpar_pmt': >>> arch/powerpc/platforms/pseries/dlpar.c:453:2: error: implicit declaration of function 'rebuild_sched_domains' [-Werror=implicit-function-declaration] > rebuild_sched_domains(); > ^~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > vim +/rebuild_sched_domains +453 arch/powerpc/platforms/pseries/dlpar.c > > 435 > 436 static int dlpar_pmt(struct pseries_hp_errorlog *work) > 437 { > 438 struct list_head *pos, *q; > 439 > 440 ssleep(15); > 441 > 442 list_for_each_safe(pos, q, &dlpar_delayed_list) { > 443 struct pseries_hp_errorlog *tmp; > 444 > 445 tmp = list_entry(pos, struct pseries_hp_errorlog, list); > 446 handle_dlpar_errorlog(tmp); > 447 > 448 list_del(pos); > 449 kfree(tmp); > 450 } > 451 > 452 ssleep(5); > > 453 rebuild_sched_domains(); > 454 > 455 return 0; > 456 } > 457 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation >
diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index 4b43fec..9c68032 100644 --- a/arch/powerpc/platforms/pseries/dlpar.c +++ b/arch/powerpc/platforms/pseries/dlpar.c @@ -449,6 +449,9 @@ static int dlpar_pmt(struct pseries_hp_errorlog *work) kfree(tmp); } + ssleep(5); + rebuild_sched_domains(); + return 0; }
hotplug/pmt: Call rebuild_sched_domains after applying changes to update CPU associativity i.e. 'readd' CPUs. This is to ensure that the deferred calls to arch_update_cpu_topology are now reflected in the system data structures. Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com> --- arch/powerpc/platforms/pseries/dlpar.c | 3 +++ 1 file changed, 3 insertions(+)