From patchwork Wed Jun 20 18:40:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 932352 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 419tvt6lm2z9s3Z for ; Thu, 21 Jun 2018 04:41:30 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id C1200F23; Wed, 20 Jun 2018 18:41:05 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3869BF04 for ; Wed, 20 Jun 2018 18:41:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id ADECC1A0 for ; Wed, 20 Jun 2018 18:41:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 921B34022905 for ; Wed, 20 Jun 2018 18:41:01 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-124-38.rdu2.redhat.com [10.10.124.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62BC821565E1 for ; Wed, 20 Jun 2018 18:41:01 +0000 (UTC) From: Aaron Conole To: dev@openvswitch.org Date: Wed, 20 Jun 2018 14:40:57 -0400 Message-Id: <20180620184058.15838-1-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 20 Jun 2018 18:41:01 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 20 Jun 2018 18:41:01 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:'' X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 1/2] checkpatch: add quiet option X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This allows scripts which only want to process error messages to silence the normal 'warm and fuzzy' status messages from checkpatch. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 0a38ac571..cd781b576 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -81,6 +81,7 @@ checking_file = False total_line = 0 colors = False spellcheck_comments = False +quiet = False def get_color_end(): @@ -719,6 +720,7 @@ Check options: -h|--help This help message -b|--skip-block-whitespace Skips the if/while/for whitespace tests -l|--skip-leading-whitespace Skips the leading whitespace test +-q|--quiet Only print error and warning information -s|--skip-signoff-lines Tolerate missing Signed-off-by line -S|--spellcheck-comments Check C comments for possible spelling mistakes -t|--skip-trailing-whitespace Skips the trailing whitespace test""" @@ -726,11 +728,12 @@ Check options: def ovs_checkpatch_print_result(result): - global __warnings, __errors, total_line + global quiet, __warnings, __errors, total_line + if result < 0: print("Lines checked: %d, Warnings: %d, Errors: %d\n" % (total_line, __warnings, __errors)) - else: + elif not quiet: print("Lines checked: %d, no obvious problems found\n" % (total_line)) @@ -768,14 +771,15 @@ if __name__ == '__main__': sys.argv[1:]) n_patches = int(numeric_options[-1][1:]) if numeric_options else 0 - optlist, args = getopt.getopt(args, 'bhlstfS', + optlist, args = getopt.getopt(args, 'bhlstfSq', ["check-file", "help", "skip-block-whitespace", "skip-leading-whitespace", "skip-signoff-lines", "skip-trailing-whitespace", - "spellcheck-comments"]) + "spellcheck-comments", + "quiet"]) except: print("Unknown option encountered. Please rerun with -h for help.") sys.exit(-1) @@ -800,6 +804,8 @@ if __name__ == '__main__': print(" Please install python enchant.") else: spellcheck_comments = True + elif o in ("-q", "--quiet"): + quiet = True else: print("Unknown option '%s'" % o) sys.exit(-1) @@ -820,7 +826,8 @@ if __name__ == '__main__': patch = f.read() f.close() - print('== Checking %s ("%s") ==' % (revision[0:12], name)) + if not quiet: + print('== Checking %s ("%s") ==' % (revision[0:12], name)) result = ovs_checkpatch_parse(patch, revision) ovs_checkpatch_print_result(result) if result: @@ -837,7 +844,8 @@ if __name__ == '__main__': status = 0 for filename in args: - print('== Checking "%s" ==' % filename) + if not quiet: + print('== Checking "%s" ==' % filename) result = ovs_checkpatch_file(filename) if result: status = -1