[ovs-dev,v2] rhel: remove ovs-sim man page from temporary directory
diff mbox series

Message ID e2337485fcdf3481fc3672ff7292397258917ef3.1528200499.git.lorenzo.bianconi@redhat.com
State Accepted
Headers show
Series
  • [ovs-dev,v2] rhel: remove ovs-sim man page from temporary directory
Related show

Commit Message

Lorenzo Bianconi June 5, 2018, 12:42 p.m. UTC
Fix following compilation error running 'make rpm-fedora'

error: Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/ovs-sim.1.gz

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/man/man1/ovs-sim.1.gz
make: *** [Makefile:7049: rpm-fedora] Error 1

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
Changes since v1:
- remove ovs-sim.1 from temp folder
---
 rhel/openvswitch-fedora.spec.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Roi Dayan June 5, 2018, 2:42 p.m. UTC | #1
On 05/06/2018 15:42, Lorenzo Bianconi wrote:
> Fix following compilation error running 'make rpm-fedora'
> 
> error: Installed (but unpackaged) file(s) found:
>     /usr/share/man/man1/ovs-sim.1.gz
> 
> RPM build errors:
>      Installed (but unpackaged) file(s) found:
>     /usr/share/man/man1/ovs-sim.1.gz
> make: *** [Makefile:7049: rpm-fedora] Error 1
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
> Changes since v1:
> - remove ovs-sim.1 from temp folder
> ---
>   rhel/openvswitch-fedora.spec.in | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index 64a87a793..2ef0b5754 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -320,6 +320,7 @@ install -p -D -m 0755 \
>   # remove unpackaged files
>   rm -f $RPM_BUILD_ROOT%{_bindir}/ovs-parse-backtrace \
>           $RPM_BUILD_ROOT%{_sbindir}/ovs-vlan-bug-workaround \
> +        $RPM_BUILD_ROOT%{_mandir}/man1/ovs-sim.1 \
>           $RPM_BUILD_ROOT%{_mandir}/man8/ovs-vlan-bug-workaround.8
>   
>   %check
> 


Acked-by: Roi Dayan <roid@mellanox.com>
Ben Pfaff June 5, 2018, 11:14 p.m. UTC | #2
On Tue, Jun 05, 2018 at 05:42:52PM +0300, Roi Dayan wrote:
> 
> 
> On 05/06/2018 15:42, Lorenzo Bianconi wrote:
> >Fix following compilation error running 'make rpm-fedora'
> >
> >error: Installed (but unpackaged) file(s) found:
> >    /usr/share/man/man1/ovs-sim.1.gz
> >
> >RPM build errors:
> >     Installed (but unpackaged) file(s) found:
> >    /usr/share/man/man1/ovs-sim.1.gz
> >make: *** [Makefile:7049: rpm-fedora] Error 1
> >
> >Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> >---
> >Changes since v1:
> >- remove ovs-sim.1 from temp folder
> >---
> >  rhel/openvswitch-fedora.spec.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> >index 64a87a793..2ef0b5754 100644
> >--- a/rhel/openvswitch-fedora.spec.in
> >+++ b/rhel/openvswitch-fedora.spec.in
> >@@ -320,6 +320,7 @@ install -p -D -m 0755 \
> >  # remove unpackaged files
> >  rm -f $RPM_BUILD_ROOT%{_bindir}/ovs-parse-backtrace \
> >          $RPM_BUILD_ROOT%{_sbindir}/ovs-vlan-bug-workaround \
> >+        $RPM_BUILD_ROOT%{_mandir}/man1/ovs-sim.1 \
> >          $RPM_BUILD_ROOT%{_mandir}/man8/ovs-vlan-bug-workaround.8
> >  %check
> >
> 
> 
> Acked-by: Roi Dayan <roid@mellanox.com>

Thanks, Lorenzo (and Roi).  I applied this to master.

Patch
diff mbox series

diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 64a87a793..2ef0b5754 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -320,6 +320,7 @@  install -p -D -m 0755 \
 # remove unpackaged files
 rm -f $RPM_BUILD_ROOT%{_bindir}/ovs-parse-backtrace \
         $RPM_BUILD_ROOT%{_sbindir}/ovs-vlan-bug-workaround \
+        $RPM_BUILD_ROOT%{_mandir}/man1/ovs-sim.1 \
         $RPM_BUILD_ROOT%{_mandir}/man8/ovs-vlan-bug-workaround.8
 
 %check