Message ID | 1527619875-32494-1-git-send-email-louis.peens@netronome.com |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] lib: fix typo in fragment handling error message | expand |
On Tue, May 29, 2018 at 08:51:15PM +0200, Louis Peens wrote: > The error message states that "not_first" is a valid selection > for the ip_frag field, but looking at the structure that is defined > this should say "not_later". > > Signed-off-by: Louis Peens <louis.peens@netronome.com> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Thanks Louis. Everyone else, are there any objections to me applying this change? > --- > lib/meta-flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index 8b8d174..db0abb3 100644 > --- a/lib/meta-flow.c > +++ b/lib/meta-flow.c > @@ -2821,7 +2821,7 @@ mf_from_frag_string(const char *s, uint8_t *valuep, uint8_t *maskp) > } > > return xasprintf("%s: unknown fragment type (valid types are \"no\", " > - "\"yes\", \"first\", \"later\", \"not_first\"", s); > + "\"yes\", \"first\", \"later\", \"not_later\"", s); > } > > static char * > -- > 2.7.4 >
On Wed, Jun 06, 2018 at 11:47:13AM +0200, Simon Horman wrote: > On Tue, May 29, 2018 at 08:51:15PM +0200, Louis Peens wrote: > > The error message states that "not_first" is a valid selection > > for the ip_frag field, but looking at the structure that is defined > > this should say "not_later". > > > > Signed-off-by: Louis Peens <louis.peens@netronome.com> > > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > Thanks Louis. > > Everyone else, > > are there any objections to me applying this change? Acked-by: Ben Pfaff <blp@ovn.org>
On Wed, Jun 06, 2018 at 07:41:08AM -0700, Ben Pfaff wrote: > On Wed, Jun 06, 2018 at 11:47:13AM +0200, Simon Horman wrote: > > On Tue, May 29, 2018 at 08:51:15PM +0200, Louis Peens wrote: > > > The error message states that "not_first" is a valid selection > > > for the ip_frag field, but looking at the structure that is defined > > > this should say "not_later". > > > > > > Signed-off-by: Louis Peens <louis.peens@netronome.com> > > > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> > > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > Thanks Louis. > > > > Everyone else, > > > > are there any objections to me applying this change? > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks, pushed to master and branch-2.[5-9]
diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 8b8d174..db0abb3 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -2821,7 +2821,7 @@ mf_from_frag_string(const char *s, uint8_t *valuep, uint8_t *maskp) } return xasprintf("%s: unknown fragment type (valid types are \"no\", " - "\"yes\", \"first\", \"later\", \"not_first\"", s); + "\"yes\", \"first\", \"later\", \"not_later\"", s); } static char *