| Message ID | 1526660962-21730-1-git-send-email-dlu998@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev,v1] tests: Make test result more predictable. | expand |
On Fri, May 18, 2018 at 09:29:22AM -0700, Darrell Ball wrote: > The test 'ofproto-dpif - in place modification (vlan)' fails often > due to miss handling. Hence, make it more predictable by specifying > that misses should just be dropped. > > Signed-off-by: Darrell Ball <dlu998@gmail.com> Thanks for working to make the tests more reliable. I don't think this part will be effective, because miss_send_len is a per-OpenFlow connection setting, not a global one: > +# Always drop misses > +AT_CHECK([ovs-ofctl -P standard monitor br0 --detach --no-chdir --pidfile]) > +ovs-appctl -t ovs-ofctl ofctl/send 0109000c0123456700000000 This part seems like a good idea: > +AT_CHECK([ovs-ofctl -O OpenFlow11 mod-table br0 all drop]) Thanks, Ben.
On Fri, May 18, 2018 at 9:39 AM, Ben Pfaff <blp@ovn.org> wrote: > On Fri, May 18, 2018 at 09:29:22AM -0700, Darrell Ball wrote: > > The test 'ofproto-dpif - in place modification (vlan)' fails often > > due to miss handling. Hence, make it more predictable by specifying > > that misses should just be dropped. > > > > Signed-off-by: Darrell Ball <dlu998@gmail.com> > > Thanks for working to make the tests more reliable. > > I don't think this part will be effective, because miss_send_len is a > per-OpenFlow connection setting, not a global one: > > +# Always drop misses > > +AT_CHECK([ovs-ofctl -P standard monitor br0 --detach --no-chdir > --pidfile]) > > +ovs-appctl -t ovs-ofctl ofctl/send 0109000c0123456700000000 > This part seems like a good idea: > > > +AT_CHECK([ovs-ofctl -O OpenFlow11 mod-table br0 all drop]) > Thanks I sent a V2 that seems to do the deed. https://patchwork.ozlabs.org/patch/916469/ > > Thanks, > > Ben. >
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 60f28e2..e54c83f 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -8974,7 +8974,10 @@ OVS_VSWITCHD_START( [add-port br0 p1 -- set Interface p1 type=dummy ofport_request=1]) AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg]) -AT_CHECK([ovs-ofctl del-flows br0]) +# Always drop misses +AT_CHECK([ovs-ofctl -P standard monitor br0 --detach --no-chdir --pidfile]) +ovs-appctl -t ovs-ofctl ofctl/send 0109000c0123456700000000 +AT_CHECK([ovs-ofctl -O OpenFlow11 mod-table br0 all drop]) AT_CHECK([ovs-ofctl add-flow br0 in_port=1,actions=output:local]) ovs-appctl vlog/set PATTERN:ANY:'%c|%p|%m'
The test 'ofproto-dpif - in place modification (vlan)' fails often due to miss handling. Hence, make it more predictable by specifying that misses should just be dropped. Signed-off-by: Darrell Ball <dlu998@gmail.com> --- tests/ofproto-dpif.at | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)