diff mbox series

[LEDE-DEV,1/4] staging: mt7621-gpio: remove redundant owner assignments of drivers

Message ID 20180517004228.30766-1-rosenp@gmail.com
State Rejected
Delegated to: John Crispin
Headers show
Series [LEDE-DEV,1/4] staging: mt7621-gpio: remove redundant owner assignments of drivers | expand

Commit Message

Rosen Penev May 17, 2018, 12:42 a.m. UTC
From: HariPrasath Elango <hariprasath.elango@gmail.com>

Remove the reduntant owner initialization from this platform driver as
the platform_driver_register() takes care of it.

Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 .../0028-GPIO-ralink-add-mt7621-gpio-controller.patch          | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

John Crispin May 17, 2018, 8:11 a.m. UTC | #1
On 17/05/18 02:42, Rosen Penev wrote:
> From: HariPrasath Elango <hariprasath.elango@gmail.com>
>
> Remove the reduntant owner initialization from this platform driver as
> the platform_driver_register() takes care of it.
>
> Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com>
> Reviewed-by: NeilBrown <neil@brown.name>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
I am not really sure if it makes sense to backport of this essentially 
no-op patches.
     John

>   .../0028-GPIO-ralink-add-mt7621-gpio-controller.patch          | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch b/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch
> index d657274efe..ea341dc33c 100644
> --- a/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch
> +++ b/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch
> @@ -48,7 +48,7 @@ Signed-off-by: John Crispin <blogic@openwrt.org>
>   +obj-$(CONFIG_GPIO_MT7621)	+= gpio-mt7621.o
>   --- /dev/null
>   +++ b/drivers/gpio/gpio-mt7621.c
> -@@ -0,0 +1,354 @@
> +@@ -0,0 +1,353 @@
>   +/*
>   + * This program is free software; you can redistribute it and/or modify it
>   + * under the terms of the GNU General Public License version 2 as published
> @@ -391,7 +391,6 @@ Signed-off-by: John Crispin <blogic@openwrt.org>
>   +	.probe = mediatek_gpio_probe,
>   +	.driver = {
>   +		.name = "mt7621_gpio",
> -+		.owner = THIS_MODULE,
>   +		.of_match_table = mediatek_gpio_match,
>   +	},
>   +};
diff mbox series

Patch

diff --git a/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch b/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch
index d657274efe..ea341dc33c 100644
--- a/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch
+++ b/target/linux/ramips/patches-4.14/0028-GPIO-ralink-add-mt7621-gpio-controller.patch
@@ -48,7 +48,7 @@  Signed-off-by: John Crispin <blogic@openwrt.org>
 +obj-$(CONFIG_GPIO_MT7621)	+= gpio-mt7621.o
 --- /dev/null
 +++ b/drivers/gpio/gpio-mt7621.c
-@@ -0,0 +1,354 @@
+@@ -0,0 +1,353 @@
 +/*
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms of the GNU General Public License version 2 as published
@@ -391,7 +391,6 @@  Signed-off-by: John Crispin <blogic@openwrt.org>
 +	.probe = mediatek_gpio_probe,
 +	.driver = {
 +		.name = "mt7621_gpio",
-+		.owner = THIS_MODULE,
 +		.of_match_table = mediatek_gpio_match,
 +	},
 +};