@@ -1150,9 +1150,14 @@ main(int argc, char *argv[])
}
if (old_engine_run_id == engine_run_id) {
- VLOG_DBG("engine did not run, force recompute next time: "
- "br_int %p, chassis %p", br_int, chassis);
- engine_set_force_recompute(true);
+ if (engine_need_run(&en_flow_output)) {
+ VLOG_DBG("engine did not run, force recompute next time: "
+ "br_int %p, chassis %p", br_int, chassis);
+ engine_set_force_recompute(true);
+ } else {
+ VLOG_DBG("engine did not run, and it was not needed either: "
+ "br_int %p, chassis %p", br_int, chassis);
+ }
} else {
engine_set_force_recompute(false);
}
@@ -123,3 +123,22 @@ engine_run(struct engine_node *node, uint64_t run_id)
}
+bool
+engine_need_run(struct engine_node *node)
+{
+ size_t i;
+
+ if (!node->n_inputs) {
+ node->run(node);
+ VLOG_DBG("input node: %s, changed: %d", node->name, node->changed);
+ return node->changed;
+ }
+
+ for (i = 0; i < node->n_inputs; i++) {
+ if (engine_need_run(node->inputs[i].node)) {
+ return true;
+ }
+ }
+
+ return false;
+}
@@ -131,6 +131,10 @@ engine_run(struct engine_node *node, uint64_t run_id);
void
engine_cleanup(struct engine_node *node);
+/* Check if engine needs to run, i.e. any change to be processed */
+bool
+engine_need_run(struct engine_node *node);
+
/* Get the input node with <name> for <node> */
static inline struct engine_node *
engine_get_input(const char *input_name, struct engine_node *node)
Signed-off-by: Han Zhou <hzhou8@ebay.com> --- ovn/controller/ovn-controller.c | 11 ++++++++--- ovn/lib/inc-proc-eng.c | 19 +++++++++++++++++++ ovn/lib/inc-proc-eng.h | 4 ++++ 3 files changed, 31 insertions(+), 3 deletions(-)