| Message ID | 1524817045-31252-3-git-send-email-ley.foon.tan@intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | drivers: Add reset ctrl to drivers | expand |
On 04/27/2018 10:17 AM, Ley Foon Tan wrote: > Add code to reset all reset signals as in serial DT node. A reset property is an optional feature, > so do not fail if a reset property is not present. > > If a reset property is discovered, then use it to deassert, thus bringing the > IP out of reset. > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> Reviewed-by: Marek Vasut <marex@denx.de> > --- > drivers/serial/ns16550.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c > index 53550bf..457b636 100644 > --- a/drivers/serial/ns16550.c > +++ b/drivers/serial/ns16550.c > @@ -9,6 +9,7 @@ > #include <dm.h> > #include <errno.h> > #include <ns16550.h> > +#include <reset.h> > #include <serial.h> > #include <watchdog.h> > #include <linux/types.h> > @@ -177,6 +178,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor) > #if defined(CONFIG_ARCH_OMAP2PLUS) > serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/ > #endif > + > serial_out(UART_MCRVAL, &com_port->mcr); > serial_out(ns16550_getfcr(com_port), &com_port->fcr); > if (baud_divisor != -1) > @@ -371,6 +373,16 @@ int ns16550_serial_probe(struct udevice *dev) > { > struct NS16550 *const com_port = dev_get_priv(dev); > > +#ifdef CONFIG_DM_RESET > + struct reset_ctl_bulk reset_bulk; > + int ret; > + > + ret = reset_get_bulk(dev, &reset_bulk); > + if (!ret) > + reset_deassert_bulk(&reset_bulk); > + > +#endif > + > com_port->plat = dev_get_platdata(dev); > NS16550_init(com_port, -1); > >
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 53550bf..457b636 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -9,6 +9,7 @@ #include <dm.h> #include <errno.h> #include <ns16550.h> +#include <reset.h> #include <serial.h> #include <watchdog.h> #include <linux/types.h> @@ -177,6 +178,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor) #if defined(CONFIG_ARCH_OMAP2PLUS) serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/ #endif + serial_out(UART_MCRVAL, &com_port->mcr); serial_out(ns16550_getfcr(com_port), &com_port->fcr); if (baud_divisor != -1) @@ -371,6 +373,16 @@ int ns16550_serial_probe(struct udevice *dev) { struct NS16550 *const com_port = dev_get_priv(dev); +#ifdef CONFIG_DM_RESET + struct reset_ctl_bulk reset_bulk; + int ret; + + ret = reset_get_bulk(dev, &reset_bulk); + if (!ret) + reset_deassert_bulk(&reset_bulk); + +#endif + com_port->plat = dev_get_platdata(dev); NS16550_init(com_port, -1);
Add code to reset all reset signals as in serial DT node. A reset property is an optional feature, so do not fail if a reset property is not present. If a reset property is discovered, then use it to deassert, thus bringing the IP out of reset. Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> --- drivers/serial/ns16550.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)