From patchwork Thu Apr 26 15:41:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Lefebvre X-Patchwork-Id: 905159 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=essensium.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XAGegmKY"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=essensium-com.20150623.gappssmtp.com header.i=@essensium-com.20150623.gappssmtp.com header.b="d+XISx8N"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40X1c30bmsz9s06 for ; Fri, 27 Apr 2018 01:45:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Y8E183SBeIK7ziqSZv+3ATvkUhWYeNsN3cq/xLj+qL4=; b=XAGegmKYeAj8E5l1aEV5uJHQ9t 3bH9PDaV8LeNxb3TJROnQ2toQb2qHLdbBOdW79VUDXvLDiSxnLwSdFd6zoRKG+aTPxBkkq2pINqsY phlRB2Dsx8eE9U+tp1LnE/S4kE2m5cReV7ZtNoN1jfWsBE2yxAuHIclleOFvO2BWv6dwSsm8fb7DI XOpEuv1ziDKVEWsDSULfJWRS5XuVVQi48kQm//B4nBmny0LnTSPZ/TwK3txn1IfQIPsukDDAYhCDg Rfi3k5cwSFh30G0BuXAFf4WOzVNfBSCV5S6J+5dI1rWtILddpheVVxj7DnXxz58DU/NdTjVIR6HNo GFSx87tA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBj54-0006z9-QS; Thu, 26 Apr 2018 15:45:10 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fBj29-0005hv-P0 for linux-mtd@lists.infradead.org; Thu, 26 Apr 2018 15:42:12 +0000 Received: by mail-wr0-x244.google.com with SMTP id v60-v6so57238613wrc.7 for ; Thu, 26 Apr 2018 08:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=essensium-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4fMVsqQD/StcKry+rIB3M7ybZqR9QTwX1lFg3tLK2ws=; b=d+XISx8N3h3z3ll8dTy0EYVTwTAccdHg5z6ZbUaUrfBiizUiDwJIURi0DFtLBrnxkQ uKs41f9HguPkfKZ8B/YInYLVe4oNqmJIe9HR6ToW4C3nl8nLRxxBWGSEmxWZgzQy5QuA T8sOWc0Fqc7IoVhKahknlV0+HVSE8UOka1/3U3I6f2u0X+qq5g0AakpwAQsKTdGFX0Zk Xwny4B6H5qOyDqAGxfvZc5iXej7sxKKf4alaHIrNKDhv4kUmLzxidSRbAPtqKngbQbsd bWGR9iOa2OGMcScOlwMpR91T0gKPGwzGzDZN1c+Exdjxl7BK3/jDpsn+DNxcM1+gyjyT 5rsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4fMVsqQD/StcKry+rIB3M7ybZqR9QTwX1lFg3tLK2ws=; b=tJMbN5eCgF4SY/S/dW3Ue5LJaRtG2sSneLvxEV+hk62Q89HVpvGEpED+qb6dFUC58h Gvx/EjNH/465hbaGtmalpmjEvxSXft9U824X2i12SBnyfFCtBfv3aaoyL6aIq1ecEToK xqIQp3XQEhmwW4++7SpIyMY+GbtTm0xPd3cB+A9vQdjqgS++dU6rXiPNED7gyQ+XBlHN coQ7MHFzz/FrY3azl9fVN71iEoNXGfrL94ILzk46RGAwCsMnz0IUX6IHvLld/J/1e8Ku lCf3al3xn/QwqmNaJ1PLMOOtqhDrbztIwAOowF+vLdhJ8UM28PlSrbvBgy5mm8+LdTPH TMww== X-Gm-Message-State: ALQs6tBTklkDzP8jaq3v7mUDshvGeVMt2U21cnxcUa9oTsbVXoPOKAxU hCcj6MUbF4l9rZC09khSv/berE6j X-Google-Smtp-Source: AIpwx4/ngEKNw8EByLSxy8KyRpcM+bRF5ZQQ8JNkn10Fr328irI6ySjYxSAIcdUZBI/ggSqZpEpD+Q== X-Received: by 2002:adf:cc8c:: with SMTP id p12-v6mr25267003wrj.280.1524757324429; Thu, 26 Apr 2018 08:42:04 -0700 (PDT) Received: from Darth.local.ess-mail.com (178-118-196-9.access.telenet.be. [178.118.196.9]) by smtp.gmail.com with ESMTPSA id n23-v6sm19916031wra.39.2018.04.26.08.42.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Apr 2018 08:42:03 -0700 (PDT) From: Sam Lefebvre To: linux-mtd@lists.infradead.org Subject: [PATCH 07/13] mtd: rawnand: gpmi: set aggregate ready/busy signalling Date: Thu, 26 Apr 2018 17:41:28 +0200 Message-Id: <20180426154134.8270-8-sam.lefebvre@essensium.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180426154134.8270-1-sam.lefebvre@essensium.com> References: <20180426154134.8270-1-sam.lefebvre@essensium.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180426_084209_872739_2ABE8F5C X-CRM114-Status: GOOD ( 14.74 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c0c:0:0:0:244 listed in] [list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnout Vandecapelle , Sam Lefebvre , Dries Staelens , Han Xu MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The GPMI block by default decouples the ready/busy signal (which is shared between all chip-selects) to separate internal signals per chip-select. However, since the gpmi-nand driver uses DMA0 for all chip-selects, DMA transfers will not be able to see the ready/busy status for any chip-select other than 0. Currently, this happens to work because nand_command() ends with an explicit nand_wait_ready() and the driver only sets up a single command in a DMA chain. nand_wait_ready() polls for the chip-select specific ready/busy status bit. Future patches, however, will set up a DMA chain with several commands, so these will have to wait correctly in the DMA chain itself. To fix this, set the GANGED_RDYBUSY bit in the control1 register. This ties all internal ready/busy signals together, so DMA0 will also see the ready/busy status of chip selects 1-2-3. It's a bit silly that this isn't implied in hardware by the DECOUPLE_CS bit. Signed-off-by: Sam Lefebvre Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Cc: Han Xu --- Tested on an i.MX6Q with two identical chips on CS0 and CS1. --- drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c | 3 +++ drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c index 83697b8df871..1858afdb400d 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c @@ -193,6 +193,9 @@ int gpmi_init(struct gpmi_nand_data *this) */ writel(BM_GPMI_CTRL1_DECOUPLE_CS, r->gpmi_regs + HW_GPMI_CTRL1_SET); + /* Aggregate ready busy signalling. */ + writel(BM_GPMI_CTRL1_GANGED_RDYBUSY, r->gpmi_regs + HW_GPMI_CTRL1_SET); + gpmi_disable_clk(this); return 0; err_out: diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h b/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h index d92bf32221ca..e341802c90ac 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-regs.h @@ -120,6 +120,7 @@ #define BV_GPMI_CTRL1_WRN_DLY_SEL_7_TO_12NS 0x2 #define BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY 0x3 +#define BM_GPMI_CTRL1_GANGED_RDYBUSY (1 << 19) #define BM_GPMI_CTRL1_BCH_MODE (1 << 18) #define BP_GPMI_CTRL1_DLL_ENABLE 17