From patchwork Mon Apr 9 17:20:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 896365 X-Patchwork-Delegate: ian.stokes@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QmLf/s1a"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40KcXd2l1Cz9s25 for ; Tue, 10 Apr 2018 03:21:21 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A0E02E42; Mon, 9 Apr 2018 17:21:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id AEC2CE3C for ; Mon, 9 Apr 2018 17:21:16 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-qt0-f195.google.com (mail-qt0-f195.google.com [209.85.216.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 313B3284 for ; Mon, 9 Apr 2018 17:21:16 +0000 (UTC) Received: by mail-qt0-f195.google.com with SMTP id g5so10040060qth.7 for ; Mon, 09 Apr 2018 10:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=9HfJjNu1+iTBtZVnWBOGfjHcoi/Xj8yo5f/Rg14w1i8=; b=QmLf/s1acu80OyKWMfQ6RYCSalfCghn/uhcqhyrsMbtq9HirgqCqg6Y+qAPxVd7O8K DjumIY3BBGNC+K5jt7nuvt/gxo2+zzc7WrCXPJmtRgQQAg4GDQ52csklqV9cgtupR62b 5n9BWMQbLqBmzXkjcUMBrXcA+iSgyFRg3efJ5tE+zKSv0HNUCyXv75Gr5nR37x8NIrYC cK83oV/Wb/fL3YOBblXNOR8XE3tm3+exEN5jMoKwgFFamdxv8sjLMdbEcOrquSX2p6Jd 4MHqkNnbzONs67lsHWTaezKGBYQSuWOjFWWZm8M5YfMCbUpWJLVZGj5vwJAAZ9c8TzrF vf+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9HfJjNu1+iTBtZVnWBOGfjHcoi/Xj8yo5f/Rg14w1i8=; b=tCWAD1y6Uz+sqcI20r/gz+c3/TrIvVeh6UBjbGB69hGR/pprrjTaabN5gf80pXCThb qiZMcuL2RSyb8G1D8mMHIFoEac5xleyBbTcSrv11n1RLXIRb6ECEkrh8nd1bWArkixfC 7HNfuWKhWNewUM4J1/JaDH9z7U5INOMhtK/PWYZWI+asQMksT+fbLkVMipogCM2cn+i3 EG3ayqROSTuo/triZz0sLdoEVdKZzwQwpx787Y8JfWzgh4EodGKa0E69MkGn7L5NHOsV QQ39n16d2Nee2eF5168pBu7MYCO95TuDHdshySqdMnbEIh5HmhFdLFb5bSs2PL11mLKX mClw== X-Gm-Message-State: ALQs6tAcTJwcTm8He+HLLhPb0uXE/AyhkTkXRrw8r+u5l8dxuD0PuQV1 fWLeQ+pX/LcXSSiRHuxFc7fQfA== X-Google-Smtp-Source: AIpwx497pnFfdJbHPE0oMxk3oQcPlZ2G8m/7WfDbXsBY6rnlqEKV/NTX2m9Hi2BbKVjYeKzPabf2Zw== X-Received: by 10.200.102.20 with SMTP id c20mr37437140qtp.152.1523294475052; Mon, 09 Apr 2018 10:21:15 -0700 (PDT) Received: from localhost.localdomain.com ([177.10.56.96]) by smtp.gmail.com with ESMTPSA id t56sm672012qtj.48.2018.04.09.10.21.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Apr 2018 10:21:14 -0700 (PDT) From: Marcelo Ricardo Leitner To: dev@openvswitch.org Date: Mon, 9 Apr 2018 14:20:50 -0300 Message-Id: <5c31d1c4059c75b2b534f8661f13eb16317d3edc.1523294251.git.marcelo.leitner@gmail.com> X-Mailer: git-send-email 2.14.3 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: marcelo.leitner@gmail.com, slavash@mellanox.com Subject: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org The MAC address is always 6-bytes long, never 7. The extra :01 and :02 doesn't belong in there as it doesn't mean selecting one port or another. Instead, use an incrementing MAC address, which is what usually happens on such cards. See-also: http://www.dpdk.org/ml/archives/dev/2018-April/094976.html Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing same PCI id") Signed-off-by: Marcelo Ricardo Leitner --- Documentation/howto/dpdk.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index 79b626c76d0dd45381bd75ab867b7815ca941208..69e692f40d500cf65d59d1979e07afa6f99cf903 100644 --- a/Documentation/howto/dpdk.rst +++ b/Documentation/howto/dpdk.rst @@ -53,9 +53,9 @@ with multiple ports. Using a PCI device like above won't work. Instead, below usage is suggested:: $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ - options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01" + options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55" $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ - options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02" + options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56" Note: such syntax won't support hotplug. The hotplug is supposed to work with future DPDK release, v18.05.