diff mbox series

[LEDE-DEV,07/12] at91: sdcard image with ext4 rootfs

Message ID 93f2ebda0e51626b4c1013620b1b106cb49178ad.1522686802.git.sandeepsheriker.mallikarjun@microchip.com
State Accepted
Delegated to: John Crispin
Headers show
Series [LEDE-DEV,01/12] at91bootstrap:update to v3.8.10 | expand

Commit Message

Sandeep Sheriker April 2, 2018, 4:34 p.m. UTC
creating sdcard image with ext4 rootfs only and ignoring creating
other filesystem in sdcard image.

Signed-off-by: Sandeep Sheriker Mallikarjun <sandeepsheriker.mallikarjun@microchip.com>
---
 target/linux/at91/image/Makefile | 2 +-
 target/linux/at91/image/sama5.mk | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Felix Fietkau April 30, 2018, 6:49 a.m. UTC | #1
On 2018-04-02 18:34, Sandeep Sheriker Mallikarjun wrote:
> creating sdcard image with ext4 rootfs only and ignoring creating
> other filesystem in sdcard image.
> 
> Signed-off-by: Sandeep Sheriker Mallikarjun <sandeepsheriker.mallikarjun@microchip.com>
Why do you need ext4 images? I think squashfs images (with f2fs/ext4
overlay created by fstools) are more useful, since they're smaller and
allow easy reset-to-defaults.

- Felix
diff mbox series

Patch

diff --git a/target/linux/at91/image/Makefile b/target/linux/at91/image/Makefile
index ccaeebe..93180dd 100644
--- a/target/linux/at91/image/Makefile
+++ b/target/linux/at91/image/Makefile
@@ -23,7 +23,7 @@  endif
 define Device/Default
   $(Device/default-nand)
   PROFILES := Default
-  FILESYSTEMS := squashfs ubifs
+  FILESYSTEMS := squashfs ubifs ext4
   DEVICE_DTS := $(1)
   KERNEL_NAME := zImage
   KERNEL_SIZE := 4096k
diff --git a/target/linux/at91/image/sama5.mk b/target/linux/at91/image/sama5.mk
index 5960f40..fd7a534 100644
--- a/target/linux/at91/image/sama5.mk
+++ b/target/linux/at91/image/sama5.mk
@@ -4,6 +4,7 @@  FAT32_BLOCKS:=$(shell echo \
   $$(($(AT91_SD_BOOT_PARTSIZE)*1024*1024/$(FAT32_BLOCK_SIZE))))
 
 define Build/at91-sdcard
+  $(if $(findstring ext4,$@), \
   rm -f $@.boot
   mkfs.fat -C $@.boot $(FAT32_BLOCKS)
 
@@ -30,7 +31,7 @@  define Build/at91-sdcard
 
   gzip -nc9 $@.img > $@
 
-  rm -f $@.img $@.boot
+  rm -f $@.img $@.boot )
 endef
 
 define Device/evaluation-sdimage