diff mbox series

[LEDE-DEV] mvebu: Switch Turris Omnia to use ath10k-ct driver and firmware.

Message ID 20180330221902.31977-1-rosenp@gmail.com
State Rejected
Delegated to: John Crispin
Headers show
Series [LEDE-DEV] mvebu: Switch Turris Omnia to use ath10k-ct driver and firmware. | expand

Commit Message

Rosen Penev March 30, 2018, 10:19 p.m. UTC
My testing has shown both ath10k and firmware to be unstable. Here is a summary of results done over two weeks:

ath10k + QCA firmware = driver crash, WiFi dies completely.
ath10k + CT firmware = driver crash. WiFi dies completely.
ath10k-ct + QCA firmware = firmware crash. WiFi does not die*.
ath10k-ct + CT firmware = I have not gotten either to crash.

WiFi does not die completely with scenario 3 as mac80211 is able to restart the hardware. From my testing, it dies twice a day. I have no idea what triggers it. My best guess is an Apple iPhone.

I also tried QCA firmware 37. No difference.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 target/linux/mvebu/image/cortex-a9.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Crispin April 30, 2018, 6:44 a.m. UTC | #1
On 31/03/18 00:19, Rosen Penev wrote:
> My testing has shown both ath10k and firmware to be unstable. Here is a summary of results done over two weeks:
>
> ath10k + QCA firmware = driver crash, WiFi dies completely.
> ath10k + CT firmware = driver crash. WiFi dies completely.
> ath10k-ct + QCA firmware = firmware crash. WiFi does not die*.
> ath10k-ct + CT firmware = I have not gotten either to crash.
>
> WiFi does not die completely with scenario 3 as mac80211 is able to restart the hardware. From my testing, it dies twice a day. I have no idea what triggers it. My best guess is an Apple iPhone.
>
> I also tried QCA firmware 37. No difference.

Hi,

there will always be combos of FW/drv version that will/not work. this 
can change over time back and fwd between stock and -ct code bases. -ct 
has been opt-in since it was merged. It would be uch better to figure 
out which FW works and why the driver dies. Otherwise we'll start 
flipping back and fwd between stock/-ct versions with each update on 
each wmac silicon / arch combo constantly.

     John

> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>   target/linux/mvebu/image/cortex-a9.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/linux/mvebu/image/cortex-a9.mk b/target/linux/mvebu/image/cortex-a9.mk
> index d9defe880d..a6529220ea 100644
> --- a/target/linux/mvebu/image/cortex-a9.mk
> +++ b/target/linux/mvebu/image/cortex-a9.mk
> @@ -152,7 +152,7 @@ define Device/turris-omnia
>     DEVICE_TITLE := Turris Omnia
>     DEVICE_PACKAGES :=  \
>       mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
> -    wpad-mini kmod-ath9k kmod-ath10k ath10k-firmware-qca988x
> +    wpad-mini kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct
>     IMAGES := $$(IMAGE_PREFIX)-sysupgrade.img.gz omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz
>     IMAGE/$$(IMAGE_PREFIX)-sysupgrade.img.gz := boot-img | sdcard-img | gzip | append-metadata
>     IMAGE/omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz := omnia-medkit-initramfs | gzip
Rosen Penev April 30, 2018, 9:50 a.m. UTC | #2
On Sun, Apr 29, 2018 at 11:44 PM, John Crispin <john@phrozen.org> wrote:
>
>
> On 31/03/18 00:19, Rosen Penev wrote:
>>
>> My testing has shown both ath10k and firmware to be unstable. Here is a
>> summary of results done over two weeks:
>>
>> ath10k + QCA firmware = driver crash, WiFi dies completely.
>> ath10k + CT firmware = driver crash. WiFi dies completely.
>> ath10k-ct + QCA firmware = firmware crash. WiFi does not die*.
>> ath10k-ct + CT firmware = I have not gotten either to crash.
>>
>> WiFi does not die completely with scenario 3 as mac80211 is able to
>> restart the hardware. From my testing, it dies twice a day. I have no idea
>> what triggers it. My best guess is an Apple iPhone.
>>
>> I also tried QCA firmware 37. No difference.
>
>
> Hi,
>
> there will always be combos of FW/drv version that will/not work. this can
> change over time back and fwd between stock and -ct code bases. -ct has been
> opt-in since it was merged. It would be uch better to figure out which FW
> works and why the driver dies. Otherwise we'll start flipping back and fwd
> between stock/-ct versions with each update on each wmac silicon / arch
> combo constantly.
So the initial report was premature. I've since tried with more
firmwares only to find that they all crash. Even -ct.

The basic problem is that in the case of the firmware crashing, -ct
restarts the firmware whereas ath10k dies with it.

I've concluded that it's my phone running Android Oreo that causes all
the firmware crashing.
>
>     John
>
>
>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>> ---
>>   target/linux/mvebu/image/cortex-a9.mk | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/linux/mvebu/image/cortex-a9.mk
>> b/target/linux/mvebu/image/cortex-a9.mk
>> index d9defe880d..a6529220ea 100644
>> --- a/target/linux/mvebu/image/cortex-a9.mk
>> +++ b/target/linux/mvebu/image/cortex-a9.mk
>> @@ -152,7 +152,7 @@ define Device/turris-omnia
>>     DEVICE_TITLE := Turris Omnia
>>     DEVICE_PACKAGES :=  \
>>       mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
>> -    wpad-mini kmod-ath9k kmod-ath10k ath10k-firmware-qca988x
>> +    wpad-mini kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct
>>     IMAGES := $$(IMAGE_PREFIX)-sysupgrade.img.gz
>> omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz
>>     IMAGE/$$(IMAGE_PREFIX)-sysupgrade.img.gz := boot-img | sdcard-img |
>> gzip | append-metadata
>>     IMAGE/omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz :=
>> omnia-medkit-initramfs | gzip
>
>
diff mbox series

Patch

diff --git a/target/linux/mvebu/image/cortex-a9.mk b/target/linux/mvebu/image/cortex-a9.mk
index d9defe880d..a6529220ea 100644
--- a/target/linux/mvebu/image/cortex-a9.mk
+++ b/target/linux/mvebu/image/cortex-a9.mk
@@ -152,7 +152,7 @@  define Device/turris-omnia
   DEVICE_TITLE := Turris Omnia
   DEVICE_PACKAGES :=  \
     mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
-    wpad-mini kmod-ath9k kmod-ath10k ath10k-firmware-qca988x
+    wpad-mini kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct
   IMAGES := $$(IMAGE_PREFIX)-sysupgrade.img.gz omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz
   IMAGE/$$(IMAGE_PREFIX)-sysupgrade.img.gz := boot-img | sdcard-img | gzip | append-metadata
   IMAGE/omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz := omnia-medkit-initramfs | gzip