| Message ID | 20180321081014.GC9826@mwanda |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: nand: fix return value in nand_erase_nand() | expand |
Hi Dan, On Wed, 21 Mar 2018 11:10:14 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote: > The problem is that "ret" isn't initialized on the success path. > > Fixes: cc4ac09da649 ("mtd: Stop updating erase_info->state and calling mtd_erase_callback()") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> I squashed those changes into the offending commit. As usual, thanks for this report (and fix). Boris > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index 13dd67106859..87b72bf626ae 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -4653,6 +4653,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr, > } > } > > + ret = 0; > erase_exit: > > /* Deselect and wake up anyone waiting on the device */
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 13dd67106859..87b72bf626ae 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -4653,6 +4653,7 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr, } } + ret = 0; erase_exit: /* Deselect and wake up anyone waiting on the device */
The problem is that "ret" isn't initialized on the success path. Fixes: cc4ac09da649 ("mtd: Stop updating erase_info->state and calling mtd_erase_callback()") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>