diff mbox series

[U-Boot,2/2] video: rk3399_mipi: Combine NULL check into IS_ERR_OR_NULL()

Message ID 20180319173608.10515-2-punit.agrawal@arm.com
State Accepted
Commit a89c725d2c6082e42be2ff59a48c967974ead77f
Delegated to: Philipp Tomsich
Headers show
Series [U-Boot,1/2] video: rk3288_mipi: Combine NULL check into IS_ERR_OR_NULL() | expand

Commit Message

Punit Agrawal March 19, 2018, 5:36 p.m. UTC 
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
 drivers/video/rockchip/rk3399_mipi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Tomsich March 28, 2018, 9:36 p.m. UTC | #1 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> ---
>  drivers/video/rockchip/rk3399_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich March 28, 2018, 9:36 p.m. UTC | #2 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> ---
>  drivers/video/rockchip/rk3399_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich March 28, 2018, 9:45 p.m. UTC | #3 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  drivers/video/rockchip/rk3399_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-rockchip, thanks!
diff mbox series

Patch

diff --git a/drivers/video/rockchip/rk3399_mipi.c b/drivers/video/rockchip/rk3399_mipi.c
index c6987ff042..b936fcec9b 100644
--- a/drivers/video/rockchip/rk3399_mipi.c
+++ b/drivers/video/rockchip/rk3399_mipi.c
@@ -128,7 +128,7 @@  static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
 	struct rk_mipi_priv *priv = dev_get_priv(dev);
 
 	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
-	if (!priv->grf || IS_ERR(priv->grf)) {
+	if (IS_ERR_OR_NULL(priv->grf)) {
 		debug("%s: Get syscon grf failed (ret=%p)\n",
 		      __func__, priv->grf);
 		return  -ENXIO;