| Message ID | 1521448449-25916-1-git-send-email-zhenwei.pi@youruncloud.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | ext4 : fix comments in ext4_swap_extents | expand |
On Mon 19-03-18 16:34:09, zhenwei.pi wrote: > "mark_unwritten" in comment and "unwritten" in variable > argument lists is mismatch. > > Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com> This seems to have fallen through cracks. The patch looks good to me. Ted, can you please merge it? Thanks! Honza > --- > fs/ext4/extents.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 054416e..2fc4227 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -5751,7 +5751,7 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len) > * @lblk1: Start block for first inode > * @lblk2: Start block for second inode > * @count: Number of blocks to swap > - * @mark_unwritten: Mark second inode's extents as unwritten after swap > + * @unwritten: Mark second inode's extents as unwritten after swap > * @erp: Pointer to save error value > * > * This helper routine does exactly what is promise "swap extents". All other > -- > 2.7.4 >
On Thu, Apr 19, 2018 at 04:50:28PM +0200, Jan Kara wrote: > On Mon 19-03-18 16:34:09, zhenwei.pi wrote: > > "mark_unwritten" in comment and "unwritten" in variable > > argument lists is mismatch. > > > > Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com> > > This seems to have fallen through cracks. The patch looks good to me. Ted, > can you please merge it? Thanks! It landed in 4.17-rc1, commit id: dcae058a8da9c Cheers, - Ted
On Thu 19-04-18 12:44:56, Theodore Y. Ts'o wrote: > On Thu, Apr 19, 2018 at 04:50:28PM +0200, Jan Kara wrote: > > On Mon 19-03-18 16:34:09, zhenwei.pi wrote: > > > "mark_unwritten" in comment and "unwritten" in variable > > > argument lists is mismatch. > > > > > > Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com> > > > > This seems to have fallen through cracks. The patch looks good to me. Ted, > > can you please merge it? Thanks! > > It landed in 4.17-rc1, commit id: dcae058a8da9c Ah, somehow I missed that. Sorry. Honza
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 054416e..2fc4227 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -5751,7 +5751,7 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len) * @lblk1: Start block for first inode * @lblk2: Start block for second inode * @count: Number of blocks to swap - * @mark_unwritten: Mark second inode's extents as unwritten after swap + * @unwritten: Mark second inode's extents as unwritten after swap * @erp: Pointer to save error value * * This helper routine does exactly what is promise "swap extents". All other
"mark_unwritten" in comment and "unwritten" in variable argument lists is mismatch. Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com> --- fs/ext4/extents.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)