[ovs-dev,v2] dpdk: Use DPDK 17.11.1 release.

Message ID 1520853249-32428-1-git-send-email-ian.stokes@intel.com
State Accepted
Delegated to: Ian Stokes
Headers show
Series
  • [ovs-dev,v2] dpdk: Use DPDK 17.11.1 release.
Related show

Commit Message

Stokes, Ian March 12, 2018, 11:14 a.m.
Modify docs and travis linux build script to use the DPDK 17.11.1
release branch to benefit from most recent bug fixes.

There are no new features introduced in the DPDK release, only back
ported bug fixes. For completeness these bug fixes have been documented
under the 17.11.1 section in the link below.

http://dpdk.org/doc/guides-17.11/rel_notes/release_17_11.html#id1

Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---

v1 -> v2

* Remove details of the rx vectorization virtio pmd bug from
  vhost-user.rst as this has been fixed in DPDK 17.11.1.
---
 .travis/linux-build.sh                   |  2 +-
 Documentation/faq/releases.rst           |  4 ++--
 Documentation/intro/install/dpdk.rst     |  8 ++++----
 Documentation/topics/dpdk/vhost-user.rst | 32 +++++---------------------------
 4 files changed, 12 insertions(+), 34 deletions(-)

Comments

Kevin Traynor March 12, 2018, 11:35 a.m. | #1
On 03/12/2018 11:14 AM, Ian Stokes wrote:
> Modify docs and travis linux build script to use the DPDK 17.11.1
> release branch to benefit from most recent bug fixes.
> 
> There are no new features introduced in the DPDK release, only back
> ported bug fixes. For completeness these bug fixes have been documented
> under the 17.11.1 section in the link below.
> 
> http://dpdk.org/doc/guides-17.11/rel_notes/release_17_11.html#id1
> 
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> ---
> 
> v1 -> v2
> 
> * Remove details of the rx vectorization virtio pmd bug from
>   vhost-user.rst as this has been fixed in DPDK 17.11.1.
> ---
>  .travis/linux-build.sh                   |  2 +-
>  Documentation/faq/releases.rst           |  4 ++--
>  Documentation/intro/install/dpdk.rst     |  8 ++++----
>  Documentation/topics/dpdk/vhost-user.rst | 32 +++++---------------------------
>  4 files changed, 12 insertions(+), 34 deletions(-)
> 
> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
> index ee615c9..19b2ccf 100755
> --- a/.travis/linux-build.sh
> +++ b/.travis/linux-build.sh
> @@ -83,7 +83,7 @@ fi
>  
>  if [ "$DPDK" ]; then
>      if [ -z "$DPDK_VER" ]; then
> -        DPDK_VER="17.11"
> +        DPDK_VER="17.11.1"
>      fi
>      install_dpdk $DPDK_VER
>      if [ "$CC" = "clang" ]; then
> diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
> index 4f805a5..7c65503 100644
> --- a/Documentation/faq/releases.rst
> +++ b/Documentation/faq/releases.rst
> @@ -163,9 +163,9 @@ Q: What DPDK version does each Open vSwitch release work with?
>      2.4.x        2.0
>      2.5.x        2.2
>      2.6.x        16.07.2
> -    2.7.x        16.11.4
> +    2.7.x        16.11.5
>      2.8.x        17.05.2
> -    2.9.x        17.11
> +    2.9.x        17.11.1
>      ============ =======
>  
>  Q: I get an error like this when I configure Open vSwitch:
> diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst
> index ed358d5..e0a96ac 100644
> --- a/Documentation/intro/install/dpdk.rst
> +++ b/Documentation/intro/install/dpdk.rst
> @@ -40,7 +40,7 @@ Build requirements
>  In addition to the requirements described in :doc:`general`, building Open
>  vSwitch with DPDK will require the following:
>  
> -- DPDK 17.11
> +- DPDK 17.11.1
>  
>  - A `DPDK supported NIC`_
>  
> @@ -69,9 +69,9 @@ Install DPDK
>  #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
>  
>         $ cd /usr/src/
> -       $ wget http://fast.dpdk.org/rel/dpdk-17.11.tar.xz
> -       $ tar xf dpdk-17.11.tar.xz
> -       $ export DPDK_DIR=/usr/src/dpdk-17.11
> +       $ wget http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz
> +       $ tar xf dpdk-17.11.1.tar.xz
> +       $ export DPDK_DIR=/usr/src/dpdk-17.11.1
>         $ cd $DPDK_DIR
>  
>  #. (Optional) Configure DPDK as a shared library
> diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst
> index 95517a6..3aef795 100644
> --- a/Documentation/topics/dpdk/vhost-user.rst
> +++ b/Documentation/topics/dpdk/vhost-user.rst
> @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or
>  DPDK sources to VM and build DPDK::
>  
>      $ cd /root/dpdk/
> -    $ wget http://fast.dpdk.org/rel/dpdk-17.11.tar.xz
> -    $ tar xf dpdk-17.11.tar.xz
> -    $ export DPDK_DIR=/root/dpdk/dpdk-17.11
> +    $ wget http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz
> +    $ tar xf dpdk-17.11.1.tar.xz
> +    $ export DPDK_DIR=/root/dpdk/dpdk-17.11.1

Nit: as it's now on a stable release, it should be:
/root/dpdk/dpdk-stable-17.11.1

with that in master/2.9, both
Acked-by: Kevin Traynor <ktraynor@redhat.com>

thanks,
Kevin.

>      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>      $ cd $DPDK_DIR
> @@ -355,28 +355,6 @@ Finally, start the application::
>  
>      # TODO
>  
> -.. important::
> -
> -  DPDK v17.11 virtio PMD contains a bug in the vectorized Rx function that
> -  affects testpmd/DPDK guest applications. As such, guest DPDK applications
> -  should use a non-vectorized Rx function.
> -
> -The DPDK v17.11 virtio net driver contains a bug that prevents guest DPDK
> -applications from receiving packets when the vectorized Rx function is used.
> -This only occurs when guest-bound traffic is live before a DPDK application is
> -started within the guest, and where two or more forwarding cores are used. As
> -such, it is not recommended for guests which execute DPDK applications to use
> -the virtio vectorized Rx function. A simple method of ensuring that a non-
> -vectorized Rx function is used is to enable mergeable buffers for the guest,
> -with the following QEMU command line option::
> -
> -    mrg_rxbuf=on
> -
> -Additional details regarding the virtio driver bug are available on the
> -`DPDK mailing list`_.
> -
> -.. _DPDK mailing list: http://dpdk.org/ml/archives/dev/2017-December/082801.html
> -
>  .. _dpdk-vhost-user-xml:
>  
>  Sample XML
> @@ -428,7 +406,7 @@ Sample XML
>          </disk>
>          <disk type='dir' device='disk'>
>            <driver name='qemu' type='fat'/>
> -          <source dir='/usr/src/dpdk-stable-17.05.2'/>
> +          <source dir='/usr/src/dpdk-stable-17.11.1'/>
>            <target dev='vdb' bus='virtio'/>
>            <readonly/>
>          </disk>
> @@ -530,4 +508,4 @@ issue can be found on
>  
>  Further information can be found in the
>  `DPDK documentation
> -<http://dpdk.readthedocs.io/en/v17.05/prog_guide/vhost_lib.html>`__
> +<http://dpdk.readthedocs.io/en/v17.11/prog_guide/vhost_lib.html>`__
>
Stokes, Ian March 12, 2018, 11:40 a.m. | #2
> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Monday, March 12, 2018 11:36 AM
> To: Stokes, Ian <ian.stokes@intel.com>; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] dpdk: Use DPDK 17.11.1 release.
> 
> On 03/12/2018 11:14 AM, Ian Stokes wrote:
> > Modify docs and travis linux build script to use the DPDK 17.11.1
> > release branch to benefit from most recent bug fixes.
> >
> > There are no new features introduced in the DPDK release, only back
> > ported bug fixes. For completeness these bug fixes have been
> > documented under the 17.11.1 section in the link below.
> >
> > http://dpdk.org/doc/guides-17.11/rel_notes/release_17_11.html#id1
> >
> > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> > ---
> >
> > v1 -> v2
> >
> > * Remove details of the rx vectorization virtio pmd bug from
> >   vhost-user.rst as this has been fixed in DPDK 17.11.1.
> > ---
> >  .travis/linux-build.sh                   |  2 +-
> >  Documentation/faq/releases.rst           |  4 ++--
> >  Documentation/intro/install/dpdk.rst     |  8 ++++----
> >  Documentation/topics/dpdk/vhost-user.rst | 32
> > +++++---------------------------
> >  4 files changed, 12 insertions(+), 34 deletions(-)
> >
> > diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh index
> > ee615c9..19b2ccf 100755
> > --- a/.travis/linux-build.sh
> > +++ b/.travis/linux-build.sh
> > @@ -83,7 +83,7 @@ fi
> >
> >  if [ "$DPDK" ]; then
> >      if [ -z "$DPDK_VER" ]; then
> > -        DPDK_VER="17.11"
> > +        DPDK_VER="17.11.1"
> >      fi
> >      install_dpdk $DPDK_VER
> >      if [ "$CC" = "clang" ]; then
> > diff --git a/Documentation/faq/releases.rst
> > b/Documentation/faq/releases.rst index 4f805a5..7c65503 100644
> > --- a/Documentation/faq/releases.rst
> > +++ b/Documentation/faq/releases.rst
> > @@ -163,9 +163,9 @@ Q: What DPDK version does each Open vSwitch release
> work with?
> >      2.4.x        2.0
> >      2.5.x        2.2
> >      2.6.x        16.07.2
> > -    2.7.x        16.11.4
> > +    2.7.x        16.11.5
> >      2.8.x        17.05.2
> > -    2.9.x        17.11
> > +    2.9.x        17.11.1
> >      ============ =======
> >
> >  Q: I get an error like this when I configure Open vSwitch:
> > diff --git a/Documentation/intro/install/dpdk.rst
> > b/Documentation/intro/install/dpdk.rst
> > index ed358d5..e0a96ac 100644
> > --- a/Documentation/intro/install/dpdk.rst
> > +++ b/Documentation/intro/install/dpdk.rst
> > @@ -40,7 +40,7 @@ Build requirements
> >  In addition to the requirements described in :doc:`general`, building
> > Open  vSwitch with DPDK will require the following:
> >
> > -- DPDK 17.11
> > +- DPDK 17.11.1
> >
> >  - A `DPDK supported NIC`_
> >
> > @@ -69,9 +69,9 @@ Install DPDK
> >  #. Download the `DPDK sources`_, extract the file and set
> ``DPDK_DIR``::
> >
> >         $ cd /usr/src/
> > -       $ wget http://fast.dpdk.org/rel/dpdk-17.11.tar.xz
> > -       $ tar xf dpdk-17.11.tar.xz
> > -       $ export DPDK_DIR=/usr/src/dpdk-17.11
> > +       $ wget http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz
> > +       $ tar xf dpdk-17.11.1.tar.xz
> > +       $ export DPDK_DIR=/usr/src/dpdk-17.11.1
> >         $ cd $DPDK_DIR
> >
> >  #. (Optional) Configure DPDK as a shared library diff --git
> > a/Documentation/topics/dpdk/vhost-user.rst
> > b/Documentation/topics/dpdk/vhost-user.rst
> > index 95517a6..3aef795 100644
> > --- a/Documentation/topics/dpdk/vhost-user.rst
> > +++ b/Documentation/topics/dpdk/vhost-user.rst
> > @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in
> > :ref:`dpdk-vhost-user` or  DPDK sources to VM and build DPDK::
> >
> >      $ cd /root/dpdk/
> > -    $ wget http://fast.dpdk.org/rel/dpdk-17.11.tar.xz
> > -    $ tar xf dpdk-17.11.tar.xz
> > -    $ export DPDK_DIR=/root/dpdk/dpdk-17.11
> > +    $ wget http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz
> > +    $ tar xf dpdk-17.11.1.tar.xz
> > +    $ export DPDK_DIR=/root/dpdk/dpdk-17.11.1
> 
> Nit: as it's now on a stable release, it should be:
> /root/dpdk/dpdk-stable-17.11.1

Good catch, I'll make the change on commit to dpdk_merge.

Thanks
Ian
> 
> with that in master/2.9, both
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
> 
> thanks,
> Kevin.
> 
> >      $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
> >      $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
> >      $ cd $DPDK_DIR
> > @@ -355,28 +355,6 @@ Finally, start the application::
> >
> >      # TODO
> >
> > -.. important::
> > -
> > -  DPDK v17.11 virtio PMD contains a bug in the vectorized Rx function
> > that
> > -  affects testpmd/DPDK guest applications. As such, guest DPDK
> > applications
> > -  should use a non-vectorized Rx function.
> > -
> > -The DPDK v17.11 virtio net driver contains a bug that prevents guest
> > DPDK -applications from receiving packets when the vectorized Rx
> function is used.
> > -This only occurs when guest-bound traffic is live before a DPDK
> > application is -started within the guest, and where two or more
> > forwarding cores are used. As -such, it is not recommended for guests
> > which execute DPDK applications to use -the virtio vectorized Rx
> > function. A simple method of ensuring that a non- -vectorized Rx
> > function is used is to enable mergeable buffers for the guest, -with the
> following QEMU command line option::
> > -
> > -    mrg_rxbuf=on
> > -
> > -Additional details regarding the virtio driver bug are available on
> > the -`DPDK mailing list`_.
> > -
> > -.. _DPDK mailing list:
> > http://dpdk.org/ml/archives/dev/2017-December/082801.html
> > -
> >  .. _dpdk-vhost-user-xml:
> >
> >  Sample XML
> > @@ -428,7 +406,7 @@ Sample XML
> >          </disk>
> >          <disk type='dir' device='disk'>
> >            <driver name='qemu' type='fat'/>
> > -          <source dir='/usr/src/dpdk-stable-17.05.2'/>
> > +          <source dir='/usr/src/dpdk-stable-17.11.1'/>
> >            <target dev='vdb' bus='virtio'/>
> >            <readonly/>
> >          </disk>
> > @@ -530,4 +508,4 @@ issue can be found on
> >
> >  Further information can be found in the  `DPDK documentation
> > -<http://dpdk.readthedocs.io/en/v17.05/prog_guide/vhost_lib.html>`__
> > +<http://dpdk.readthedocs.io/en/v17.11/prog_guide/vhost_lib.html>`__
> >

Patch

diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
index ee615c9..19b2ccf 100755
--- a/.travis/linux-build.sh
+++ b/.travis/linux-build.sh
@@ -83,7 +83,7 @@  fi
 
 if [ "$DPDK" ]; then
     if [ -z "$DPDK_VER" ]; then
-        DPDK_VER="17.11"
+        DPDK_VER="17.11.1"
     fi
     install_dpdk $DPDK_VER
     if [ "$CC" = "clang" ]; then
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index 4f805a5..7c65503 100644
--- a/Documentation/faq/releases.rst
+++ b/Documentation/faq/releases.rst
@@ -163,9 +163,9 @@  Q: What DPDK version does each Open vSwitch release work with?
     2.4.x        2.0
     2.5.x        2.2
     2.6.x        16.07.2
-    2.7.x        16.11.4
+    2.7.x        16.11.5
     2.8.x        17.05.2
-    2.9.x        17.11
+    2.9.x        17.11.1
     ============ =======
 
 Q: I get an error like this when I configure Open vSwitch:
diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst
index ed358d5..e0a96ac 100644
--- a/Documentation/intro/install/dpdk.rst
+++ b/Documentation/intro/install/dpdk.rst
@@ -40,7 +40,7 @@  Build requirements
 In addition to the requirements described in :doc:`general`, building Open
 vSwitch with DPDK will require the following:
 
-- DPDK 17.11
+- DPDK 17.11.1
 
 - A `DPDK supported NIC`_
 
@@ -69,9 +69,9 @@  Install DPDK
 #. Download the `DPDK sources`_, extract the file and set ``DPDK_DIR``::
 
        $ cd /usr/src/
-       $ wget http://fast.dpdk.org/rel/dpdk-17.11.tar.xz
-       $ tar xf dpdk-17.11.tar.xz
-       $ export DPDK_DIR=/usr/src/dpdk-17.11
+       $ wget http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz
+       $ tar xf dpdk-17.11.1.tar.xz
+       $ export DPDK_DIR=/usr/src/dpdk-17.11.1
        $ cd $DPDK_DIR
 
 #. (Optional) Configure DPDK as a shared library
diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst
index 95517a6..3aef795 100644
--- a/Documentation/topics/dpdk/vhost-user.rst
+++ b/Documentation/topics/dpdk/vhost-user.rst
@@ -320,9 +320,9 @@  To begin, instantiate a guest as described in :ref:`dpdk-vhost-user` or
 DPDK sources to VM and build DPDK::
 
     $ cd /root/dpdk/
-    $ wget http://fast.dpdk.org/rel/dpdk-17.11.tar.xz
-    $ tar xf dpdk-17.11.tar.xz
-    $ export DPDK_DIR=/root/dpdk/dpdk-17.11
+    $ wget http://fast.dpdk.org/rel/dpdk-17.11.1.tar.xz
+    $ tar xf dpdk-17.11.1.tar.xz
+    $ export DPDK_DIR=/root/dpdk/dpdk-17.11.1
     $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
     $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
     $ cd $DPDK_DIR
@@ -355,28 +355,6 @@  Finally, start the application::
 
     # TODO
 
-.. important::
-
-  DPDK v17.11 virtio PMD contains a bug in the vectorized Rx function that
-  affects testpmd/DPDK guest applications. As such, guest DPDK applications
-  should use a non-vectorized Rx function.
-
-The DPDK v17.11 virtio net driver contains a bug that prevents guest DPDK
-applications from receiving packets when the vectorized Rx function is used.
-This only occurs when guest-bound traffic is live before a DPDK application is
-started within the guest, and where two or more forwarding cores are used. As
-such, it is not recommended for guests which execute DPDK applications to use
-the virtio vectorized Rx function. A simple method of ensuring that a non-
-vectorized Rx function is used is to enable mergeable buffers for the guest,
-with the following QEMU command line option::
-
-    mrg_rxbuf=on
-
-Additional details regarding the virtio driver bug are available on the
-`DPDK mailing list`_.
-
-.. _DPDK mailing list: http://dpdk.org/ml/archives/dev/2017-December/082801.html
-
 .. _dpdk-vhost-user-xml:
 
 Sample XML
@@ -428,7 +406,7 @@  Sample XML
         </disk>
         <disk type='dir' device='disk'>
           <driver name='qemu' type='fat'/>
-          <source dir='/usr/src/dpdk-stable-17.05.2'/>
+          <source dir='/usr/src/dpdk-stable-17.11.1'/>
           <target dev='vdb' bus='virtio'/>
           <readonly/>
         </disk>
@@ -530,4 +508,4 @@  issue can be found on
 
 Further information can be found in the
 `DPDK documentation
-<http://dpdk.readthedocs.io/en/v17.05/prog_guide/vhost_lib.html>`__
+<http://dpdk.readthedocs.io/en/v17.11/prog_guide/vhost_lib.html>`__