diff mbox series

[RFC] hw/imc: don't access homer memory if it was not initialised

Message ID 20180216065237.30771-1-npiggin@gmail.com
State Superseded
Headers show
Series [RFC] hw/imc: don't access homer memory if it was not initialised | expand

Commit Message

Nicholas Piggin Feb. 16, 2018, 6:52 a.m. UTC 
This can happen under mambo, at least.
---
 hw/imc.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/hw/imc.c b/hw/imc.c
index 5bc59b59..c7999e1e 100644
--- a/hw/imc.c
+++ b/hw/imc.c
@@ -154,6 +154,9 @@  static struct imc_chip_cb *get_imc_cb(uint32_t chip_id)
 	struct proc_chip *chip = get_chip(chip_id);
 	struct imc_chip_cb *cb;
 
+	if (!chip->homer_base)
+		return NULL; /* The No Homers Club */
+
 	cb = (struct imc_chip_cb *)(chip->homer_base + P9_CB_STRUCT_OFFSET);
 	if (!is_nest_mem_initialized(cb))
 		return NULL;