[ovs-dev,4/4] openflow: Update list of features.

Message ID 20180208231849.31519-4-blp@ovn.org
State Accepted
Headers show
Series
  • [ovs-dev,1/4] Implement OF1.3 extension for OF1.4 role status feature.
Related show

Commit Message

Ben Pfaff Feb. 8, 2018, 11:18 p.m.
Bundles are implemented for both OF1.3 and OF1.4+, so no need to keep it
in the list.  Packet type aware pipeline is now implemented too.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 Documentation/topics/openflow.rst | 24 ------------------------
 1 file changed, 24 deletions(-)

Comments

William Tu Feb. 13, 2018, 7:12 p.m. | #1
On Thu, Feb 8, 2018 at 3:18 PM, Ben Pfaff <blp@ovn.org> wrote:
> Bundles are implemented for both OF1.3 and OF1.4+, so no need to keep it
> in the list.  Packet type aware pipeline is now implemented too.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>


Looks good to me.
Acked-by: William Tu <u9012063@gmail.com>

> ---
>  Documentation/topics/openflow.rst | 24 ------------------------
>  1 file changed, 24 deletions(-)
>
> diff --git a/Documentation/topics/openflow.rst b/Documentation/topics/openflow.rst
> index ea5a4450687d..2f2cc830964b 100644
> --- a/Documentation/topics/openflow.rst
> +++ b/Documentation/topics/openflow.rst
> @@ -175,22 +175,6 @@ in OVS.
>
>    (optional for OF1.4+)
>
> -* Bundle
> -
> -  Transactional modification.  OpenFlow 1.4 requires to support
> -  ``flow_mods`` and ``port_mods`` in a bundle if bundle is supported.
> -  (Not related to OVS's 'ofbundle' stuff.)
> -
> -  Implemented as an OpenFlow 1.4 feature.  Only flow_mods and port_mods are
> -  supported in a bundle.  If the bundle includes port mods, it may not specify
> -  the ``OFPBF_ATOMIC`` flag.  Nevertheless, port mods and flow mods in a bundle
> -  are always applied in order and consecutive flow mods between port mods are
> -  made available to lookups atomically.
> -
> -  (EXT-230)
> -
> -  (optional for OF1.4+)
> -
>  * Table synchronisation
>
>    Probably not so useful to the software switch.
> @@ -270,14 +254,6 @@ definitive as OpenFlow 1.5 is not yet published.
>
>    (optional for OF1.5+)
>
> -* Packet Type aware pipeline
> -
> -  Prototype for OVS was done during specification.
> -
> -  (EXT-112)
> -
> -  (optional for OF1.5+)
> -
>  * Extensible Flow Entry Statistics
>
>    (EXT-334)
> --
> 2.15.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff Feb. 13, 2018, 8:21 p.m. | #2
On Tue, Feb 13, 2018 at 11:12:45AM -0800, William Tu wrote:
> On Thu, Feb 8, 2018 at 3:18 PM, Ben Pfaff <blp@ovn.org> wrote:
> > Bundles are implemented for both OF1.3 and OF1.4+, so no need to keep it
> > in the list.  Packet type aware pipeline is now implemented too.
> >
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> 
> 
> Looks good to me.
> Acked-by: William Tu <u9012063@gmail.com>

Thank you for the reviews.  I applied these to master.

Patch

diff --git a/Documentation/topics/openflow.rst b/Documentation/topics/openflow.rst
index ea5a4450687d..2f2cc830964b 100644
--- a/Documentation/topics/openflow.rst
+++ b/Documentation/topics/openflow.rst
@@ -175,22 +175,6 @@  in OVS.
 
   (optional for OF1.4+)
 
-* Bundle
-
-  Transactional modification.  OpenFlow 1.4 requires to support
-  ``flow_mods`` and ``port_mods`` in a bundle if bundle is supported.
-  (Not related to OVS's 'ofbundle' stuff.)
-
-  Implemented as an OpenFlow 1.4 feature.  Only flow_mods and port_mods are
-  supported in a bundle.  If the bundle includes port mods, it may not specify
-  the ``OFPBF_ATOMIC`` flag.  Nevertheless, port mods and flow mods in a bundle
-  are always applied in order and consecutive flow mods between port mods are
-  made available to lookups atomically.
-
-  (EXT-230)
-
-  (optional for OF1.4+)
-
 * Table synchronisation
 
   Probably not so useful to the software switch.
@@ -270,14 +254,6 @@  definitive as OpenFlow 1.5 is not yet published.
 
   (optional for OF1.5+)
 
-* Packet Type aware pipeline
-
-  Prototype for OVS was done during specification.
-
-  (EXT-112)
-
-  (optional for OF1.5+)
-
 * Extensible Flow Entry Statistics
 
   (EXT-334)