diff mbox series

[ovs-dev,2/2] rhel: Add the new ovsdb manpages to %files list (also for RHEL)

Message ID 20180116235547.26223-2-aatteka@ovn.org
State Accepted
Headers show
Series [ovs-dev,1/2] rhel: add missing mandatory build dependencies | expand

Commit Message

Ansis Atteka Jan. 16, 2018, 11:55 p.m. UTC
From: Ansis Atteka <ansisatteka@gmail.com>

Currently, "rpmbuild -bb rhel/openvswitch.spec" doesn't work correctly
since the new ovsdb manpages (ovsdb.5, ovsdb.7 and ovsdb-server.7) were
added.

This patch adds the new ovsdb manpages in the %files list in the spec
file.

CC: Ben Pfaff <blp@ovn.org>
Fixes: 12b84d50e032 ("ovsdb: Improve documentation.")
Signed-off-by: Ansis Atteka <aatteka@ovn.org>
---
 rhel/openvswitch.spec.in | 3 +++
 1 file changed, 3 insertions(+)

Comments

Gregory Rose Jan. 17, 2018, 12:49 a.m. UTC | #1
On 1/16/2018 3:55 PM, Ansis Atteka wrote:
> From: Ansis Atteka <ansisatteka@gmail.com>
>
> Currently, "rpmbuild -bb rhel/openvswitch.spec" doesn't work correctly
> since the new ovsdb manpages (ovsdb.5, ovsdb.7 and ovsdb-server.7) were
> added.
>
> This patch adds the new ovsdb manpages in the %files list in the spec
> file.
>
> CC: Ben Pfaff <blp@ovn.org>
> Fixes: 12b84d50e032 ("ovsdb: Improve documentation.")
> Signed-off-by: Ansis Atteka <aatteka@ovn.org>
> ---
>   rhel/openvswitch.spec.in | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in
> index c1d2376df..104b27329 100644
> --- a/rhel/openvswitch.spec.in
> +++ b/rhel/openvswitch.spec.in
> @@ -228,8 +228,11 @@ exit 0
>   /usr/share/man/man1/ovsdb-server.1.gz
>   /usr/share/man/man1/ovsdb-tool.1.gz
>   /usr/share/man/man5/ovs-vswitchd.conf.db.5.gz
> +%{_mandir}/man5/ovsdb.5*
>   /usr/share/man/man5/vtep.5.gz
>   /usr/share/man/man7/ovs-fields.7.gz
> +%{_mandir}/man7/ovsdb.7*
> +%{_mandir}/man7/ovsdb-server.7*
>   /usr/share/man/man8/ovs-appctl.8.gz
>   /usr/share/man/man8/ovs-bugtool.8.gz
>   /usr/share/man/man8/ovs-ctl.8.gz

I tested the patches and the fix works.

Thanks Ansis!

For both patches...

Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Ansis Jan. 17, 2018, 12:57 a.m. UTC | #2
On 16 January 2018 at 16:49, Gregory Rose <gvrose8192@gmail.com> wrote:
> On 1/16/2018 3:55 PM, Ansis Atteka wrote:
>>
>> From: Ansis Atteka <ansisatteka@gmail.com>
>>
>> Currently, "rpmbuild -bb rhel/openvswitch.spec" doesn't work correctly
>> since the new ovsdb manpages (ovsdb.5, ovsdb.7 and ovsdb-server.7) were
>> added.
>>
>> This patch adds the new ovsdb manpages in the %files list in the spec
>> file.
>>
>> CC: Ben Pfaff <blp@ovn.org>
>> Fixes: 12b84d50e032 ("ovsdb: Improve documentation.")
>> Signed-off-by: Ansis Atteka <aatteka@ovn.org>
>> ---
>>   rhel/openvswitch.spec.in | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in
>> index c1d2376df..104b27329 100644
>> --- a/rhel/openvswitch.spec.in
>> +++ b/rhel/openvswitch.spec.in
>> @@ -228,8 +228,11 @@ exit 0
>>   /usr/share/man/man1/ovsdb-server.1.gz
>>   /usr/share/man/man1/ovsdb-tool.1.gz
>>   /usr/share/man/man5/ovs-vswitchd.conf.db.5.gz
>> +%{_mandir}/man5/ovsdb.5*
>>   /usr/share/man/man5/vtep.5.gz
>>   /usr/share/man/man7/ovs-fields.7.gz
>> +%{_mandir}/man7/ovsdb.7*
>> +%{_mandir}/man7/ovsdb-server.7*
>>   /usr/share/man/man8/ovs-appctl.8.gz
>>   /usr/share/man/man8/ovs-bugtool.8.gz
>>   /usr/share/man/man8/ovs-ctl.8.gz
>
>
> I tested the patches and the fix works.
>
> Thanks Ansis!
>
> For both patches...
>

I pushed both patches to master branch. Thanks for review.
diff mbox series

Patch

diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in
index c1d2376df..104b27329 100644
--- a/rhel/openvswitch.spec.in
+++ b/rhel/openvswitch.spec.in
@@ -228,8 +228,11 @@  exit 0
 /usr/share/man/man1/ovsdb-server.1.gz
 /usr/share/man/man1/ovsdb-tool.1.gz
 /usr/share/man/man5/ovs-vswitchd.conf.db.5.gz
+%{_mandir}/man5/ovsdb.5*
 /usr/share/man/man5/vtep.5.gz
 /usr/share/man/man7/ovs-fields.7.gz
+%{_mandir}/man7/ovsdb.7*
+%{_mandir}/man7/ovsdb-server.7*
 /usr/share/man/man8/ovs-appctl.8.gz
 /usr/share/man/man8/ovs-bugtool.8.gz
 /usr/share/man/man8/ovs-ctl.8.gz