diff mbox series

[U-Boot] arm: mach-omap2: Pass args to secure ROM in SRAM in SPL

Message ID 20180116202548.20141-1-afd@ti.com
State Accepted
Commit 60013a2cf61a318c87f1a8c0b3a39b47c3f220a6
Delegated to: Tom Rini
Headers show
Series [U-Boot] arm: mach-omap2: Pass args to secure ROM in SRAM in SPL | expand

Commit Message

Andrew Davis Jan. 16, 2018, 8:25 p.m. UTC
When in early SPL we make some secure ROM calls that can effect
DRAM, due to this it is more stable to store the args for these
calls in SRAM, but uninitialized and zero'd globals are placed
in BSS, located in DRAM. Force our args into the data section
which is in SRAM during SPL.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/mach-omap2/sec-common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Jan. 28, 2018, 6:52 p.m. UTC | #1
On Tue, Jan 16, 2018 at 02:25:48PM -0600, Andrew F. Davis wrote:

> When in early SPL we make some secure ROM calls that can effect
> DRAM, due to this it is more stable to store the args for these
> calls in SRAM, but uninitialized and zero'd globals are placed
> in BSS, located in DRAM. Force our args into the data section
> which is in SRAM during SPL.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/arch/arm/mach-omap2/sec-common.c b/arch/arm/mach-omap2/sec-common.c
index 2630e7d316..1906a126cf 100644
--- a/arch/arm/mach-omap2/sec-common.c
+++ b/arch/arm/mach-omap2/sec-common.c
@@ -56,7 +56,7 @@  struct ppa_tee_load_info {
 	u32 tee_arg0;          /* argument to TEE jump function, in r0 */
 };
 
-static uint32_t secure_rom_call_args[5] __aligned(ARCH_DMA_MINALIGN);
+static uint32_t secure_rom_call_args[5] __aligned(ARCH_DMA_MINALIGN) __section(".data");
 
 u32 secure_rom_call(u32 service, u32 proc_id, u32 flag, ...)
 {