diff mbox series

[kteam-tools] start-sru-cycle: change backports / derivatives format in tracking bug description

Message ID 20180116081438.28294-1-po-hsu.lin@canonical.com
State New
Headers show
Series [kteam-tools] start-sru-cycle: change backports / derivatives format in tracking bug description | expand

Commit Message

Po-Hsu Lin Jan. 16, 2018, 8:14 a.m. UTC
Now the backports / derivatives in tracking bug description looks like:
backports: 1743363,1743364
derivatives: 1743365,1743367,1743368,1743369,1743370,174337

Add a 'bug' string before the bug number for launchpad to treat it as a link.
Add a '(package-name)' after it, so we could know what it is from a glance.

The new style is expected to be:
backports: bug 1743363 (linux-aws), bug 1743364 (linux-lts-xenial)
derivatives: bug 1743365 (linux-aws), bug 1743367 (linux-euclid), bug 1743368 (linux-gke)...

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 stable/start-sru-cycle | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Stefan Bader Jan. 24, 2018, 1:45 p.m. UTC | #1
On 16.01.2018 09:14, Po-Hsu Lin wrote:
> Now the backports / derivatives in tracking bug description looks like:
> backports: 1743363,1743364
> derivatives: 1743365,1743367,1743368,1743369,1743370,174337
> 
> Add a 'bug' string before the bug number for launchpad to treat it as a link.
> Add a '(package-name)' after it, so we could know what it is from a glance.
> 
> The new style is expected to be:
> backports: bug 1743363 (linux-aws), bug 1743364 (linux-lts-xenial)
> derivatives: bug 1743365 (linux-aws), bug 1743367 (linux-euclid), bug 1743368 (linux-gke)...
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>

> ---
>  stable/start-sru-cycle | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/stable/start-sru-cycle b/stable/start-sru-cycle
> index 0cd58778..695ed849 100755
> --- a/stable/start-sru-cycle
> +++ b/stable/start-sru-cycle
> @@ -116,7 +116,7 @@ class Crankers():
>                              print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
>                              continue
>                          bug.tags.append(cycle_tag)
> -                        backports.append(str(bug.id))
> +                        backports.append('bug {} ({})'.format(str(bug.id), backport_project))
>                          bug.tags.append('kernel-sru-backport-of-%s' % master_bug.id)
>  
>                      derivatives = []
> @@ -127,13 +127,13 @@ class Crankers():
>                              print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
>                              continue
>                          bug.tags.append(cycle_tag)
> -                        derivatives.append(str(bug.id))
> +                        derivatives.append('bug {} ({})'.format(str(bug.id), derivative_project))
>                          bug.tags.append('kernel-sru-derivative-of-%s' % master_bug.id)
>  
>                      description = master_bug.description
>                      description += '\n'
> -                    description += 'backports: %s\n' % ','.join(backports)
> -                    description += 'derivatives: %s\n' % ','.join(derivatives)
> +                    description += 'backports: %s\n' % ', '.join(backports)
> +                    description += 'derivatives: %s\n' % ', '.join(derivatives)
>                      master_bug.description = description
>  
>              retval = 0
>
Kamal Mostafa Jan. 29, 2018, 7:08 p.m. UTC | #2
Acked-by: Kamal Mostafa <kamal@canonical.com>
Kleber Sacilotto de Souza March 1, 2018, 5:34 p.m. UTC | #3
On 01/16/18 09:14, Po-Hsu Lin wrote:
> Now the backports / derivatives in tracking bug description looks like:
> backports: 1743363,1743364
> derivatives: 1743365,1743367,1743368,1743369,1743370,174337
> 
> Add a 'bug' string before the bug number for launchpad to treat it as a link.
> Add a '(package-name)' after it, so we could know what it is from a glance.
> 
> The new style is expected to be:
> backports: bug 1743363 (linux-aws), bug 1743364 (linux-lts-xenial)
> derivatives: bug 1743365 (linux-aws), bug 1743367 (linux-euclid), bug 1743368 (linux-gke)...
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  stable/start-sru-cycle | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/stable/start-sru-cycle b/stable/start-sru-cycle
> index 0cd58778..695ed849 100755
> --- a/stable/start-sru-cycle
> +++ b/stable/start-sru-cycle
> @@ -116,7 +116,7 @@ class Crankers():
>                              print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
>                              continue
>                          bug.tags.append(cycle_tag)
> -                        backports.append(str(bug.id))
> +                        backports.append('bug {} ({})'.format(str(bug.id), backport_project))
>                          bug.tags.append('kernel-sru-backport-of-%s' % master_bug.id)
>  
>                      derivatives = []
> @@ -127,13 +127,13 @@ class Crankers():
>                              print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
>                              continue
>                          bug.tags.append(cycle_tag)
> -                        derivatives.append(str(bug.id))
> +                        derivatives.append('bug {} ({})'.format(str(bug.id), derivative_project))
>                          bug.tags.append('kernel-sru-derivative-of-%s' % master_bug.id)
>  
>                      description = master_bug.description
>                      description += '\n'
> -                    description += 'backports: %s\n' % ','.join(backports)
> -                    description += 'derivatives: %s\n' % ','.join(derivatives)
> +                    description += 'backports: %s\n' % ', '.join(backports)
> +                    description += 'derivatives: %s\n' % ', '.join(derivatives)
>                      master_bug.description = description
>  
>              retval = 0
> 

These changes have already been made as part of:

commit 9620e8e049455f37eee64b811294eda56603d02f
Author: Andy Whitcroft <apw@canonical.com>
Date:   Tue Feb 27 12:33:19 2018 +0000

    start-sru-cycle: convert to KernelSeries


Thanks,
Kleber
diff mbox series

Patch

diff --git a/stable/start-sru-cycle b/stable/start-sru-cycle
index 0cd58778..695ed849 100755
--- a/stable/start-sru-cycle
+++ b/stable/start-sru-cycle
@@ -116,7 +116,7 @@  class Crankers():
                             print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
                             continue
                         bug.tags.append(cycle_tag)
-                        backports.append(str(bug.id))
+                        backports.append('bug {} ({})'.format(str(bug.id), backport_project))
                         bug.tags.append('kernel-sru-backport-of-%s' % master_bug.id)
 
                     derivatives = []
@@ -127,13 +127,13 @@  class Crankers():
                             print('     -> EE: Bug creation failed (does the package exist in the archive?)!')
                             continue
                         bug.tags.append(cycle_tag)
-                        derivatives.append(str(bug.id))
+                        derivatives.append('bug {} ({})'.format(str(bug.id), derivative_project))
                         bug.tags.append('kernel-sru-derivative-of-%s' % master_bug.id)
 
                     description = master_bug.description
                     description += '\n'
-                    description += 'backports: %s\n' % ','.join(backports)
-                    description += 'derivatives: %s\n' % ','.join(derivatives)
+                    description += 'backports: %s\n' % ', '.join(backports)
+                    description += 'derivatives: %s\n' % ', '.join(derivatives)
                     master_bug.description = description
 
             retval = 0