| Message ID | 20180116063352.14392-2-jh80.chung@samsung.com |
|---|---|
| State | Accepted |
| Commit | 60599ea6cd4a55ea95470d8299e68104d463bfef |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | power: s2mps11: Support the DM regulator | expand |
On 15 January 2018 at 22:33, Jaehoon Chung <jh80.chung@samsung.com> wrote: > exynos5422 has the s2mps11 PMIC. > s2mps11 pmic has the 10-BUCK and 38-LDO regulators. > Each IP and devices in exynos5422 can be controlled by each regulators. > This patch is support for s2mps11 regulator driver. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/power/regulator/Kconfig | 8 + > drivers/power/regulator/Makefile | 1 + > drivers/power/regulator/s2mps11_regulator.c | 597 ++++++++++++++++++++++++++++ > include/power/s2mps11.h | 55 +++ > 4 files changed, 661 insertions(+) > create mode 100644 drivers/power/regulator/s2mps11_regulator.c Reviewed-by: Simon Glass <sjg@chromium.org>
Hi JaeHoon Chung, On 16 January 2018 at 12:03, Jaehoon Chung <jh80.chung@samsung.com> wrote: > exynos5422 has the s2mps11 PMIC. > s2mps11 pmic has the 10-BUCK and 38-LDO regulators. > Each IP and devices in exynos5422 can be controlled by each regulators. > This patch is support for s2mps11 regulator driver. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/power/regulator/Kconfig | 8 + > drivers/power/regulator/Makefile | 1 + > drivers/power/regulator/s2mps11_regulator.c | 597 ++++++++++++++++++++++++++++ > include/power/s2mps11.h | 55 +++ > 4 files changed, 661 insertions(+) > create mode 100644 drivers/power/regulator/s2mps11_regulator.c > > diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig > index 26fb9368ea..5b4ac10462 100644 > --- a/drivers/power/regulator/Kconfig > +++ b/drivers/power/regulator/Kconfig > @@ -101,6 +101,14 @@ config REGULATOR_RK8XX > by the PMIC device. This driver is controlled by a device tree node > which includes voltage limits. > > +config DM_REGULATOR_S2MPS11 > + bool "Enable driver for S2MPS11 regulator" > + depends on DM_REGULATOR && PMIC_S2MPS11 > + ---help--- > + This enables implementation of driver-model regulator uclass > + features for REGULATOR S2MPS11. > + The driver implements get/set api for: value and enable. > + > config REGULATOR_S5M8767 > bool "Enable support for S5M8767 regulator" > depends on DM_REGULATOR && PMIC_S5M8767 > diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile > index 7a2e76dc82..728e8144de 100644 > --- a/drivers/power/regulator/Makefile > +++ b/drivers/power/regulator/Makefile > @@ -14,6 +14,7 @@ obj-$(CONFIG_REGULATOR_PWM) += pwm_regulator.o > obj-$(CONFIG_$(SPL_)DM_REGULATOR_FIXED) += fixed.o > obj-$(CONFIG_$(SPL_)DM_REGULATOR_GPIO) += gpio-regulator.o > obj-$(CONFIG_REGULATOR_RK8XX) += rk8xx.o > +obj-$(CONFIG_DM_REGULATOR_S2MPS11) += s2mps11_regulator.o > obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o > obj-$(CONFIG_DM_REGULATOR_SANDBOX) += sandbox.o > obj-$(CONFIG_REGULATOR_TPS65090) += tps65090_regulator.o > diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c > new file mode 100644 > index 0000000000..3af20e60dd > --- /dev/null > +++ b/drivers/power/regulator/s2mps11_regulator.c > @@ -0,0 +1,597 @@ > +/* > + * Copyright (C) 2018 Samsung Electronics > + * Jaehoon Chung <jh80.chung@samsung.com> > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > + > +#include <common.h> > +#include <fdtdec.h> > +#include <errno.h> > +#include <dm.h> > +#include <i2c.h> > +#include <power/pmic.h> > +#include <power/regulator.h> > +#include <power/s2mps11.h> > + > +DECLARE_GLOBAL_DATA_PTR; > + > +#define MODE(_id, _val, _name) { \ > + .id = _id, \ > + .register_value = _val, \ > + .name = _name, \ > +} > + > +/* BUCK : 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 */ > +static struct dm_regulator_mode s2mps11_buck_modes[] = { > + MODE(OP_OFF, S2MPS11_BUCK_MODE_OFF, "OFF"), > + MODE(OP_STANDBY, S2MPS11_BUCK_MODE_STANDBY, "ON/OFF"), > + MODE(OP_ON, S2MPS11_BUCK_MODE_STANDBY, "ON"), > +}; > + > +static struct dm_regulator_mode s2mps11_ldo_modes[] = { > + MODE(OP_OFF, S2MPS11_LDO_MODE_OFF, "OFF"), > + MODE(OP_STANDBY, S2MPS11_LDO_MODE_STANDBY, "ON/OFF"), > + MODE(OP_STANDBY_LPM, S2MPS11_LDO_MODE_STANDBY_LPM, "ON/LPM"), > + MODE(OP_ON, S2MPS11_LDO_MODE_ON, "ON"), > +}; > + > +static const char s2mps11_buck_ctrl[] = { > + 0xff, 0x25, 0x27, 0x29, 0x2b, 0x2d, 0x33, 0x35, 0x37, 0x39, 0x3b > +}; > + > +static const char s2mps11_buck_out[] = { > + 0xff, 0x26, 0x28, 0x2a, 0x2c, 0x2f, 0x34, 0x36, 0x38, 0x3a, 0x3c > +}; > + > +static int s2mps11_buck_hex2volt(int buck, int hex) > +{ > + unsigned int uV = 0; > + > + if (hex < 0) > + goto bad; > + > + switch (buck) { > + case 7: > + case 8: > + case 10: > + if (hex > S2MPS11_BUCK7_8_10_VOLT_MAX_HEX) > + goto bad; > + > + uV = hex * S2MPS11_BUCK_HSTEP + S2MPS11_BUCK_UV_HMIN; > + break; > + case 9: > + if (hex > S2MPS11_BUCK9_VOLT_MAX_HEX) > + goto bad; > + uV = hex * S2MPS11_BUCK9_STEP * 2 + S2MPS11_BUCK9_UV_MIN; > + break; > + default: > + if (buck == 5 && hex > S2MPS11_BUCK5_VOLT_MAX_HEX) > + goto bad; > + else if (buck != 5 && hex > S2MPS11_BUCK_VOLT_MAX_HEX) > + goto bad; > + > + uV = hex * S2MPS11_BUCK_LSTEP + S2MPS11_BUCK_UV_MIN; > + break; > + } > + > + return uV; > +bad: > + pr_err("Value: %#x is wrong for BUCK%d", hex, buck); > + return -EINVAL; > +} > + > +static int s2mps11_buck_volt2hex(int buck, int uV) > +{ > + int hex; > + > + switch (buck) { > + case 7: > + case 8: > + case 10: > + hex = (uV - S2MPS11_BUCK_UV_HMIN) / S2MPS11_BUCK_HSTEP; > + if (hex > S2MPS11_BUCK7_8_10_VOLT_MAX_HEX) > + goto bad; > + > + break; > + case 9: > + hex = (uV - S2MPS11_BUCK9_UV_MIN) / S2MPS11_BUCK9_STEP; > + if (hex > S2MPS11_BUCK9_VOLT_MAX_HEX) > + goto bad; > + break; > + default: > + hex = (uV - S2MPS11_BUCK_UV_MIN) / S2MPS11_BUCK_LSTEP; > + if (buck == 5 && hex > S2MPS11_BUCK5_VOLT_MAX_HEX) > + goto bad; > + else if (buck != 5 && hex > S2MPS11_BUCK_VOLT_MAX_HEX) > + goto bad; > + break; > + }; > + > + if (hex >= 0) > + return hex; > + > +bad: > + pr_err("Value: %d uV is wrong for BUCK%d", uV, buck); > + return -EINVAL; > +} > + > +static int s2mps11_buck_val(struct udevice *dev, int op, int *uV) > +{ > + int hex, buck, ret; > + u32 mask, addr; > + u8 val; > + > + buck = dev->driver_data; > + if (buck < 1 || buck > S2MPS11_BUCK_NUM) { > + pr_err("Wrong buck number: %d\n", buck); > + return -EINVAL; > + } > + > + if (op == PMIC_OP_GET) > + *uV = 0; > + > + addr = s2mps11_buck_out[buck]; > + > + switch (buck) { > + case 9: > + mask = S2MPS11_BUCK9_VOLT_MASK; > + break; > + default: > + mask = S2MPS11_BUCK_VOLT_MASK; > + break; > + } > + > + ret = pmic_read(dev->parent, addr, &val, 1); > + if (ret) > + return ret; > + > + if (op == PMIC_OP_GET) { > + val &= mask; > + ret = s2mps11_buck_hex2volt(buck, val); > + if (ret < 0) > + return ret; > + *uV = ret; > + return 0; > + } > + > + hex = s2mps11_buck_volt2hex(buck, *uV); > + if (hex < 0) > + return hex; > + > + val &= ~mask; > + val |= hex; > + ret = pmic_write(dev->parent, addr, &val, 1); > + > + return ret; > +} > + > +static int s2mps11_buck_mode(struct udevice *dev, int op, int *opmode) > +{ > + unsigned int addr, mode; > + unsigned char val; > + int buck, ret; > + > + buck = dev->driver_data; > + if (buck < 1 || buck > S2MPS11_BUCK_NUM) { > + pr_err("Wrong buck number: %d\n", buck); > + return -EINVAL; > + } > + > + addr = s2mps11_buck_ctrl[buck]; > + > + ret = pmic_read(dev->parent, addr, &val, 1); > + if (ret) > + return ret; > + > + if (op == PMIC_OP_GET) { > + val &= (S2MPS11_BUCK_MODE_MASK << S2MPS11_BUCK_MODE_SHIFT); > + switch (val) { > + case S2MPS11_BUCK_MODE_OFF: > + *opmode = OP_OFF; > + break; > + case S2MPS11_BUCK_MODE_STANDBY: > + *opmode = OP_STANDBY; > + break; > + case S2MPS11_BUCK_MODE_ON: > + *opmode = OP_ON; > + break; > + default: > + return -EINVAL; > + } > + return 0; > + } > + > + switch (*opmode) { > + case OP_OFF: > + mode = S2MPS11_BUCK_MODE_OFF; > + break; > + case OP_STANDBY: > + mode = S2MPS11_BUCK_MODE_STANDBY; > + break; > + case OP_ON: > + mode = S2MPS11_BUCK_MODE_ON; > + break; > + default: > + pr_err("Wrong mode: %d for buck: %d\n", *opmode, buck); > + return -EINVAL; > + } > + > + val &= ~(S2MPS11_BUCK_MODE_MASK << S2MPS11_BUCK_MODE_SHIFT); > + val |= mode; > + ret = pmic_write(dev->parent, addr, &val, 1); > + > + return ret; > +} > + > +static int s2mps11_buck_enable(struct udevice *dev, int op, bool *enable) > +{ > + int ret, on_off; > + > + if (op == PMIC_OP_GET) { > + ret = s2mps11_buck_mode(dev, op, &on_off); > + if (ret) > + return ret; > + switch (on_off) { > + case OP_OFF: > + *enable = false; > + break; > + case OP_ON: > + *enable = true; > + break; > + default: > + return -EINVAL; > + } > + } else if (op == PMIC_OP_SET) { > + if (*enable) > + on_off = OP_ON; > + else > + on_off = OP_OFF; > + > + ret = s2mps11_buck_mode(dev, op, &on_off); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > +static int buck_get_value(struct udevice *dev) > +{ > + int uV; > + int ret; > + > + ret = s2mps11_buck_val(dev, PMIC_OP_GET, &uV); > + if (ret) > + return ret; > + return uV; > +} > + > +static int buck_set_value(struct udevice *dev, int uV) > +{ > + return s2mps11_buck_val(dev, PMIC_OP_SET, &uV); > +} > + > +static int buck_get_enable(struct udevice *dev) > +{ > + bool enable = false; > + int ret; > + > + ret = s2mps11_buck_enable(dev, PMIC_OP_GET, &enable); > + if (ret) > + return ret; > + return enable; > +} > + > +static int buck_set_enable(struct udevice *dev, bool enable) > +{ > + return s2mps11_buck_enable(dev, PMIC_OP_SET, &enable); > +} > + > +static int buck_get_mode(struct udevice *dev) > +{ > + int mode; > + int ret; > + > + ret = s2mps11_buck_mode(dev, PMIC_OP_GET, &mode); > + if (ret) > + return ret; > + > + return mode; > +} > + > +static int buck_set_mode(struct udevice *dev, int mode) > +{ > + return s2mps11_buck_mode(dev, PMIC_OP_SET, &mode); > +} > + > +static int s2mps11_buck_probe(struct udevice *dev) > +{ > + struct dm_regulator_uclass_platdata *uc_pdata; > + > + uc_pdata = dev_get_uclass_platdata(dev); > + > + uc_pdata->type = REGULATOR_TYPE_BUCK; > + uc_pdata->mode = s2mps11_buck_modes; > + uc_pdata->mode_count = ARRAY_SIZE(s2mps11_buck_modes); > + > + return 0; > +} > + > +static const struct dm_regulator_ops s2mps11_buck_ops = { > + .get_value = buck_get_value, > + .set_value = buck_set_value, > + .get_enable = buck_get_enable, > + .set_enable = buck_set_enable, > + .get_mode = buck_get_mode, > + .set_mode = buck_set_mode, > +}; > + > +U_BOOT_DRIVER(s2mps11_buck) = { > + .name = S2MPS11_BUCK_DRIVER, > + .id = UCLASS_REGULATOR, > + .ops = &s2mps11_buck_ops, > + .probe = s2mps11_buck_probe, > +}; > + > +static int s2mps11_ldo_hex2volt(int ldo, int hex) > +{ > + unsigned int uV = 0; > + > + if (hex > S2MPS11_LDO_VOLT_MAX_HEX) { > + pr_err("Value: %#x is wrong for LDO%d", hex, ldo); > + return -EINVAL; > + } > + > + switch (ldo) { > + case 1: > + case 6: > + case 11: > + case 22: > + case 23: > + uV = hex * S2MPS11_LDO_STEP + S2MPS11_LDO_UV_MIN; > + break; > + default: > + uV = hex * S2MPS11_LDO_STEP * 2 + S2MPS11_LDO_UV_MIN; > + break; > + } > + > + return uV; > +} > + > +static int s2mps11_ldo_volt2hex(int ldo, int uV) > +{ > + int hex = 0; > + > + switch (ldo) { > + case 1: > + case 6: > + case 11: > + case 22: > + case 23: > + hex = (uV - S2MPS11_LDO_UV_MIN) / S2MPS11_LDO_STEP; > + break; > + default: > + hex = (uV - S2MPS11_LDO_UV_MIN) / (S2MPS11_LDO_STEP * 2); > + break; > + } > + > + if (hex >= 0 && hex <= S2MPS11_LDO_VOLT_MAX_HEX) > + return hex; > + > + pr_err("Value: %d uV is wrong for LDO%d", uV, ldo); > + return -EINVAL; > + > + return 0; > +} > + > +static int s2mps11_ldo_val(struct udevice *dev, int op, int *uV) > +{ > + unsigned int addr; > + unsigned char val; > + int hex, ldo, ret; > + > + ldo = dev->driver_data; > + if (ldo < 1 || ldo > S2MPS11_LDO_NUM) { > + pr_err("Wrong ldo number: %d\n", ldo); > + return -EINVAL; > + } > + > + addr = S2MPS11_REG_L1CTRL + ldo - 1; > + > + ret = pmic_read(dev->parent, addr, &val, 1); > + if (ret) > + return ret; > + > + if (op == PMIC_OP_GET) { > + *uV = 0; > + val &= S2MPS11_LDO_VOLT_MASK; > + ret = s2mps11_ldo_hex2volt(ldo, val); > + if (ret < 0) > + return ret; > + > + *uV = ret; > + return 0; > + } > + > + hex = s2mps11_ldo_volt2hex(ldo, *uV); > + if (hex < 0) > + return hex; > + > + val &= ~S2MPS11_LDO_VOLT_MASK; > + val |= hex; > + ret = pmic_write(dev->parent, addr, &val, 1); > + > + return ret; > +} > + > +static int s2mps11_ldo_mode(struct udevice *dev, int op, int *opmode) > +{ > + unsigned int addr, mode; > + unsigned char val; > + int ldo, ret; > + > + ldo = dev->driver_data; > + if (ldo < 1 || ldo > S2MPS11_LDO_NUM) { > + pr_err("Wrong ldo number: %d\n", ldo); > + return -EINVAL; > + } > + addr = S2MPS11_REG_L1CTRL + ldo - 1; > + > + ret = pmic_read(dev->parent, addr, &val, 1); > + if (ret) > + return ret; > + > + if (op == PMIC_OP_GET) { > + val &= (S2MPS11_LDO_MODE_MASK << S2MPS11_LDO_MODE_SHIFT); > + switch (val) { > + case S2MPS11_LDO_MODE_OFF: > + *opmode = OP_OFF; > + break; > + case S2MPS11_LDO_MODE_STANDBY: > + *opmode = OP_STANDBY; > + break; > + case S2MPS11_LDO_MODE_STANDBY_LPM: > + *opmode = OP_STANDBY_LPM; > + break; > + case S2MPS11_LDO_MODE_ON: > + *opmode = OP_ON; > + break; > + default: > + return -EINVAL; > + } > + return 0; > + } > + > + switch (*opmode) { > + case OP_OFF: > + mode = S2MPS11_LDO_MODE_OFF; > + break; > + case OP_STANDBY: > + mode = S2MPS11_LDO_MODE_STANDBY; > + break; > + case OP_STANDBY_LPM: > + mode = S2MPS11_LDO_MODE_STANDBY_LPM; > + break; > + case OP_ON: > + mode = S2MPS11_LDO_MODE_ON; > + break; > + default: > + pr_err("Wrong mode: %d for ldo: %d\n", *opmode, ldo); > + return -EINVAL; > + } > + > + val &= ~(S2MPS11_LDO_MODE_MASK << S2MPS11_LDO_MODE_SHIFT); > + val |= mode; > + ret = pmic_write(dev->parent, addr, &val, 1); > + > + return ret; > +} > + > +static int s2mps11_ldo_enable(struct udevice *dev, int op, bool *enable) > +{ > + int ret, on_off; > + > + if (op == PMIC_OP_GET) { > + ret = s2mps11_ldo_mode(dev, op, &on_off); > + if (ret) > + return ret; > + switch (on_off) { > + case OP_OFF: > + *enable = false; > + break; > + case OP_ON: > + *enable = true; > + break; > + default: > + return -EINVAL; > + } > + } else if (op == PMIC_OP_SET) { > + if (*enable) > + on_off = OP_ON; > + else > + on_off = OP_OFF; > + > + ret = s2mps11_ldo_mode(dev, op, &on_off); > + if (ret) > + return ret; > + } > + > + return 0; > +} > + > +static int ldo_get_value(struct udevice *dev) > +{ > + int uV; > + int ret; > + > + ret = s2mps11_ldo_val(dev, PMIC_OP_GET, &uV); > + if (ret) > + return ret; > + > + return uV; > +} > + > +static int ldo_set_value(struct udevice *dev, int uV) > +{ > + return s2mps11_ldo_val(dev, PMIC_OP_SET, &uV); > +} > + > +static int ldo_get_enable(struct udevice *dev) > +{ > + bool enable = false; > + int ret; > + > + ret = s2mps11_ldo_enable(dev, PMIC_OP_GET, &enable); > + if (ret) > + return ret; > + return enable; > +} > + > +static int ldo_set_enable(struct udevice *dev, bool enable) > +{ > + return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable); > +} > + > +static int ldo_get_mode(struct udevice *dev) > +{ > + int mode, ret; > + > + ret = s2mps11_ldo_mode(dev, PMIC_OP_GET, &mode); > + if (ret) > + return ret; > + return mode; > +} > + > +static int ldo_set_mode(struct udevice *dev, int mode) > +{ > + return s2mps11_ldo_mode(dev, PMIC_OP_SET, &mode); > +} > + > +static int s2mps11_ldo_probe(struct udevice *dev) > +{ > + struct dm_regulator_uclass_platdata *uc_pdata; > + > + uc_pdata = dev_get_uclass_platdata(dev); > + uc_pdata->type = REGULATOR_TYPE_LDO; > + uc_pdata->mode = s2mps11_ldo_modes; > + uc_pdata->mode_count = ARRAY_SIZE(s2mps11_ldo_modes); > + > + return 0; > +} > + > +static const struct dm_regulator_ops s2mps11_ldo_ops = { > + .get_value = ldo_get_value, > + .set_value = ldo_set_value, > + .get_enable = ldo_get_enable, > + .set_enable = ldo_set_enable, > + .get_mode = ldo_get_mode, > + .set_mode = ldo_set_mode, > +}; > + > +U_BOOT_DRIVER(s2mps11_ldo) = { > + .name = S2MPS11_LDO_DRIVER, > + .id = UCLASS_REGULATOR, > + .ops = &s2mps11_ldo_ops, > + .probe = s2mps11_ldo_probe, > +}; > diff --git a/include/power/s2mps11.h b/include/power/s2mps11.h > index 5da47198a4..22b38fff70 100644 > --- a/include/power/s2mps11.h > +++ b/include/power/s2mps11.h > @@ -106,4 +106,59 @@ enum s2mps11_reg { > > #define S2MPS11_LDO26_ENABLE 0xec > > +#define S2MPS11_LDO_NUM 26 > +#define S2MPS11_BUCK_NUM 10 > + > +/* Driver name */ > +#define S2MPS11_BUCK_DRIVER "s2mps11_buck" > +#define S2MPS11_OF_BUCK_PREFIX "BUCK" > +#define S2MPS11_LDO_DRIVER "s2mps11_ldo" > +#define S2MPS11_OF_LDO_PREFIX "LDO" > + > +/* BUCK */ > +#define S2MPS11_BUCK_VOLT_MASK 0xff > +#define S2MPS11_BUCK9_VOLT_MASK 0x1f > + > +#define S2MPS11_BUCK_LSTEP 6250 > +#define S2MPS11_BUCK_HSTEP 12500 > +#define S2MPS11_BUCK9_STEP 25000 > + > +#define S2MPS11_BUCK_UV_MIN 600000 > +#define S2MPS11_BUCK_UV_HMIN 750000 > +#define S2MPS11_BUCK9_UV_MIN 1400000 > + > +#define S2MPS11_BUCK_VOLT_MAX_HEX 0xA0 > +#define S2MPS11_BUCK5_VOLT_MAX_HEX 0xDF > +#define S2MPS11_BUCK7_8_10_VOLT_MAX_HEX 0xDC > +#define S2MPS11_BUCK9_VOLT_MAX_HEX 0x5F > + > +#define S2MPS11_BUCK_MODE_SHIFT 6 > +#define S2MPS11_BUCK_MODE_MASK (0x3) > +#define S2MPS11_BUCK_MODE_OFF (0x0 << 6) > +#define S2MPS11_BUCK_MODE_STANDBY (0x1 << 6) > +#define S2MPS11_BUCK_MODE_ON (0x3 << 6) > + > +/* LDO */ > +#define S2MPS11_LDO_VOLT_MASK 0x3F > +#define S2MPS11_LDO_VOLT_MAX_HEX 0x3F > + > +#define S2MPS11_LDO_STEP 25000 > +#define S2MPS11_LDO_UV_MIN 800000 > + > +#define S2MPS11_LDO_MODE_MASK 0x3 > +#define S2MPS11_LDO_MODE_SHIFT 6 > + > +#define S2MPS11_LDO_MODE_OFF (0x0 << 6) > +#define S2MPS11_LDO_MODE_STANDBY (0x1 << 6) > +#define S2MPS11_LDO_MODE_STANDBY_LPM (0x2 << 6) > +#define S2MPS11_LDO_MODE_ON (0x3 << 6) > + > +enum { > + OP_OFF = 0, > + OP_LPM, > + OP_STANDBY, > + OP_STANDBY_LPM, > + OP_ON, > +}; > + > #endif > -- > 2.15.1 > Please add my. Tested-by: Anand Moon <linux.amoon@gmail.com> Best Regards -Anand
On 01/24/2018 01:01 AM, Anand Moon wrote: > Hi JaeHoon Chung, > > On 16 January 2018 at 12:03, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> exynos5422 has the s2mps11 PMIC. >> s2mps11 pmic has the 10-BUCK and 38-LDO regulators. >> Each IP and devices in exynos5422 can be controlled by each regulators. >> This patch is support for s2mps11 regulator driver. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> drivers/power/regulator/Kconfig | 8 + >> drivers/power/regulator/Makefile | 1 + >> drivers/power/regulator/s2mps11_regulator.c | 597 ++++++++++++++++++++++++++++ >> include/power/s2mps11.h | 55 +++ >> 4 files changed, 661 insertions(+) >> create mode 100644 drivers/power/regulator/s2mps11_regulator.c >> [..snip..] > > Please add my. > Tested-by: Anand Moon <linux.amoon@gmail.com> Applied to u-boot-mmc. Best Regards, Jaehoon Chung > > Best Regards > -Anand > > >
diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig index 26fb9368ea..5b4ac10462 100644 --- a/drivers/power/regulator/Kconfig +++ b/drivers/power/regulator/Kconfig @@ -101,6 +101,14 @@ config REGULATOR_RK8XX by the PMIC device. This driver is controlled by a device tree node which includes voltage limits. +config DM_REGULATOR_S2MPS11 + bool "Enable driver for S2MPS11 regulator" + depends on DM_REGULATOR && PMIC_S2MPS11 + ---help--- + This enables implementation of driver-model regulator uclass + features for REGULATOR S2MPS11. + The driver implements get/set api for: value and enable. + config REGULATOR_S5M8767 bool "Enable support for S5M8767 regulator" depends on DM_REGULATOR && PMIC_S5M8767 diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile index 7a2e76dc82..728e8144de 100644 --- a/drivers/power/regulator/Makefile +++ b/drivers/power/regulator/Makefile @@ -14,6 +14,7 @@ obj-$(CONFIG_REGULATOR_PWM) += pwm_regulator.o obj-$(CONFIG_$(SPL_)DM_REGULATOR_FIXED) += fixed.o obj-$(CONFIG_$(SPL_)DM_REGULATOR_GPIO) += gpio-regulator.o obj-$(CONFIG_REGULATOR_RK8XX) += rk8xx.o +obj-$(CONFIG_DM_REGULATOR_S2MPS11) += s2mps11_regulator.o obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o obj-$(CONFIG_DM_REGULATOR_SANDBOX) += sandbox.o obj-$(CONFIG_REGULATOR_TPS65090) += tps65090_regulator.o diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c new file mode 100644 index 0000000000..3af20e60dd --- /dev/null +++ b/drivers/power/regulator/s2mps11_regulator.c @@ -0,0 +1,597 @@ +/* + * Copyright (C) 2018 Samsung Electronics + * Jaehoon Chung <jh80.chung@samsung.com> + * + * SPDX-License-Identifier: GPL-2.0 + */ + +#include <common.h> +#include <fdtdec.h> +#include <errno.h> +#include <dm.h> +#include <i2c.h> +#include <power/pmic.h> +#include <power/regulator.h> +#include <power/s2mps11.h> + +DECLARE_GLOBAL_DATA_PTR; + +#define MODE(_id, _val, _name) { \ + .id = _id, \ + .register_value = _val, \ + .name = _name, \ +} + +/* BUCK : 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 */ +static struct dm_regulator_mode s2mps11_buck_modes[] = { + MODE(OP_OFF, S2MPS11_BUCK_MODE_OFF, "OFF"), + MODE(OP_STANDBY, S2MPS11_BUCK_MODE_STANDBY, "ON/OFF"), + MODE(OP_ON, S2MPS11_BUCK_MODE_STANDBY, "ON"), +}; + +static struct dm_regulator_mode s2mps11_ldo_modes[] = { + MODE(OP_OFF, S2MPS11_LDO_MODE_OFF, "OFF"), + MODE(OP_STANDBY, S2MPS11_LDO_MODE_STANDBY, "ON/OFF"), + MODE(OP_STANDBY_LPM, S2MPS11_LDO_MODE_STANDBY_LPM, "ON/LPM"), + MODE(OP_ON, S2MPS11_LDO_MODE_ON, "ON"), +}; + +static const char s2mps11_buck_ctrl[] = { + 0xff, 0x25, 0x27, 0x29, 0x2b, 0x2d, 0x33, 0x35, 0x37, 0x39, 0x3b +}; + +static const char s2mps11_buck_out[] = { + 0xff, 0x26, 0x28, 0x2a, 0x2c, 0x2f, 0x34, 0x36, 0x38, 0x3a, 0x3c +}; + +static int s2mps11_buck_hex2volt(int buck, int hex) +{ + unsigned int uV = 0; + + if (hex < 0) + goto bad; + + switch (buck) { + case 7: + case 8: + case 10: + if (hex > S2MPS11_BUCK7_8_10_VOLT_MAX_HEX) + goto bad; + + uV = hex * S2MPS11_BUCK_HSTEP + S2MPS11_BUCK_UV_HMIN; + break; + case 9: + if (hex > S2MPS11_BUCK9_VOLT_MAX_HEX) + goto bad; + uV = hex * S2MPS11_BUCK9_STEP * 2 + S2MPS11_BUCK9_UV_MIN; + break; + default: + if (buck == 5 && hex > S2MPS11_BUCK5_VOLT_MAX_HEX) + goto bad; + else if (buck != 5 && hex > S2MPS11_BUCK_VOLT_MAX_HEX) + goto bad; + + uV = hex * S2MPS11_BUCK_LSTEP + S2MPS11_BUCK_UV_MIN; + break; + } + + return uV; +bad: + pr_err("Value: %#x is wrong for BUCK%d", hex, buck); + return -EINVAL; +} + +static int s2mps11_buck_volt2hex(int buck, int uV) +{ + int hex; + + switch (buck) { + case 7: + case 8: + case 10: + hex = (uV - S2MPS11_BUCK_UV_HMIN) / S2MPS11_BUCK_HSTEP; + if (hex > S2MPS11_BUCK7_8_10_VOLT_MAX_HEX) + goto bad; + + break; + case 9: + hex = (uV - S2MPS11_BUCK9_UV_MIN) / S2MPS11_BUCK9_STEP; + if (hex > S2MPS11_BUCK9_VOLT_MAX_HEX) + goto bad; + break; + default: + hex = (uV - S2MPS11_BUCK_UV_MIN) / S2MPS11_BUCK_LSTEP; + if (buck == 5 && hex > S2MPS11_BUCK5_VOLT_MAX_HEX) + goto bad; + else if (buck != 5 && hex > S2MPS11_BUCK_VOLT_MAX_HEX) + goto bad; + break; + }; + + if (hex >= 0) + return hex; + +bad: + pr_err("Value: %d uV is wrong for BUCK%d", uV, buck); + return -EINVAL; +} + +static int s2mps11_buck_val(struct udevice *dev, int op, int *uV) +{ + int hex, buck, ret; + u32 mask, addr; + u8 val; + + buck = dev->driver_data; + if (buck < 1 || buck > S2MPS11_BUCK_NUM) { + pr_err("Wrong buck number: %d\n", buck); + return -EINVAL; + } + + if (op == PMIC_OP_GET) + *uV = 0; + + addr = s2mps11_buck_out[buck]; + + switch (buck) { + case 9: + mask = S2MPS11_BUCK9_VOLT_MASK; + break; + default: + mask = S2MPS11_BUCK_VOLT_MASK; + break; + } + + ret = pmic_read(dev->parent, addr, &val, 1); + if (ret) + return ret; + + if (op == PMIC_OP_GET) { + val &= mask; + ret = s2mps11_buck_hex2volt(buck, val); + if (ret < 0) + return ret; + *uV = ret; + return 0; + } + + hex = s2mps11_buck_volt2hex(buck, *uV); + if (hex < 0) + return hex; + + val &= ~mask; + val |= hex; + ret = pmic_write(dev->parent, addr, &val, 1); + + return ret; +} + +static int s2mps11_buck_mode(struct udevice *dev, int op, int *opmode) +{ + unsigned int addr, mode; + unsigned char val; + int buck, ret; + + buck = dev->driver_data; + if (buck < 1 || buck > S2MPS11_BUCK_NUM) { + pr_err("Wrong buck number: %d\n", buck); + return -EINVAL; + } + + addr = s2mps11_buck_ctrl[buck]; + + ret = pmic_read(dev->parent, addr, &val, 1); + if (ret) + return ret; + + if (op == PMIC_OP_GET) { + val &= (S2MPS11_BUCK_MODE_MASK << S2MPS11_BUCK_MODE_SHIFT); + switch (val) { + case S2MPS11_BUCK_MODE_OFF: + *opmode = OP_OFF; + break; + case S2MPS11_BUCK_MODE_STANDBY: + *opmode = OP_STANDBY; + break; + case S2MPS11_BUCK_MODE_ON: + *opmode = OP_ON; + break; + default: + return -EINVAL; + } + return 0; + } + + switch (*opmode) { + case OP_OFF: + mode = S2MPS11_BUCK_MODE_OFF; + break; + case OP_STANDBY: + mode = S2MPS11_BUCK_MODE_STANDBY; + break; + case OP_ON: + mode = S2MPS11_BUCK_MODE_ON; + break; + default: + pr_err("Wrong mode: %d for buck: %d\n", *opmode, buck); + return -EINVAL; + } + + val &= ~(S2MPS11_BUCK_MODE_MASK << S2MPS11_BUCK_MODE_SHIFT); + val |= mode; + ret = pmic_write(dev->parent, addr, &val, 1); + + return ret; +} + +static int s2mps11_buck_enable(struct udevice *dev, int op, bool *enable) +{ + int ret, on_off; + + if (op == PMIC_OP_GET) { + ret = s2mps11_buck_mode(dev, op, &on_off); + if (ret) + return ret; + switch (on_off) { + case OP_OFF: + *enable = false; + break; + case OP_ON: + *enable = true; + break; + default: + return -EINVAL; + } + } else if (op == PMIC_OP_SET) { + if (*enable) + on_off = OP_ON; + else + on_off = OP_OFF; + + ret = s2mps11_buck_mode(dev, op, &on_off); + if (ret) + return ret; + } + + return 0; +} + +static int buck_get_value(struct udevice *dev) +{ + int uV; + int ret; + + ret = s2mps11_buck_val(dev, PMIC_OP_GET, &uV); + if (ret) + return ret; + return uV; +} + +static int buck_set_value(struct udevice *dev, int uV) +{ + return s2mps11_buck_val(dev, PMIC_OP_SET, &uV); +} + +static int buck_get_enable(struct udevice *dev) +{ + bool enable = false; + int ret; + + ret = s2mps11_buck_enable(dev, PMIC_OP_GET, &enable); + if (ret) + return ret; + return enable; +} + +static int buck_set_enable(struct udevice *dev, bool enable) +{ + return s2mps11_buck_enable(dev, PMIC_OP_SET, &enable); +} + +static int buck_get_mode(struct udevice *dev) +{ + int mode; + int ret; + + ret = s2mps11_buck_mode(dev, PMIC_OP_GET, &mode); + if (ret) + return ret; + + return mode; +} + +static int buck_set_mode(struct udevice *dev, int mode) +{ + return s2mps11_buck_mode(dev, PMIC_OP_SET, &mode); +} + +static int s2mps11_buck_probe(struct udevice *dev) +{ + struct dm_regulator_uclass_platdata *uc_pdata; + + uc_pdata = dev_get_uclass_platdata(dev); + + uc_pdata->type = REGULATOR_TYPE_BUCK; + uc_pdata->mode = s2mps11_buck_modes; + uc_pdata->mode_count = ARRAY_SIZE(s2mps11_buck_modes); + + return 0; +} + +static const struct dm_regulator_ops s2mps11_buck_ops = { + .get_value = buck_get_value, + .set_value = buck_set_value, + .get_enable = buck_get_enable, + .set_enable = buck_set_enable, + .get_mode = buck_get_mode, + .set_mode = buck_set_mode, +}; + +U_BOOT_DRIVER(s2mps11_buck) = { + .name = S2MPS11_BUCK_DRIVER, + .id = UCLASS_REGULATOR, + .ops = &s2mps11_buck_ops, + .probe = s2mps11_buck_probe, +}; + +static int s2mps11_ldo_hex2volt(int ldo, int hex) +{ + unsigned int uV = 0; + + if (hex > S2MPS11_LDO_VOLT_MAX_HEX) { + pr_err("Value: %#x is wrong for LDO%d", hex, ldo); + return -EINVAL; + } + + switch (ldo) { + case 1: + case 6: + case 11: + case 22: + case 23: + uV = hex * S2MPS11_LDO_STEP + S2MPS11_LDO_UV_MIN; + break; + default: + uV = hex * S2MPS11_LDO_STEP * 2 + S2MPS11_LDO_UV_MIN; + break; + } + + return uV; +} + +static int s2mps11_ldo_volt2hex(int ldo, int uV) +{ + int hex = 0; + + switch (ldo) { + case 1: + case 6: + case 11: + case 22: + case 23: + hex = (uV - S2MPS11_LDO_UV_MIN) / S2MPS11_LDO_STEP; + break; + default: + hex = (uV - S2MPS11_LDO_UV_MIN) / (S2MPS11_LDO_STEP * 2); + break; + } + + if (hex >= 0 && hex <= S2MPS11_LDO_VOLT_MAX_HEX) + return hex; + + pr_err("Value: %d uV is wrong for LDO%d", uV, ldo); + return -EINVAL; + + return 0; +} + +static int s2mps11_ldo_val(struct udevice *dev, int op, int *uV) +{ + unsigned int addr; + unsigned char val; + int hex, ldo, ret; + + ldo = dev->driver_data; + if (ldo < 1 || ldo > S2MPS11_LDO_NUM) { + pr_err("Wrong ldo number: %d\n", ldo); + return -EINVAL; + } + + addr = S2MPS11_REG_L1CTRL + ldo - 1; + + ret = pmic_read(dev->parent, addr, &val, 1); + if (ret) + return ret; + + if (op == PMIC_OP_GET) { + *uV = 0; + val &= S2MPS11_LDO_VOLT_MASK; + ret = s2mps11_ldo_hex2volt(ldo, val); + if (ret < 0) + return ret; + + *uV = ret; + return 0; + } + + hex = s2mps11_ldo_volt2hex(ldo, *uV); + if (hex < 0) + return hex; + + val &= ~S2MPS11_LDO_VOLT_MASK; + val |= hex; + ret = pmic_write(dev->parent, addr, &val, 1); + + return ret; +} + +static int s2mps11_ldo_mode(struct udevice *dev, int op, int *opmode) +{ + unsigned int addr, mode; + unsigned char val; + int ldo, ret; + + ldo = dev->driver_data; + if (ldo < 1 || ldo > S2MPS11_LDO_NUM) { + pr_err("Wrong ldo number: %d\n", ldo); + return -EINVAL; + } + addr = S2MPS11_REG_L1CTRL + ldo - 1; + + ret = pmic_read(dev->parent, addr, &val, 1); + if (ret) + return ret; + + if (op == PMIC_OP_GET) { + val &= (S2MPS11_LDO_MODE_MASK << S2MPS11_LDO_MODE_SHIFT); + switch (val) { + case S2MPS11_LDO_MODE_OFF: + *opmode = OP_OFF; + break; + case S2MPS11_LDO_MODE_STANDBY: + *opmode = OP_STANDBY; + break; + case S2MPS11_LDO_MODE_STANDBY_LPM: + *opmode = OP_STANDBY_LPM; + break; + case S2MPS11_LDO_MODE_ON: + *opmode = OP_ON; + break; + default: + return -EINVAL; + } + return 0; + } + + switch (*opmode) { + case OP_OFF: + mode = S2MPS11_LDO_MODE_OFF; + break; + case OP_STANDBY: + mode = S2MPS11_LDO_MODE_STANDBY; + break; + case OP_STANDBY_LPM: + mode = S2MPS11_LDO_MODE_STANDBY_LPM; + break; + case OP_ON: + mode = S2MPS11_LDO_MODE_ON; + break; + default: + pr_err("Wrong mode: %d for ldo: %d\n", *opmode, ldo); + return -EINVAL; + } + + val &= ~(S2MPS11_LDO_MODE_MASK << S2MPS11_LDO_MODE_SHIFT); + val |= mode; + ret = pmic_write(dev->parent, addr, &val, 1); + + return ret; +} + +static int s2mps11_ldo_enable(struct udevice *dev, int op, bool *enable) +{ + int ret, on_off; + + if (op == PMIC_OP_GET) { + ret = s2mps11_ldo_mode(dev, op, &on_off); + if (ret) + return ret; + switch (on_off) { + case OP_OFF: + *enable = false; + break; + case OP_ON: + *enable = true; + break; + default: + return -EINVAL; + } + } else if (op == PMIC_OP_SET) { + if (*enable) + on_off = OP_ON; + else + on_off = OP_OFF; + + ret = s2mps11_ldo_mode(dev, op, &on_off); + if (ret) + return ret; + } + + return 0; +} + +static int ldo_get_value(struct udevice *dev) +{ + int uV; + int ret; + + ret = s2mps11_ldo_val(dev, PMIC_OP_GET, &uV); + if (ret) + return ret; + + return uV; +} + +static int ldo_set_value(struct udevice *dev, int uV) +{ + return s2mps11_ldo_val(dev, PMIC_OP_SET, &uV); +} + +static int ldo_get_enable(struct udevice *dev) +{ + bool enable = false; + int ret; + + ret = s2mps11_ldo_enable(dev, PMIC_OP_GET, &enable); + if (ret) + return ret; + return enable; +} + +static int ldo_set_enable(struct udevice *dev, bool enable) +{ + return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable); +} + +static int ldo_get_mode(struct udevice *dev) +{ + int mode, ret; + + ret = s2mps11_ldo_mode(dev, PMIC_OP_GET, &mode); + if (ret) + return ret; + return mode; +} + +static int ldo_set_mode(struct udevice *dev, int mode) +{ + return s2mps11_ldo_mode(dev, PMIC_OP_SET, &mode); +} + +static int s2mps11_ldo_probe(struct udevice *dev) +{ + struct dm_regulator_uclass_platdata *uc_pdata; + + uc_pdata = dev_get_uclass_platdata(dev); + uc_pdata->type = REGULATOR_TYPE_LDO; + uc_pdata->mode = s2mps11_ldo_modes; + uc_pdata->mode_count = ARRAY_SIZE(s2mps11_ldo_modes); + + return 0; +} + +static const struct dm_regulator_ops s2mps11_ldo_ops = { + .get_value = ldo_get_value, + .set_value = ldo_set_value, + .get_enable = ldo_get_enable, + .set_enable = ldo_set_enable, + .get_mode = ldo_get_mode, + .set_mode = ldo_set_mode, +}; + +U_BOOT_DRIVER(s2mps11_ldo) = { + .name = S2MPS11_LDO_DRIVER, + .id = UCLASS_REGULATOR, + .ops = &s2mps11_ldo_ops, + .probe = s2mps11_ldo_probe, +}; diff --git a/include/power/s2mps11.h b/include/power/s2mps11.h index 5da47198a4..22b38fff70 100644 --- a/include/power/s2mps11.h +++ b/include/power/s2mps11.h @@ -106,4 +106,59 @@ enum s2mps11_reg { #define S2MPS11_LDO26_ENABLE 0xec +#define S2MPS11_LDO_NUM 26 +#define S2MPS11_BUCK_NUM 10 + +/* Driver name */ +#define S2MPS11_BUCK_DRIVER "s2mps11_buck" +#define S2MPS11_OF_BUCK_PREFIX "BUCK" +#define S2MPS11_LDO_DRIVER "s2mps11_ldo" +#define S2MPS11_OF_LDO_PREFIX "LDO" + +/* BUCK */ +#define S2MPS11_BUCK_VOLT_MASK 0xff +#define S2MPS11_BUCK9_VOLT_MASK 0x1f + +#define S2MPS11_BUCK_LSTEP 6250 +#define S2MPS11_BUCK_HSTEP 12500 +#define S2MPS11_BUCK9_STEP 25000 + +#define S2MPS11_BUCK_UV_MIN 600000 +#define S2MPS11_BUCK_UV_HMIN 750000 +#define S2MPS11_BUCK9_UV_MIN 1400000 + +#define S2MPS11_BUCK_VOLT_MAX_HEX 0xA0 +#define S2MPS11_BUCK5_VOLT_MAX_HEX 0xDF +#define S2MPS11_BUCK7_8_10_VOLT_MAX_HEX 0xDC +#define S2MPS11_BUCK9_VOLT_MAX_HEX 0x5F + +#define S2MPS11_BUCK_MODE_SHIFT 6 +#define S2MPS11_BUCK_MODE_MASK (0x3) +#define S2MPS11_BUCK_MODE_OFF (0x0 << 6) +#define S2MPS11_BUCK_MODE_STANDBY (0x1 << 6) +#define S2MPS11_BUCK_MODE_ON (0x3 << 6) + +/* LDO */ +#define S2MPS11_LDO_VOLT_MASK 0x3F +#define S2MPS11_LDO_VOLT_MAX_HEX 0x3F + +#define S2MPS11_LDO_STEP 25000 +#define S2MPS11_LDO_UV_MIN 800000 + +#define S2MPS11_LDO_MODE_MASK 0x3 +#define S2MPS11_LDO_MODE_SHIFT 6 + +#define S2MPS11_LDO_MODE_OFF (0x0 << 6) +#define S2MPS11_LDO_MODE_STANDBY (0x1 << 6) +#define S2MPS11_LDO_MODE_STANDBY_LPM (0x2 << 6) +#define S2MPS11_LDO_MODE_ON (0x3 << 6) + +enum { + OP_OFF = 0, + OP_LPM, + OP_STANDBY, + OP_STANDBY_LPM, + OP_ON, +}; + #endif
exynos5422 has the s2mps11 PMIC. s2mps11 pmic has the 10-BUCK and 38-LDO regulators. Each IP and devices in exynos5422 can be controlled by each regulators. This patch is support for s2mps11 regulator driver. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/power/regulator/Kconfig | 8 + drivers/power/regulator/Makefile | 1 + drivers/power/regulator/s2mps11_regulator.c | 597 ++++++++++++++++++++++++++++ include/power/s2mps11.h | 55 +++ 4 files changed, 661 insertions(+) create mode 100644 drivers/power/regulator/s2mps11_regulator.c