| Message ID | 20180115154649.9551-1-ezequiel@vanguardiasur.com.ar |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [U-Boot,1/2] zynq: board: Remove checkboard() | expand |
On 15.1.2018 16:46, Ezequiel Garcia wrote: > Currently we are showing silicon version as board info, > which should be part of the CPU info display. > > This commit removes the current checkboard implementation, > and lets the generic show_board_info() show the DT 'model' > property. > > CPU and silicon information will be added in a follow-up patch. I can't see the reason to be removed and add in the next patch. Not a problem with removing checkboard entirely but I would prefer if you use move silicon version first and then remove this function that silicon version will be shown all the time. M > > Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > --- > board/xilinx/zynq/board.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c > index e59038106aa6..5785ad369fa0 100644 > --- a/board/xilinx/zynq/board.c > +++ b/board/xilinx/zynq/board.c > @@ -109,22 +109,6 @@ int board_late_init(void) > return 0; > } > > -#ifdef CONFIG_DISPLAY_BOARDINFO > -int checkboard(void) > -{ > - u32 version = zynq_get_silicon_version(); > - > - version <<= 1; > - if (version > (PCW_SILICON_VERSION_3 << 1)) > - version += 1; > - > - puts("Board: Xilinx Zynq\n"); > - printf("Silicon: v%d.%d\n", version >> 1, version & 1); > - > - return 0; > -} > -#endif > - > int zynq_board_read_rom_ethaddr(unsigned char *ethaddr) > { > #if defined(CONFIG_ZYNQ_GEM_EEPROM_ADDR) && \ >
diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c index e59038106aa6..5785ad369fa0 100644 --- a/board/xilinx/zynq/board.c +++ b/board/xilinx/zynq/board.c @@ -109,22 +109,6 @@ int board_late_init(void) return 0; } -#ifdef CONFIG_DISPLAY_BOARDINFO -int checkboard(void) -{ - u32 version = zynq_get_silicon_version(); - - version <<= 1; - if (version > (PCW_SILICON_VERSION_3 << 1)) - version += 1; - - puts("Board: Xilinx Zynq\n"); - printf("Silicon: v%d.%d\n", version >> 1, version & 1); - - return 0; -} -#endif - int zynq_board_read_rom_ethaddr(unsigned char *ethaddr) { #if defined(CONFIG_ZYNQ_GEM_EEPROM_ADDR) && \
Currently we are showing silicon version as board info, which should be part of the CPU info display. This commit removes the current checkboard implementation, and lets the generic show_board_info() show the DT 'model' property. CPU and silicon information will be added in a follow-up patch. Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> --- board/xilinx/zynq/board.c | 16 ---------------- 1 file changed, 16 deletions(-)