| Message ID | 20180115031401.19577-5-j.neuschaefer@gmx.net |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Nintendo Wii GPIO driver | expand |
On Mon, Jan 15, 2018 at 4:13 AM, Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
maybe some small blurb here?
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
It looks good, very standard bindings.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 15, 2018 at 04:13:59AM +0100, Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > .../bindings/gpio/nintendo,hollywood-gpio.txt | 27 ++++++++++++++++++++++ > .../devicetree/bindings/powerpc/nintendo/wii.txt | 9 +------- > 2 files changed, 28 insertions(+), 8 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt > > diff --git a/Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt b/Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt > new file mode 100644 > index 000000000000..a97ce6b5b724 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt > @@ -0,0 +1,27 @@ > +Nintendo Wii (Hollywood) GPIO controller > + > +Required properties: > +- compatible: "nintendo,hollywood-gpio > +- reg: Physical base address and length of the controller's registers. > +- gpio-controller: Marks the device node as a GPIO controller. > +- #gpio-cells: Should be <2>. The first cell is the pin number and the > + second cell is used to specify optional parameters: > + - bit 0 specifies polarity (0 for normal, 1 for inverted). > + > +Optional properties: > +- ngpios: see Documentation/devicetree/bindings/gpio/gpio.txt > +- interrupt-controller: Marks the device node as an interrupt controller. > +- #interrupt-cells: Should be two. > +- interrupts: Interrupt specifier for the controller's Broadway (PowerPC) > + interrupt. > +- interrupt-parent: phandle of the parent interrupt controller. > + > +Example: > + > + GPIO: gpio@0d8000c0 { Drop the leading 0. With that, Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 19, 2018 at 05:05:21PM -0600, Rob Herring wrote: > On Mon, Jan 15, 2018 at 04:13:59AM +0100, Jonathan Neuschäfer wrote: > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > --- > > .../bindings/gpio/nintendo,hollywood-gpio.txt | 27 ++++++++++++++++++++++ > > .../devicetree/bindings/powerpc/nintendo/wii.txt | 9 +------- > > 2 files changed, 28 insertions(+), 8 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt [...] > > +Example: > > + > > + GPIO: gpio@0d8000c0 { > > Drop the leading 0. Ok, will do. > With that, > > Reviewed-by: Rob Herring <robh@kernel.org> Thanks. Jonathan Neuschäfer
diff --git a/Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt b/Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt new file mode 100644 index 000000000000..a97ce6b5b724 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt @@ -0,0 +1,27 @@ +Nintendo Wii (Hollywood) GPIO controller + +Required properties: +- compatible: "nintendo,hollywood-gpio +- reg: Physical base address and length of the controller's registers. +- gpio-controller: Marks the device node as a GPIO controller. +- #gpio-cells: Should be <2>. The first cell is the pin number and the + second cell is used to specify optional parameters: + - bit 0 specifies polarity (0 for normal, 1 for inverted). + +Optional properties: +- ngpios: see Documentation/devicetree/bindings/gpio/gpio.txt +- interrupt-controller: Marks the device node as an interrupt controller. +- #interrupt-cells: Should be two. +- interrupts: Interrupt specifier for the controller's Broadway (PowerPC) + interrupt. +- interrupt-parent: phandle of the parent interrupt controller. + +Example: + + GPIO: gpio@0d8000c0 { + #gpio-cells = <2>; + compatible = "nintendo,hollywood-gpio"; + reg = <0x0d8000c0 0x40>; + gpio-controller; + ngpios = <24>; + } diff --git a/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt b/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt index 36afa322b04b..a3dc4b9fa11a 100644 --- a/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt +++ b/Documentation/devicetree/bindings/powerpc/nintendo/wii.txt @@ -152,14 +152,7 @@ Nintendo Wii device tree 1.l) The General Purpose I/O (GPIO) controller node - Represents the dual access 32 GPIO controller interface. - - Required properties: - - - #gpio-cells : <2> - - compatible : should be "nintendo,hollywood-gpio" - - reg : should contain the IPC registers location and length - - gpio-controller + see Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt 1.m) The control node
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- .../bindings/gpio/nintendo,hollywood-gpio.txt | 27 ++++++++++++++++++++++ .../devicetree/bindings/powerpc/nintendo/wii.txt | 9 +------- 2 files changed, 28 insertions(+), 8 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/nintendo,hollywood-gpio.txt