Message ID | 20180104090744.67654-2-mika.westerberg@linux.intel.com |
---|---|
State | Changes Requested |
Delegated to: | Cyrille Pitchen |
Headers | show |
Series | [1/3] spi-nor: intel-spi: Prefer WREN over other write enables | expand |
Hi Mika, Le 04/01/2018 à 10:07, Mika Westerberg a écrit : > The driver is not meant for normal users at all but instead such users > who really know what they are doing and are able to build their own > kernel to enable it. Mark both driver Kconfig entries as dangerous to > make sure the driver is not accidentally enabled without understanding > possible issues in doing so. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/mtd/spi-nor/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > index 89da88e59121..f480b227a6b8 100644 > --- a/drivers/mtd/spi-nor/Kconfig > +++ b/drivers/mtd/spi-nor/Kconfig > @@ -90,7 +90,7 @@ config SPI_INTEL_SPI > tristate > > config SPI_INTEL_SPI_PCI > - tristate "Intel PCH/PCU SPI flash PCI driver" > + tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" I guess it might be even better and safer to add "default n" too, don't you agree? Adding only the "DANGEROUS" word would not prevent build scripts to select this driver when creating a kernel config from scratch. Best regards, Cyrille > depends on X86 && PCI > select SPI_INTEL_SPI > help > @@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI > will be called intel-spi-pci. > > config SPI_INTEL_SPI_PLATFORM > - tristate "Intel PCH/PCU SPI flash platform driver" > + tristate "Intel PCH/PCU SPI flash platform driver (DANGEROUS)" > depends on X86 > select SPI_INTEL_SPI > help >
On Sun, 7 Jan 2018 21:32:46 +0100 Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> wrote: > Hi Mika, > > Le 04/01/2018 à 10:07, Mika Westerberg a écrit : > > The driver is not meant for normal users at all but instead such users > > who really know what they are doing and are able to build their own > > kernel to enable it. Mark both driver Kconfig entries as dangerous to > > make sure the driver is not accidentally enabled without understanding > > possible issues in doing so. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > --- > > drivers/mtd/spi-nor/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > index 89da88e59121..f480b227a6b8 100644 > > --- a/drivers/mtd/spi-nor/Kconfig > > +++ b/drivers/mtd/spi-nor/Kconfig > > @@ -90,7 +90,7 @@ config SPI_INTEL_SPI > > tristate > > > > config SPI_INTEL_SPI_PCI > > - tristate "Intel PCH/PCU SPI flash PCI driver" > > + tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" > > I guess it might be even better and safer to add "default n" too, don't > you agree? Adding only the "DANGEROUS" word would not prevent build > scripts to select this driver when creating a kernel config from scratch. How about adding depends on EXPERT ? > > Best regards, > > Cyrille > > > depends on X86 && PCI > > select SPI_INTEL_SPI > > help > > @@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI > > will be called intel-spi-pci. > > > > config SPI_INTEL_SPI_PLATFORM > > - tristate "Intel PCH/PCU SPI flash platform driver" > > + tristate "Intel PCH/PCU SPI flash platform driver (DANGEROUS)" > > depends on X86 > > select SPI_INTEL_SPI > > help > > >
On Sun, Jan 07, 2018 at 09:32:46PM +0100, Cyrille Pitchen wrote: > Hi Mika, > > Le 04/01/2018 à 10:07, Mika Westerberg a écrit : > > The driver is not meant for normal users at all but instead such users > > who really know what they are doing and are able to build their own > > kernel to enable it. Mark both driver Kconfig entries as dangerous to > > make sure the driver is not accidentally enabled without understanding > > possible issues in doing so. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > --- > > drivers/mtd/spi-nor/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > index 89da88e59121..f480b227a6b8 100644 > > --- a/drivers/mtd/spi-nor/Kconfig > > +++ b/drivers/mtd/spi-nor/Kconfig > > @@ -90,7 +90,7 @@ config SPI_INTEL_SPI > > tristate > > > > config SPI_INTEL_SPI_PCI > > - tristate "Intel PCH/PCU SPI flash PCI driver" > > + tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" > > I guess it might be even better and safer to add "default n" too, don't > you agree? Adding only the "DANGEROUS" word would not prevent build > scripts to select this driver when creating a kernel config from scratch. But isn't it always "default n" unless otherwise stated?
On Sun, Jan 07, 2018 at 10:06:31PM +0100, Boris Brezillon wrote: > On Sun, 7 Jan 2018 21:32:46 +0100 > Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> wrote: > > > Hi Mika, > > > > Le 04/01/2018 à 10:07, Mika Westerberg a écrit : > > > The driver is not meant for normal users at all but instead such users > > > who really know what they are doing and are able to build their own > > > kernel to enable it. Mark both driver Kconfig entries as dangerous to > > > make sure the driver is not accidentally enabled without understanding > > > possible issues in doing so. > > > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > --- > > > drivers/mtd/spi-nor/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig > > > index 89da88e59121..f480b227a6b8 100644 > > > --- a/drivers/mtd/spi-nor/Kconfig > > > +++ b/drivers/mtd/spi-nor/Kconfig > > > @@ -90,7 +90,7 @@ config SPI_INTEL_SPI > > > tristate > > > > > > config SPI_INTEL_SPI_PCI > > > - tristate "Intel PCH/PCU SPI flash PCI driver" > > > + tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" > > > > I guess it might be even better and safer to add "default n" too, don't > > you agree? Adding only the "DANGEROUS" word would not prevent build > > scripts to select this driver when creating a kernel config from scratch. > > How about adding > > depends on EXPERT > > ? It used to be like that but then it was pointed out by Arnd Bergman that EXPERT is not about hiding drivers and got removed by b8cc0012917d ("spi-nor: intel-spi: Remove EXPERT dependency").
diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig index 89da88e59121..f480b227a6b8 100644 --- a/drivers/mtd/spi-nor/Kconfig +++ b/drivers/mtd/spi-nor/Kconfig @@ -90,7 +90,7 @@ config SPI_INTEL_SPI tristate config SPI_INTEL_SPI_PCI - tristate "Intel PCH/PCU SPI flash PCI driver" + tristate "Intel PCH/PCU SPI flash PCI driver (DANGEROUS)" depends on X86 && PCI select SPI_INTEL_SPI help @@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI will be called intel-spi-pci. config SPI_INTEL_SPI_PLATFORM - tristate "Intel PCH/PCU SPI flash platform driver" + tristate "Intel PCH/PCU SPI flash platform driver (DANGEROUS)" depends on X86 select SPI_INTEL_SPI help
The driver is not meant for normal users at all but instead such users who really know what they are doing and are able to build their own kernel to enable it. Mark both driver Kconfig entries as dangerous to make sure the driver is not accidentally enabled without understanding possible issues in doing so. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/mtd/spi-nor/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)