From patchwork Mon Dec 25 22:55:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 852883 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vCyjKTGw"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AAgw6dDt"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z5Dwv3byYz9rxj for ; Tue, 26 Dec 2017 09:55:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8FVN8abpdp1lPChB5XT51H3IBYaUtrixVTTOUO+8IeI=; b=vCyjKTGwfzTj60 4v6bvGinAHx2+s41bbRRChodR7uZtSRiR54CyY/ywcToFEM4FC8SGCnDLxhGG5v9hAcX9VYBav+bJ ksBXAi7xY++9A0nD1d95WZjy47tAkv2po07TwqNtcHIdWbNb2TVZnt46GX1iM7ifG/nQWDoF9Kd9E EFwPKjBHHapG/pscKX5dyzjKzCV0p1mVOq0pOF4L4W3ow6qhEAfSVIAQ/0X0qbiPk7HqzKdNKmGTK 9OUd7QPJ2nF6tFdV0Y3IHc8NXDMUL99JRvT/nix/YY0rrxKqTo/F72OME7z9LbjAEkJt5HXq4Vaam 5lvyrqIi2tK0OF5zB9CQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eTbef-0007Uj-9T; Mon, 25 Dec 2017 22:55:33 +0000 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eTbeb-0007TC-CM for lede-dev@lists.infradead.org; Mon, 25 Dec 2017 22:55:31 +0000 Received: by mail-pl0-x244.google.com with SMTP id z5so17058289plo.10 for ; Mon, 25 Dec 2017 14:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zPGAziZM5a5iO8VsBJoa/YAUrlKByfJgnOjly/jG5Dw=; b=AAgw6dDtoU07kyENvUt3ranWSdlrqswEoyRVdsdXISoojZhiXjtwk/67X9rG+Xwlin CYZz6AWzIAvHFMRErqRAtxkTs3+FIrn+zPEGvv0LDZwxLf6D7mLbMu1yFC9jhk1vAgRl s+DvyfmwR9gP5eBMjb0XeiHQ9oG5tGfR2IAPUxDDp+6bmBTKj//kiu32LvhROYbRulx3 8BCsv6rdXsfpRy82NAA9SOa2tFHrwGPtegEYlCviTNvtRidSs70+pw1dwKH3WCcc2ecY ftkIdMLo3UzdR3OSPwMJoWm3ZCc1ezJ5RPtpIUU72tDnQPquOfPiGXuXLhqem22Fivu7 jt0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zPGAziZM5a5iO8VsBJoa/YAUrlKByfJgnOjly/jG5Dw=; b=ATErLgI0qf0Z0tZdSaTVBZ2TTayP+lEMRoj/yMG9WFP7nqINqjVXAWX1Eyj3Xj5SxK jFGqINvYjSHYuo7Kj1JJD/hA+25YwkQC1D6d7EuT83R8/dDFocQg+G8SkXPWTI2eEoTc R7GyK364kaWHCPFn/fmq8WXmqyPS1AoYclu/4BzpGQe3Tzj+A5uaBf+gSC115vwPWuln lJFVzlei0LiMygNI+e8ggQRPD5zqS10cGxv+2bUsy00vh/4v5dUaPTb54yqPk4iYY96x vSN9e9thYpfIiaJ6YEy3FFNKGN8QODqUWME2Pz0Cpa6w3jdHfwda11pOi5QFax/64mvK wh5Q== X-Gm-Message-State: AKGB3mLqJmeu39qr1SOOM8aS/Q1qVDtlxNSzzTv7v2g3hXEABjkaW6kk 3tMitPqkN33fVc3yqzlCSdwYVHbt X-Google-Smtp-Source: ACJfBot2Vw9JgdU6rx/givoD7P1+SlulavP8bJKXz1nKavnAI/X56BxvbwLJVHHDZwqbelzzeiRUhw== X-Received: by 10.159.202.151 with SMTP id p23mr23980838plo.366.1514242518508; Mon, 25 Dec 2017 14:55:18 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:98da:65ff:24e5:ee50]) by smtp.gmail.com with ESMTPSA id y5sm59432556pfd.63.2017.12.25.14.55.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Dec 2017 14:55:17 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 25 Dec 2017 14:55:23 -0800 Message-Id: <1514242524-4319-1-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171225_145529_453248_4E744798 X-CRM114-Status: UNSURE ( 7.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c01:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH 1/2] firewall3: Replace strerror(errno) with %m X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Size reductiom in resulting binaries. No functional difference. Signed-off-by: Rosen Penev --- defaults.c | 2 +- includes.c | 4 ++-- utils.c | 14 +++++++------- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/defaults.c b/defaults.c index 85a3750..f1be1dd 100644 --- a/defaults.c +++ b/defaults.c @@ -327,7 +327,7 @@ set_default(const char *name, int set) if (!(f = fopen(path, "w"))) { - info(" ! Unable to write value: %s", strerror(errno)); + info(" ! Unable to write value: %m"); return; } diff --git a/includes.c b/includes.c index 8639210..bea380c 100644 --- a/includes.c +++ b/includes.c @@ -135,7 +135,7 @@ print_include(struct fw3_include *include) if (!(f = fopen(include->path, "r"))) { - info(" ! Skipping due to open error: %s", strerror(errno)); + info(" ! Skipping due to open error: %m"); return; } @@ -200,7 +200,7 @@ run_include(struct fw3_include *include) if (stat(include->path, &s)) { - info(" ! Skipping due to path error: %s", strerror(errno)); + info(" ! Skipping due to path error: %m"); return; } diff --git a/utils.c b/utils.c index 024f95e..a66de74 100644 --- a/utils.c +++ b/utils.c @@ -346,13 +346,13 @@ fw3_lock(void) if (lock_fd < 0) { - warn("Cannot create lock file %s: %s", FW3_LOCKFILE, strerror(errno)); + warn("Cannot create lock file %s: %m", FW3_LOCKFILE); return false; } if (flock(lock_fd, LOCK_EX)) { - warn("Cannot acquire exclusive lock: %s", strerror(errno)); + warn("Cannot acquire exclusive lock: %m"); return false; } @@ -366,7 +366,7 @@ fw3_unlock(void) return; if (flock(lock_fd, LOCK_UN)) - warn("Cannot release exclusive lock: %s", strerror(errno)); + warn("Cannot release exclusive lock: %m"); close(lock_fd); unlink(FW3_LOCKFILE); @@ -633,13 +633,13 @@ fw3_write_statefile(void *state) if (!sf) { - warn("Cannot create state %s: %s", FW3_STATEFILE, strerror(errno)); + warn("Cannot create state %s: %m", FW3_STATEFILE); return; } if (getifaddrs(&ifaddr)) { - warn("Cannot get interface addresses: %s", strerror(errno)); + warn("Cannot get interface addresses: %m"); ifaddr = NULL; } @@ -722,7 +722,7 @@ fw3_hotplug(bool add, void *zone, void *device) switch (fork()) { case -1: - warn("Unable to fork(): %s\n", strerror(errno)); + warn("Unable to fork(): %m\n"); return false; case 0: @@ -839,7 +839,7 @@ fw3_flush_conntrack(void *state) if (getifaddrs(&ifaddr)) { - warn("Cannot get interface addresses: %s", strerror(errno)); + warn("Cannot get interface addresses: %m"); return; }