[ovs-dev] bfd: Send BFD packets with DSCP CS6

Message ID DBXPR07MB479E7752ADDF5FC0323D1DCEA010@DBXPR07MB479.eurprd07.prod.outlook.com
State New
Headers show
Series
  • [ovs-dev] bfd: Send BFD packets with DSCP CS6
Related show

Commit Message

Venkatesan Pradeep Dec. 25, 2017, 4:59 p.m.
Send BFD packets with TOS value equivalent to DSCP CS6 so that the network 
can apply the right QoS for those packets. This can help avoid BFD flaps due 
to network congestion.

Signed-off-by: Venkatesan Pradeep <venkatesan.pradeep@ericsson.com>
---
 lib/bfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Venkatesan Pradeep Jan. 10, 2018, 5:01 a.m. | #1
Gentle reminder to review this patch.

Regards,

Pradeep

-----Original Message-----
From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Venkatesan Pradeep
Sent: Monday, December 25, 2017 10:29 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] bfd: Send BFD packets with DSCP CS6

Send BFD packets with TOS value equivalent to DSCP CS6 so that the network can apply the right QoS for those packets. This can help avoid BFD flaps due to network congestion.

Signed-off-by: Venkatesan Pradeep <venkatesan.pradeep@ericsson.com>
---
 lib/bfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bfd.c b/lib/bfd.c
index 40cd0be..8d291bb 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -612,7 +612,7 @@ bfd_put_packet(struct bfd *bfd, struct dp_packet *p,
     ip->ip_ihl_ver = IP_IHL_VER(5, 4);
     ip->ip_tot_len = htons(sizeof *ip + sizeof *udp + sizeof *msg);
     ip->ip_ttl = MAXTTL;
-    ip->ip_tos = IPTOS_LOWDELAY | IPTOS_THROUGHPUT;
+    ip->ip_tos = IPTOS_PREC_INTERNETCONTROL;
     ip->ip_proto = IPPROTO_UDP;
     put_16aligned_be32(&ip->ip_src, bfd->ip_src);
     put_16aligned_be32(&ip->ip_dst, bfd->ip_dst); _______________________________________________
dev mailing list
dev@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Zoltán Balogh Jan. 16, 2018, 9:55 a.m. | #2
Hi,

Acked-by: Zoltan Balogh <zoltan.balogh@ericsson.com>

Ben, is there a chance to get this into 2.9?

Best regards,
Zoltan

> -----Original Message-----
> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Venkatesan Pradeep
> Sent: Wednesday, January 10, 2018 6:02 AM
> To: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] bfd: Send BFD packets with DSCP CS6
> 
> Gentle reminder to review this patch.
> 
> Regards,
> 
> Pradeep
> 
> -----Original Message-----
> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Venkatesan Pradeep
> Sent: Monday, December 25, 2017 10:29 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH] bfd: Send BFD packets with DSCP CS6
> 
> Send BFD packets with TOS value equivalent to DSCP CS6 so that the network can apply the right QoS for those
> packets. This can help avoid BFD flaps due to network congestion.
> 
> Signed-off-by: Venkatesan Pradeep <venkatesan.pradeep@ericsson.com>
> ---
>  lib/bfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/bfd.c b/lib/bfd.c
> index 40cd0be..8d291bb 100644
> --- a/lib/bfd.c
> +++ b/lib/bfd.c
> @@ -612,7 +612,7 @@ bfd_put_packet(struct bfd *bfd, struct dp_packet *p,
>      ip->ip_ihl_ver = IP_IHL_VER(5, 4);
>      ip->ip_tot_len = htons(sizeof *ip + sizeof *udp + sizeof *msg);
>      ip->ip_ttl = MAXTTL;
> -    ip->ip_tos = IPTOS_LOWDELAY | IPTOS_THROUGHPUT;
> +    ip->ip_tos = IPTOS_PREC_INTERNETCONTROL;
>      ip->ip_proto = IPPROTO_UDP;
>      put_16aligned_be32(&ip->ip_src, bfd->ip_src);
>      put_16aligned_be32(&ip->ip_dst, bfd->ip_dst); _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Patch

diff --git a/lib/bfd.c b/lib/bfd.c
index 40cd0be..8d291bb 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -612,7 +612,7 @@  bfd_put_packet(struct bfd *bfd, struct dp_packet *p,
     ip->ip_ihl_ver = IP_IHL_VER(5, 4);
     ip->ip_tot_len = htons(sizeof *ip + sizeof *udp + sizeof *msg);
     ip->ip_ttl = MAXTTL;
-    ip->ip_tos = IPTOS_LOWDELAY | IPTOS_THROUGHPUT;
+    ip->ip_tos = IPTOS_PREC_INTERNETCONTROL;
     ip->ip_proto = IPPROTO_UDP;
     put_16aligned_be32(&ip->ip_src, bfd->ip_src);
     put_16aligned_be32(&ip->ip_dst, bfd->ip_dst);