| Message ID | 1513827761-96181-1-git-send-email-jpettit@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ofproto-dpif: Fix a couple minor issues in comments. | expand |
Thanks for the change. Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> On Wed, Dec 20, 2017 at 7:42 PM, Justin Pettit <jpettit@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpettit@ovn.org> > --- > ofproto/ofproto-dpif-upcall.h | 2 +- > ofproto/ofproto-dpif-xlate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ofproto/ofproto-dpif-upcall.h b/ofproto/ofproto-dpif-upcall.h > index efa3cd190084..cef1d34198d6 100644 > --- a/ofproto/ofproto-dpif-upcall.h > +++ b/ofproto/ofproto-dpif-upcall.h > @@ -24,7 +24,7 @@ struct ofpbuf; > struct seq; > struct simap; > > -/* Udif is responsible for retrieving upcalls from the kernel and > processing > +/* Udpif is responsible for retrieving upcalls from the kernel and > processing > * them. Additionally, it's responsible for maintaining the datapath flow > * table. */ > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index 9b3a2f28a348..a2b4fdb3b6be 100644 > --- a/ofproto/ofproto-dpif-xlate.c > +++ b/ofproto/ofproto-dpif-xlate.c > @@ -1387,7 +1387,7 @@ xlate_lookup_ofproto(const struct dpif_backer > *backer, const struct flow *flow, > } > > /* Given a datapath and flow metadata ('backer', and 'flow' respectively), > - * optionally populates 'ofproto' with the ofproto_dpif, 'ofp_in_port' > with the > + * optionally populates 'ofprotop' with the ofproto_dpif, 'ofp_in_port' > with the > * openflow in_port, and 'ipfix', 'sflow', and 'netflow' with the > appropriate > * handles for those protocols if they're enabled. Caller may use the > returned > * pointers until quiescing, for longer term use additional references > must > -- > 2.7.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Wed, Dec 20, 2017 at 07:42:39PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpettit@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
> On Dec 21, 2017, at 10:21 AM, Ben Pfaff <blp@ovn.org> wrote: > > On Wed, Dec 20, 2017 at 07:42:39PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpettit@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks. I pushed this with yours and Yufeng's acks. --Justin
diff --git a/ofproto/ofproto-dpif-upcall.h b/ofproto/ofproto-dpif-upcall.h index efa3cd190084..cef1d34198d6 100644 --- a/ofproto/ofproto-dpif-upcall.h +++ b/ofproto/ofproto-dpif-upcall.h @@ -24,7 +24,7 @@ struct ofpbuf; struct seq; struct simap; -/* Udif is responsible for retrieving upcalls from the kernel and processing +/* Udpif is responsible for retrieving upcalls from the kernel and processing * them. Additionally, it's responsible for maintaining the datapath flow * table. */ diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 9b3a2f28a348..a2b4fdb3b6be 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -1387,7 +1387,7 @@ xlate_lookup_ofproto(const struct dpif_backer *backer, const struct flow *flow, } /* Given a datapath and flow metadata ('backer', and 'flow' respectively), - * optionally populates 'ofproto' with the ofproto_dpif, 'ofp_in_port' with the + * optionally populates 'ofprotop' with the ofproto_dpif, 'ofp_in_port' with the * openflow in_port, and 'ipfix', 'sflow', and 'netflow' with the appropriate * handles for those protocols if they're enabled. Caller may use the returned * pointers until quiescing, for longer term use additional references must
Signed-off-by: Justin Pettit <jpettit@ovn.org> --- ofproto/ofproto-dpif-upcall.h | 2 +- ofproto/ofproto-dpif-xlate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)